From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#46859: 28.0.50; [PATCH]: Add option to truncate long lines in xref.el Date: Tue, 2 Mar 2021 22:45:43 +0100 Message-ID: References: Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27078"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46859@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 02 22:46:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHCqM-0006tS-IM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 22:46:14 +0100 Original-Received: from localhost ([::1]:56350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHCqL-0000Kz-K5 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 16:46:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHCqB-0000Gs-8Q for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 16:46:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHCqA-0007tP-I8 for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 16:46:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHCqA-0008NT-H5 for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 16:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Mar 2021 21:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46859 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46859-submit@debbugs.gnu.org id=B46859.161472155132184 (code B ref 46859); Tue, 02 Mar 2021 21:46:02 +0000 Original-Received: (at 46859) by debbugs.gnu.org; 2 Mar 2021 21:45:51 +0000 Original-Received: from localhost ([127.0.0.1]:54414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHCpy-0008N2-Nt for submit@debbugs.gnu.org; Tue, 02 Mar 2021 16:45:50 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]:45033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHCpv-0008Ms-I3 for 46859@debbugs.gnu.org; Tue, 02 Mar 2021 16:45:49 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201243 Archived-At: > 2. mar. 2021 kl. 22:37 skrev Dmitry Gutov : >=20 > =EF=BB=BFHi Theodor, >=20 >> On 02.03.2021 23:13, Theodor Thornhill via Bug reports for GNU Emacs, the= Swiss army knife of text editors wrote: >> Yeah, maybe. However, without benchmarking, it is quite clear that >> adding your option is faster than my patch, since ripgrep has to search >> the whole minified file. I assume it short circuits, so that results >> are delivered quicker to emacs. Maybe this bug can be closed. >=20 > Could you try benchmarking both approaches? >=20 Absolutely, I will see what I can come up with. > If the performance improvement from yours is at all comparable with Juri's= , I'm inclined to prefer that direction for reasons described in https://deb= bugs.gnu.org/cgi/bugreport.cgi?bug=3D44983#71. >=20 Yeah, that was my initial motivation for this change as well.=20 > In both cases Ripgrep (or Grep) will search the whole file. The -M flag ju= st affects its output. Oh, ok! Ill get back to you. =E2=80=94 Theo=