From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser Date: Mon, 6 Feb 2023 19:00:30 -0800 Message-ID: References: <83edr3q8ez.fsf@gnu.org> <87o7q7dl4o.fsf@masteringemacs.org> <83a61rq6ck.fsf@gnu.org> <87k00uexdt.fsf@masteringemacs.org> <835yceris5.fsf@gnu.org> <87fsbievbi.fsf@masteringemacs.org> <83y1paq0pd.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19358"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61235@debbugs.gnu.org, Mickey Petersen To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 07 04:31:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPEhP-0004vS-NR for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Feb 2023 04:31:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPEhF-0002A6-7M; Mon, 06 Feb 2023 22:31:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPEhD-00029C-7a for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 22:31:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPEhC-00054n-DP for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 22:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPEhC-0007G6-9A for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 22:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Feb 2023 03:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61235 X-GNU-PR-Package: emacs Original-Received: via spool by 61235-submit@debbugs.gnu.org id=B61235.167574063427865 (code B ref 61235); Tue, 07 Feb 2023 03:31:02 +0000 Original-Received: (at 61235) by debbugs.gnu.org; 7 Feb 2023 03:30:34 +0000 Original-Received: from localhost ([127.0.0.1]:50563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPEgk-0007FM-8Q for submit@debbugs.gnu.org; Mon, 06 Feb 2023 22:30:34 -0500 Original-Received: from mail-vs1-f46.google.com ([209.85.217.46]:43617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPEgf-0007F7-Hl for 61235@debbugs.gnu.org; Mon, 06 Feb 2023 22:30:33 -0500 Original-Received: by mail-vs1-f46.google.com with SMTP id g3so3572143vsr.10 for <61235@debbugs.gnu.org>; Mon, 06 Feb 2023 19:30:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=n1q5OmhlNa1fC8SJeBOntpjLU8PsH2rVEhB/9x2/hwY=; b=cMltyiuBIhyntysMg5DeSfaKrIu7pPfE9XYRXZKignIDxQNHnx/V+Ar2FrpazXEaFg v9ySFXmgd6DHCGGBfDq0sExiJr35/2e7pdKoRUiJLfvshlnmCoxUHeOsRgeelXoEVyck SPM5mdJ4ai6pQeZxdG4m0DvpKnPrx++fNTGCruNmy10k4EusX0ZWC7RghvTtk31tshb0 LESSJKeKzIuP67vuHNzra71JehAZPm6XzivvqWcaSkZN229F2h3+wfXd/sdzuWdtbdQu OsY2txpp5+zMtcprtkjhHTVQgvr0IoHOHy66tGuaXewMuLrYLMjI7wbxuEyF0VkM6mlo JNBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n1q5OmhlNa1fC8SJeBOntpjLU8PsH2rVEhB/9x2/hwY=; b=K4iaWBl/iBlBjaDVaO8O1Vk3euIc1p+7Ks6wlpPVRVbWiHBvPKVbFivdbBi+eZoCNG zN18il0W4VKzj+Gcn0iuV2fzQpHuEwkn/A4D+NbTUDPHKlvMIS6bImceoGpsX0QFk9WS VOmsvFIowyLg+IS7Ml+gr6Mupa6GO/hhUimkXG21lN3Xm8pMdggRXRnfySb5z42NhbNV 1qEHnHcn5ENYe+mWs66pFkxUYd3Y+SwHOH84zdVg9hKjryYzavu05hlTavNXNq2rbhap JTLYjtkzpP/Nj5z/fnrcg+3qNlnC4vml7Y2t714vpsQ2BXDxRzH1jAy81l2nMxy20Y4Q nbrQ== X-Gm-Message-State: AO0yUKXDanZJjSho7WNSBoE2/ow9smHUParv/JEVo7iJTkuRXItreTqi ZjR5NSMoqs3V5b0134Qii1I= X-Google-Smtp-Source: AK7set8xvThCRtjA7U1JEAhveOGTOro2WOz56Ngl0HkS9S4HA1TOEV6s+BVqgMzEGQJzWhx/pVnQvQ== X-Received: by 2002:a17:902:e888:b0:199:1f1b:3634 with SMTP id w8-20020a170902e88800b001991f1b3634mr1247966plg.26.1675738842071; Mon, 06 Feb 2023 19:00:42 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id v3-20020a170902e8c300b0019602274208sm7022609plg.186.2023.02.06.19.00.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2023 19:00:41 -0800 (PST) In-Reply-To: <83y1paq0pd.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.300.101.1.3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255016 Archived-At: > On Feb 6, 2023, at 7:21 AM, Eli Zaretskii wrote: >=20 >> From: Mickey Petersen >> Cc: casouri@gmail.com, 61235@debbugs.gnu.org >> Date: Mon, 06 Feb 2023 14:08:46 +0000 >>=20 >> All I want is a way for treesit-node-check to tell me if the node >> belongs to a dead or alive parser. >=20 > That'd be fine by me, but the patch posted by Yuan was a different > one. >=20 > Yuan, any reason not to extend treesit-node-check instead? I did extend treesit-node-check in the patch. But I also added a = function treesit-parser-live-p, which makes the same check but directly = on a parser. It just made sense to me that if we let treesit-node-check = check the nodes=E2=80=99 parser=E2=80=99s status, we=E2=80=99d also add = a function to allow directly checking the status of a parser. Micky, the function I added (and the extension to treesit-node-check) = checks that the parser is not deleted AND its buffer is live. That makes = the most sense to me, but would it cause any problem for your use case? Yuan=