From: Randy Taylor <dev@rjt.dev>
To: Evgeni Kolev <evgenysw@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, Yuan Fu <casouri@gmail.com>,
60407@debbugs.gnu.org
Subject: bug#60407: [PATCH] Update go-ts-mode to use Imenu facility
Date: Sun, 01 Jan 2023 22:31:31 +0000 [thread overview]
Message-ID: <E4Sh2YiWGAnxlNUc74mCvy1EIIx6lK-32GzKKuj2G1BmahFjyzdtOZRgOEmeCSkHPVjTfUpGpLkFaAsrpRXHkJGZD2oVVclzT5pfoDosKOY=@rjt.dev> (raw)
In-Reply-To: <CAMCrgaUtTERt9QcT3-LJVZcyX00UASFKY7+moN4gH2yz_ccB9A@mail.gmail.com>
On Sunday, January 1st, 2023 at 12:08, Evgeni Kolev <evgenysw@gmail.com> wrote:
>
> As I mentioned in the start of the mail thread - go-ts-mode's Imenu
> puts Go interfaces and structs in the same "Type" bucket. This can be
> improved in go-ts-mode.
>
> I'm providing a second patch below which splits the interfaces and
> structs into their own Imenu categories.
>
> Please let me know if I should provide the second patch later, in a
> separate thread, after the first patch is finished. I'm assuming it's
> simpler to review the patches together. If it's not - I'll provide
> them in a way to make the review easier, just let me know.
>
Hi Evgeni!
Thanks for working on this, and apologies for the delay.
The patches look good to me and work well, except for one issue (and a few minor nits) mentioned below. All in one patch is probably best.
- Type definitions are no longer captured. For example:
type Quack int
Does not show up anymore.
- go-ts-mode--struct-node-p's docstring is missing a period at the end.
- In go-ts-mode--interface-node-p and go-ts-mode--struct-node-p's docstrings, I'm not sure it's worthwhile to mention "Go". Just interface and struct should be fine.
- Should the commit message mention changes to go-ts-mode (as in the actual define-derived-mode mode part)?
next prev parent reply other threads:[~2023-01-01 22:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 16:05 bug#60407: [PATCH] Update go-ts-mode to use Imenu facility Evgeni Kolev
2023-01-01 9:07 ` Eli Zaretskii
2023-01-01 13:05 ` Evgeni Kolev
2023-01-01 17:08 ` Evgeni Kolev
2023-01-01 22:31 ` Randy Taylor [this message]
2023-01-03 9:01 ` Evgeni Kolev
2023-01-03 14:30 ` Randy Taylor
2023-01-05 7:24 ` Evgeni Kolev
2023-01-05 14:21 ` Randy Taylor
2023-01-01 13:08 ` Randy Taylor
2023-01-08 0:20 ` Yuan Fu
2023-01-08 8:10 ` Evgeni Kolev
2023-01-08 10:59 ` Eli Zaretskii
2023-01-09 0:35 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='E4Sh2YiWGAnxlNUc74mCvy1EIIx6lK-32GzKKuj2G1BmahFjyzdtOZRgOEmeCSkHPVjTfUpGpLkFaAsrpRXHkJGZD2oVVclzT5pfoDosKOY=@rjt.dev' \
--to=dev@rjt.dev \
--cc=60407@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=evgenysw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).