From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#39595: #39595: M-x compile still very line-length weak Date: Sat, 15 Feb 2020 17:45:54 +0100 Message-ID: References: <9D8A11CB-9ABE-4A66-87D0-2E445499B74F@acm.org> <83tv3tnlx3.fsf@gnu.org> <7A842DF4-BACB-4CB2-A9DD-40AA57CA8DF0@acm.org> <83k14onvzl.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_E0D5D86B-82EB-4CEC-9B9B-34050BBE16D7" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="102703"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39595@debbugs.gnu.org, jidanni@jidanni.org, pogonyshev@gmail.com, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 15 17:47:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j30b0-000Qao-W9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Feb 2020 17:47:11 +0100 Original-Received: from localhost ([::1]:52694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j30az-0000Of-Ua for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Feb 2020 11:47:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50543) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j30at-0000OZ-2C for bug-gnu-emacs@gnu.org; Sat, 15 Feb 2020 11:47:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j30as-0003s7-4B for bug-gnu-emacs@gnu.org; Sat, 15 Feb 2020 11:47:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58600) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j30as-0003s0-0y for bug-gnu-emacs@gnu.org; Sat, 15 Feb 2020 11:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j30ar-000758-UZ for bug-gnu-emacs@gnu.org; Sat, 15 Feb 2020 11:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Feb 2020 16:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39595 X-GNU-PR-Package: emacs Original-Received: via spool by 39595-submit@debbugs.gnu.org id=B39595.158178517024865 (code B ref 39595); Sat, 15 Feb 2020 16:47:01 +0000 Original-Received: (at 39595) by debbugs.gnu.org; 15 Feb 2020 16:46:10 +0000 Original-Received: from localhost ([127.0.0.1]:36340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j30a1-0006Sd-IW for submit@debbugs.gnu.org; Sat, 15 Feb 2020 11:46:09 -0500 Original-Received: from mail1463c50.megamailservers.eu ([91.136.14.63]:36864 helo=mail268c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j30Zx-0006KO-S3 for 39595@debbugs.gnu.org; Sat, 15 Feb 2020 11:46:07 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1581785159; bh=M84CemHJ2KsmFTYHi2K7JgE6hcxVhxThl8D4jj980qE=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=j8OXsgqD2QE1Bo4OFSlaNastS3lAu/5NjPgDBGEYwIzxWoPzMmHtKZ1reA9wXJuMt zMByhI2c8T/c/xwYVA52NbISEU76Lau8s2axkB8WkqQUT2DlI57asrFnhdgdUMA+vj rlqaMHQnH2QKcZjHdJY/mC3PQGAJvT+GM9wYgEfo= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-6f4fe655.032-75-73746f71.bbcust.telenor.se [85.230.79.111]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 01FGjsh9021605; Sat, 15 Feb 2020 16:45:56 +0000 In-Reply-To: <83k14onvzl.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020F.5E482047.0001, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=J53UEzvS c=1 sm=1 tr=0 a=fHaj9vQUQVKQ4sUldAaXuQ==:117 a=fHaj9vQUQVKQ4sUldAaXuQ==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=_We2dtD6XtwZI6sZdCYA:9 a=CjuIK1q_8ugA:10 a=hCIDtcLLymEkbjbx05kA:9 a=B2y7HmGcmWMA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176091 Archived-At: --Apple-Mail=_E0D5D86B-82EB-4CEC-9B9B-34050BBE16D7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 15 feb. 2020 kl. 08.35 skrev Eli Zaretskii : > I'm okay with disabling 'omake' if we have nowhere else to ask. We may not have to, after all. Reading the OMake sources, it very much = looks like errors are indented by exactly 6 spaces, which means that we = can replace (* " ") with (? "6 spaces") which is a lot faster. Having done that, it turned out that recognising ruby-Test::Unit errors = depended on the old 'omake' regexp rewriting (another reason to disable = omake by default, perhaps), so that regexp had to be fixed as well. Along with the two previous patches (for msft, watcom and maven), this = should reduce the cost of long lines to something more tolerable for the = time being. --Apple-Mail=_E0D5D86B-82EB-4CEC-9B9B-34050BBE16D7 Content-Disposition: attachment; filename=0001-Make-OMake-support-slightly-less-expensive-bug-39595.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Make-OMake-support-slightly-less-expensive-bug-39595.patch" Content-Transfer-Encoding: quoted-printable =46rom=2079f816e614218bce2c15d550bc2cf1a591f22e43=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Sat,=2015=20Feb=202020=2016:08:14=20+0100=0A= Subject:=20[PATCH]=20Make=20OMake=20support=20slightly=20less=20= expensive=20(bug#39595)=0A=0AWhen=20run=20with=20-p=20or=20-P,=20OMake=20= regurgitates=20error=20messages=20that=0Aprevented=20further=20progress,=20= indented=20by=206=20spaces.=20=20Use=20that=20fact=0Ato=20ameliorate=20= the=20modification=20done=20to=20other=20error=20message=20regexps.=0A=0A= *=20lisp/progmodes/compile.el=20(compilation-parse-errors):=0AWhen=20= 'omake'=20is=20enabled,=20allow=20error=20messages=20to=20be=20indented=20= by=200=20or=206=0Aspaces=20instead=20of=20any=20number=20of=20spaces,=20= to=20avoid=20pathological=0Abehaviour.=0A= (compilation-error-regexp-alist-alist):=20Anchor=20the=20'omake'=20= pattern=20to=0Abol=20for=20performance.=20=20Repair=20the=20= 'ruby-Test::Unit'=20pattern,=20which=0Arelied=20on=20the=20previously=20= over-generous=20'omake'=20hack.=0A*=20etc/compilation.txt=20(OMake):=20= Add=20examples.=0A*=20test/lisp/progmodes/compile-tests.el=20= (compile-tests--test-regexps-data)=0A(compile-test-error-regexps):=20Add=20= test=20for=20OMake=20(indented=20error).=0A---=0A=20etc/compilation.txt=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20|=2016=20= ++++++++++++++++=0A=20lisp/progmodes/compile.el=20=20=20=20=20=20=20=20=20= =20=20=20|=20=206=20+++---=0A=20test/lisp/progmodes/compile-tests.el=20|=20= =205=20++++-=0A=203=20files=20changed,=2023=20insertions(+),=204=20= deletions(-)=0A=0Adiff=20--git=20a/etc/compilation.txt=20= b/etc/compilation.txt=0Aindex=20a597216daa..69db891907=20100644=0A---=20= a/etc/compilation.txt=0A+++=20b/etc/compilation.txt=0A@@=20-382,6=20= +382,22=20@@=20symbol:=20watcom=0A=20..\src\ctrl\lister.c(120):=20= Warning!=20W201:=20Unreachable=20code=0A=20=0A=20=0A+*=20OMake=0A+=0A= +symbol:=20omake=0A+=0A+When=20using=20in=20-p=20or=20-P=20mode,=20OMake=20= will=20detect=20changes=20to=20files=20and=0A+report=20critical=20build=20= errors=20indented=20by=206=20spaces.=0A+=0A+***=20omake:=20file=20= alpha.c=20changed=0A+***=20omake:=20targets=20were=20not=20rebuilt=20= because=20of=20errors:=0A+=20=20=20alpha.o=0A+=20=20=20=20=20=20depends=20= on:=20alpha.c=0A+=20=20=20=20=20=20-=20build=20.=20alpha.o=0A+=20=20=20=20= =20=20+=20cc=20-I.=20-c=20-o=20alpha.o=20alpha.c=0A+=20=20=20=20=20=20= alpha.c:5:15:=20error:=20expected=20';'=20after=20expression=0A+=0A+=0A=20= *=20Oracle=20pro*c=0A=20=0A=20symbol:=20oracle=0Adiff=20--git=20= a/lisp/progmodes/compile.el=20b/lisp/progmodes/compile.el=0Aindex=20= 79d2293e21..dcd2e59f10=20100644=0A---=20a/lisp/progmodes/compile.el=0A= +++=20b/lisp/progmodes/compile.el=0A@@=20-310,7=20+310,7=20@@=20= compilation-error-regexp-alist-alist=0A=20=20=20=20=20=201=202=203=20(4=20= .=205))=0A=20=0A=20=20=20=20=20(ruby-Test::Unit=0A-=20=20=20=20=20"^[\t=20= ]*\\[\\([^(].*\\):\\([1-9][0-9]*\\)\\(\\]\\)?:in=20"=201=202)=0A+=20=20=20= =20=20"^=20=20=20=20[[=20]?\\([^=20= (].*\\):\\([1-9][0-9]*\\)\\(\\]\\)?:in=20"=201=202)=0A=20=0A=20=20=20=20=20= (gmake=0A=20=20=20=20=20=20;;=20Set=20GNU=20make=20error=20messages=20as=20= INFO=20level.=0A@@=20-410,7=20+410,7=20@@=20= compilation-error-regexp-alist-alist=0A=20=20=20=20=20(omake=0A=20=20=20=20= =20=20;;=20"omake=20-P"=20reports=20"file=20foo=20changed"=0A=20=20=20=20= =20=20;;=20(useful=20if=20you=20do=20"cvs=20up"=20and=20want=20to=20see=20= what=20has=20changed)=0A-=20=20=20=20=20"omake:=20file=20\\(.*\\)=20= changed"=201=20nil=20nil=20nil=20nil=0A+=20=20=20=20=20"^\\*\\*\\*=20= omake:=20file=20\\(.*\\)=20changed"=201=20nil=20nil=20nil=20nil=0A=20=20=20= =20=20=20;;=20FIXME-omake:=20This=20tries=20to=20prevent=20reusing=20= pre-existing=20markers=0A=20=20=20=20=20=20;;=20for=20subsequent=20= messages,=20since=20those=20messages's=20line=20numbers=0A=20=20=20=20=20= =20;;=20are=20about=20another=20version=20of=20the=20file.=0A@@=20= -1457,7=20+1457,7=20@@=20compilation-parse-errors=0A=20=20=20=20=20=20=20= =20((not=20(memq=20'omake=20compilation-error-regexp-alist))=20nil)=0A=20= =20=20=20=20=20=20=20((string-match=20"\\`\\([^^]\\|\\^\\(=20= \\*\\|\\[\\)\\)"=20pat)=0A=20=20=20=20=20=20=20=20=20nil)=20;;=20Not=20= anchored=20or=20anchored=20but=20already=20allows=20empty=20spaces.=0A-=20= =20=20=20=20=20=20(t=20(setq=20pat=20(concat=20"^=20*"=20(substring=20= pat=201)))))=0A+=20=20=20=20=20=20=20(t=20(setq=20pat=20(concat=20= "^\\(?:=20=20=20=20=20=20\\)?"=20(substring=20pat=201)))))=0A=20=0A=20=20= =20=20=20=20=20(if=20(consp=20file)=09(setq=20fmt=20(cdr=20file)=09=20=20= file=20(car=20file)))=0A=20=20=20=20=20=20=20(if=20(consp=20line)=09= (setq=20end-line=20(cdr=20line)=20line=20(car=20line)))=0Adiff=20--git=20= a/test/lisp/progmodes/compile-tests.el=20= b/test/lisp/progmodes/compile-tests.el=0Aindex=20350b4eb400..01db77c9c3=20= 100644=0A---=20a/test/lisp/progmodes/compile-tests.el=0A+++=20= b/test/lisp/progmodes/compile-tests.el=0A@@=20-269,6=20+269,9=20@@=20= compile-tests--test-regexps-data=0A=20=20=20=20=20=201=20nil=20109=20= "..\\src\\ctrl\\lister.c")=0A=20=20=20=20=20= ("..\\src\\ctrl\\lister.c(120):=20Warning!=20W201:=20Unreachable=20code"=0A= =20=20=20=20=20=201=20nil=20120=20"..\\src\\ctrl\\lister.c")=0A+=20=20=20= =20;;=20omake=0A+=20=20=20=20("=20=20=20=20=20=20alpha.c:5:15:=20error:=20= expected=20';'=20after=20expression"=0A+=20=20=20=20=201=2015=205=20= "alpha.c")=0A=20=20=20=20=20;;=20oracle=0A=20=20=20=20=20("Semantic=20= error=20at=20line=20528,=20column=205,=20file=20erosacqdb.pc:"=0A=20=20=20= =20=20=201=205=20528=20"erosacqdb.pc")=0A@@=20-428,7=20+431,7=20@@=20= compile-test-error-regexps=0A=20=20=20=20=20=20=20=20=20=20=20= (compilation-num-warnings-found=200)=0A=20=20=20=20=20=20=20=20=20=20=20= (compilation-num-infos-found=200))=0A=20=20=20=20=20=20=20(mapc=20= #'compile--test-error-line=20compile-tests--test-regexps-data)=0A-=20=20=20= =20=20=20(should=20(eq=20compilation-num-errors-found=2092))=0A+=20=20=20= =20=20=20(should=20(eq=20compilation-num-errors-found=2093))=0A=20=20=20=20= =20=20=20(should=20(eq=20compilation-num-warnings-found=2036))=0A=20=20=20= =20=20=20=20(should=20(eq=20compilation-num-infos-found=2026)))))=0A=20=0A= --=20=0A2.21.1=20(Apple=20Git-122.3)=0A=0A= --Apple-Mail=_E0D5D86B-82EB-4CEC-9B9B-34050BBE16D7--