unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ian Eure <ian@digg.com>
To: emacs-pretest-bug@gnu.org
Subject: bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance
Date: Mon, 20 Jul 2009 13:49:46 -0700	[thread overview]
Message-ID: <E4A2171F-9EF9-4727-8BEE-AD48DAF78387@digg.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 488 bytes --]

A user came into #emacs today complaining that his paren matching was  
not working with a large file, and that font-locking broke as a result.

I found that this is controlled by blink-matching-paren-distance,  
which was increased to 25kb around 1997.

Attached is a patch which doubles this to 50kb, as this should be fine  
for modern machines. I think that we should seriously consider setting  
the default to nil, but this seems like a more conservative approach  
to the matter.


[-- Attachment #2: blink-matching-paren.patch --]
[-- Type: application/octet-stream, Size: 651 bytes --]

Index: simple.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/simple.el,v
retrieving revision 1.998
diff -u -u -r1.998 simple.el
--- simple.el	19 Jul 2009 00:33:11 -0000	1.998
+++ simple.el	20 Jul 2009 20:45:21 -0000
@@ -5254,7 +5254,7 @@
   :type 'boolean
   :group 'paren-blinking)
 
-(defcustom blink-matching-paren-distance (* 25 1024)
+(defcustom blink-matching-paren-distance (* 50 1024)
   "If non-nil, maximum distance to search backwards for matching open-paren.
 If nil, search stops at the beginning of the accessible portion of the buffer."
   :type '(choice (const nil) integer)

[-- Attachment #3: Type: text/plain, Size: 1 bytes --]



             reply	other threads:[~2009-07-20 20:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mf8wihe96h.fsf@fencepost.gnu.org>
2009-07-20 20:49 ` Ian Eure [this message]
2009-07-21  9:39   ` bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance martin rudalics
2009-07-21 16:17     ` Ian Eure
2009-07-21 17:23       ` martin rudalics
2009-07-21 16:22   ` Stefan Monnier
2009-07-22  2:40   ` bug#3889: marked as done (23.1.50; [PATCH] Increase blink-matching-paren-distance) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E4A2171F-9EF9-4727-8BEE-AD48DAF78387@digg.com \
    --to=ian@digg.com \
    --cc=3889@emacsbugs.donarmstrong.com \
    --cc=emacs-pretest-bug@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).