From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#52951: Including Swedish calendar localization (sv-kalender.el) in Emacs Date: Wed, 5 Jan 2022 10:54:43 +0100 Message-ID: References: Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26060"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Daniel Jensen , 52951@debbugs.gnu.org, Arthur Miller To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 05 10:55:28 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n530y-0006Yy-1w for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Jan 2022 10:55:28 +0100 Original-Received: from localhost ([::1]:43398 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n530w-00014T-2r for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Jan 2022 04:55:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n530Z-00010x-2G for bug-gnu-emacs@gnu.org; Wed, 05 Jan 2022 04:55:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56290) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n530Y-0003tw-Kq for bug-gnu-emacs@gnu.org; Wed, 05 Jan 2022 04:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n530Y-0001ug-DO for bug-gnu-emacs@gnu.org; Wed, 05 Jan 2022 04:55:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jan 2022 09:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52951 X-GNU-PR-Package: emacs Original-Received: via spool by 52951-submit@debbugs.gnu.org id=B52951.16413765017344 (code B ref 52951); Wed, 05 Jan 2022 09:55:02 +0000 Original-Received: (at 52951) by debbugs.gnu.org; 5 Jan 2022 09:55:01 +0000 Original-Received: from localhost ([127.0.0.1]:39603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n530W-0001uO-QV for submit@debbugs.gnu.org; Wed, 05 Jan 2022 04:55:01 -0500 Original-Received: from mail1450c50.megamailservers.eu ([91.136.14.50]:54648 helo=mail265c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n530U-0001u4-1l for 52951@debbugs.gnu.org; Wed, 05 Jan 2022 04:54:59 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1641376486; bh=AE9dLLBtmJaUqUbnmzFsnpcGRWzZcW1TmGwE5rUh0ik=; h=From:Subject:Date:Cc:To:From; b=Q6x7dThx8H2cUKDkPCXGXRZM1DUYoK3AxOn0kKsgd2nRKuYLAjkiufXnHy3EQnjg6 50ZljWPKq4L2C1HwRv9RmBlkO0M58Yw5cdl3UiSfQVmkSHQGpXK9ExYVedMnowRwLw GDlovjDdFNB5FPw7/R7KHkLwh6f6wd8BeyYUv7Yo= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail265c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 2059sic6015422; Wed, 5 Jan 2022 09:54:45 +0000 X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A742F28.61D56AE6.004F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223685 Archived-At: > http://bigwalter.net/daniel/elisp/sv-kalender.el Thank you! > (setq calendar-time-display-form > '(24-hours ":" minutes)) Standard Swedish style uses a dot as separator; the colon appears to = have crept in as a fairly recent Anglicism (and I think it looks a bit = tacky). The file should also use lexical-binding: t. > (eval-after-load "solar" We should probably use `with-eval-after-load`. > (eval calendar-location-name) Would `symbol-value` do instead of `eval` here? > '((if (fboundp 'atan) I think we can assume the presence of `atan`. > (funcall 'holiday-sexp calendar-daylight-savings-starts > (funcall 'holiday-sexp calendar-daylight-savings-ends Why the explicit `funcall`s? Is this a holiday code subtlety? By the way, is there a way to do without the defadvice? They tend to be = brittle.