From: "Mattias Engdegård" <mattiase@acm.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Daniel Jensen <daniel@bigwalter.net>,
52951@debbugs.gnu.org, Arthur Miller <arthur.miller@live.com>
Subject: bug#52951: Including Swedish calendar localization (sv-kalender.el) in Emacs
Date: Wed, 5 Jan 2022 10:54:43 +0100 [thread overview]
Message-ID: <E46A0E93-A34A-41AE-8357-7C9048B3DECA@acm.org> (raw)
In-Reply-To: <CADwFkmnZ+6=C=sw5TSVULpU005VcYq=1MJ5+ADkd9NBOXSY3Fg@mail.gmail.com>
> http://bigwalter.net/daniel/elisp/sv-kalender.el
Thank you!
> (setq calendar-time-display-form
> '(24-hours ":" minutes))
Standard Swedish style uses a dot as separator; the colon appears to have crept in as a fairly recent Anglicism (and I think it looks a bit tacky).
The file should also use lexical-binding: t.
> (eval-after-load "solar"
We should probably use `with-eval-after-load`.
> (eval calendar-location-name)
Would `symbol-value` do instead of `eval` here?
> '((if (fboundp 'atan)
I think we can assume the presence of `atan`.
> (funcall 'holiday-sexp calendar-daylight-savings-starts
> (funcall 'holiday-sexp calendar-daylight-savings-ends
Why the explicit `funcall`s? Is this a holiday code subtlety?
By the way, is there a way to do without the defadvice? They tend to be brittle.
next prev parent reply other threads:[~2022-01-05 9:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-02 14:41 bug#52951: Including Swedish calendar localization (sv-kalender.el) in Emacs Stefan Kangas
2022-01-02 19:16 ` Daniel Jensen
2022-01-02 23:43 ` Stefan Kangas
2022-01-05 9:54 ` Mattias Engdegård [this message]
2022-01-05 10:20 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E46A0E93-A34A-41AE-8357-7C9048B3DECA@acm.org \
--to=mattiase@acm.org \
--cc=52951@debbugs.gnu.org \
--cc=arthur.miller@live.com \
--cc=daniel@bigwalter.net \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).