From: Yuan Fu <casouri@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: Theodor Thornhill <theo@thornhill.no>,
Eli Zaretskii <eliz@gnu.org>,
Mickey Petersen <mickey@masteringemacs.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
73404@debbugs.gnu.org
Subject: bug#73404: 30.0.50; [forward/kill/etc]-sexp commands do not behave as expected in tree-sitter modes
Date: Thu, 9 Jan 2025 19:14:08 -0800 [thread overview]
Message-ID: <E45EFF06-5F2D-4636-A9E3-69F5EB166711@gmail.com> (raw)
In-Reply-To: <87plkwwigx.fsf@mail.linkov.net>
> On Jan 8, 2025, at 11:42 PM, Juri Linkov <juri@linkov.net> wrote:
>
>>>> 1. use keywords like
>>>>
>>>> (setq-local treesit-thing-settings
>>>> `((html
>>>> (:sexp ,(regexp-opt '("element" "text" "attribute" "value")))
>>>> (:list ,(regexp-opt '("element"")))
>>>> (:sentence "tag")
>>>> (:text ,(regexp-opt '("comment" "text"))))))
>>>>
>>>> 2. use a symbol property like (put 'list 'treesit-thing t)
>>>>
>>>> You decide ;-)
>>>
>>> Of course, there are more alternatives:
>>>
>>> - Use a symbol property like (put 'list 'treesit--this-is-a-function t)
>>> - Refuse functions represented as symbols (callers need to use an
>>> eta-wrapper).
>>> - Distinguish the two cases via a more verbose representation like
>>> `(thing list)` vs `(function list)`.
>>> - Use a string rather than a symbol.
>>> - <I'm sure you can come up with more options>
>>
>> Thanks. IMHO it’s best to keep it simple and familiar, so let’s keep
>> using symbols and use a symbol property to solve this edge case.
>> I think this problem is rare enough that we don’t need any fancy
>> solutions for it.
>>
>> Juri, please feel free to apply your symbol property patch. For the symbol
>> property name, I feel that something like
>> treesit-symbol-predicate/treesit-use-as-symbol-predicate would be more
>> descriptive.
>
> If we settle on the variant that keeps the current format with symbols,
> wouldn't it better to keep a symbol property name shorter?
>
> First I proposed 'treesit-predicate', but then realized it's wrong
> since it's opposite to the predicate function.
> 'treesit-thing' was better since it indicates that it's used in
> 'treesit-thing-settings'.
>
>> Since we don’t have docstrings for symbol properties (right?).
>
> There are no docstrings for symbol properties indeed. But I think
> the important property for the name is that it should be unique enough
> to be easily greppable. But I tried to grep, and 'treesit-thing' finds
> too many matches.
>
> So probably the most suitable symbol name would be 'treesit-thing-symbol',
> that currently has no occurrences in source code.
Sounds good. Let’s go with it then.
Yuan
next prev parent reply other threads:[~2025-01-10 3:14 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-21 5:06 bug#73404: 30.0.50; [forward/kill/etc]-sexp commands do not behave as expected in tree-sitter modes Mickey Petersen
2024-09-26 7:42 ` Yuan Fu
2024-09-26 9:56 ` Mickey Petersen
2024-09-26 10:53 ` Eli Zaretskii
2024-09-26 12:13 ` Mickey Petersen
2024-09-26 13:46 ` Eli Zaretskii
2024-09-26 15:21 ` Mickey Petersen
2024-09-26 15:45 ` Eli Zaretskii
2024-09-27 5:43 ` Yuan Fu
2024-09-29 16:56 ` Juri Linkov
2024-10-01 3:57 ` Yuan Fu
2024-10-01 17:49 ` Juri Linkov
2024-10-02 6:14 ` Yuan Fu
2024-12-05 18:52 ` Juri Linkov
2024-12-05 19:53 ` Juri Linkov
2024-12-10 17:20 ` Juri Linkov
2024-12-11 6:31 ` Yuan Fu
2024-12-11 15:12 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 15:29 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 16:50 ` Mickey Petersen
2024-12-11 18:27 ` Yuan Fu
2024-12-12 7:17 ` Juri Linkov
2024-12-12 7:40 ` Eli Zaretskii
2024-12-12 7:58 ` Juri Linkov
2024-12-12 8:14 ` Juri Linkov
2024-12-12 16:31 ` Juri Linkov
2024-12-12 17:49 ` Juri Linkov
2024-12-12 19:13 ` Eli Zaretskii
2024-12-13 7:06 ` Juri Linkov
2024-12-14 11:02 ` Eli Zaretskii
2024-12-14 18:14 ` Juri Linkov
2024-12-18 7:37 ` Juri Linkov
2024-12-19 4:04 ` Yuan Fu
2024-12-19 7:14 ` Juri Linkov
2024-12-19 7:18 ` bug#74963: Ambiguous treesit named and anonymous nodes in ruby-ts-mode Juri Linkov
2024-12-24 3:02 ` Yuan Fu
2024-12-24 7:17 ` Juri Linkov
2024-12-24 7:41 ` Juri Linkov
2024-12-25 3:25 ` Dmitry Gutov
2024-12-25 7:52 ` Juri Linkov
2024-12-26 1:00 ` Dmitry Gutov
2024-12-27 7:42 ` Juri Linkov
2024-12-24 17:52 ` Juri Linkov
2024-12-24 21:03 ` Yuan Fu
2024-12-25 7:49 ` Juri Linkov
2024-12-25 9:11 ` Yuan Fu
2024-12-25 17:39 ` Juri Linkov
2024-12-19 7:34 ` bug#73404: 30.0.50; [forward/kill/etc]-sexp commands do not behave as expected in tree-sitter modes Juri Linkov
2024-12-24 19:05 ` Juri Linkov
2024-12-24 21:14 ` Yuan Fu
2024-12-25 7:44 ` Juri Linkov
2024-12-25 8:34 ` Yuan Fu
2024-12-25 17:36 ` Juri Linkov
2024-12-27 7:59 ` Juri Linkov
2024-12-25 17:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-25 18:01 ` Juri Linkov
2024-12-25 19:29 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-27 7:54 ` Juri Linkov
2024-12-29 17:58 ` Juri Linkov
2024-12-30 7:15 ` Juri Linkov
2024-12-30 8:00 ` Yuan Fu
2025-01-04 17:46 ` Juri Linkov
2025-01-04 19:05 ` Eli Zaretskii
2025-01-05 7:32 ` Juri Linkov
2025-01-05 11:46 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-05 12:18 ` Eli Zaretskii
2025-01-05 12:30 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-05 16:59 ` Eli Zaretskii
2025-01-05 18:20 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-05 21:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-05 17:59 ` Juri Linkov
2025-01-05 19:50 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-06 7:54 ` Juri Linkov
2025-01-06 14:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-06 17:40 ` Juri Linkov
2025-01-06 18:04 ` Yuan Fu
2025-01-06 20:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-07 18:05 ` Juri Linkov
2025-01-07 19:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-05 13:02 ` Eli Zaretskii
2025-01-05 18:05 ` Juri Linkov
2025-01-05 19:54 ` Eli Zaretskii
2025-01-06 18:02 ` Juri Linkov
2025-01-06 18:45 ` Eli Zaretskii
2025-01-06 20:19 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-05 7:37 ` Juri Linkov
2025-01-05 14:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-05 18:10 ` Juri Linkov
2025-01-06 8:56 ` Yuan Fu
2025-01-07 17:56 ` Juri Linkov
2025-01-07 19:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-08 2:27 ` Yuan Fu
2025-01-09 7:42 ` Juri Linkov
2025-01-09 18:39 ` Dmitry Gutov
2025-01-09 18:44 ` Juri Linkov
2025-01-10 3:14 ` Yuan Fu [this message]
2025-01-10 7:34 ` Juri Linkov
2024-12-30 13:40 ` Eli Zaretskii
2024-12-30 18:54 ` Juri Linkov
2024-12-30 19:36 ` Eli Zaretskii
2024-12-30 16:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-30 18:59 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E45EFF06-5F2D-4636-A9E3-69F5EB166711@gmail.com \
--to=casouri@gmail.com \
--cc=73404@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
--cc=mickey@masteringemacs.org \
--cc=monnier@iro.umontreal.ca \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).