From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#62029: 29.0.60; Allow users to customize eldoc buffer separator Date: Fri, 24 Mar 2023 20:04:59 -0700 Message-ID: References: <0C40D168-54D5-47E9-8BD8-77CFCD70B895@gmail.com> <87355vdufe.fsf@gmail.com> <87h6uacadx.fsf@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37814"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62029@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 25 04:40:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pfulI-0009ct-9E for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Mar 2023 04:40:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfuky-0000lK-8e; Fri, 24 Mar 2023 23:39:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfukw-0000l2-Nx for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 23:39:50 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pfukw-0002L0-Ej for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 23:39:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pfuEE-0005al-12 for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 23:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 03:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62029 X-GNU-PR-Package: emacs Original-Received: via spool by 62029-submit@debbugs.gnu.org id=B62029.167971353421453 (code B ref 62029); Sat, 25 Mar 2023 03:06:01 +0000 Original-Received: (at 62029) by debbugs.gnu.org; 25 Mar 2023 03:05:34 +0000 Original-Received: from localhost ([127.0.0.1]:41812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfuDl-0005Zw-Lq for submit@debbugs.gnu.org; Fri, 24 Mar 2023 23:05:33 -0400 Original-Received: from mail-pf1-f172.google.com ([209.85.210.172]:33365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfuDj-0005Zf-Oe for 62029@debbugs.gnu.org; Fri, 24 Mar 2023 23:05:32 -0400 Original-Received: by mail-pf1-f172.google.com with SMTP id c4so2464209pfl.0 for <62029@debbugs.gnu.org>; Fri, 24 Mar 2023 20:05:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679713519; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=l1Kr6FC00l98qo3JngIcY5GStut1oot12+dVieeXGyc=; b=AYu56B27BlmywSrQmwR2E4f0Yn+PStjdoU7Qj8NR9mrh97N/7I54Jc3zUYk7NkS68P KXO2q8FqbnzqwgmZUlhcxG9wPlDWwQWw3Lf8LxYA/uaHDyNeqaKsC2YLfeGxm4/v5N0f 43azsvaQI2HUwcUb8jaqzDH/y041yrzlrRusk3uTQC9pN5RvuVf+LBcsFGLBooexe1Ci DhSV3giTouevQWx+ruF+qvscHKjBFInQ3EEMUyUvQxgNcl9He6JJcMDzVqckEuxzWCxp QEnARm8wiiUN80lOtGz3m7JW/b7c1podZUiLz7ikKpWwbzxhdEErvfdxKjdKfTCmUmUQ UZzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679713519; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l1Kr6FC00l98qo3JngIcY5GStut1oot12+dVieeXGyc=; b=AGz86L0VdjLuLZ5d3dmH5FehznJFJjhILXFBktZxo2kK+ap4f7atlZLKeFUe7flOoR jc2PHZC+WbShTD64Wzan10XI+i2vk0gs4FD+QOoUYjaljAqZNOldUJvEteJxWWFwgSnd vn9hjn6Oh4JrXozniuQ1zmWBq0CUi6wpWRChLu7QEcMZOR1qA5ypYFW3KXFkXL5GQokl FCwDMKC3vb2urfn/dV93osonQihtYtC4CbrTl7SwKh0VWPrPlnrQUu8FdaRsnaITXQ/W eXHiqkZ4kvd33sp7iviQ4wLD6qI+PM7Qw0MpxtW18maiSQxLyWPQD0xrlerdC+SahdAD NwfA== X-Gm-Message-State: AAQBX9c+Fr1/cecjbJsXNyEA3TunKRSXnMZODz06NSVfXEd9LesieWEG 2U1uKtHSmFtGqWvITKLdeYA= X-Google-Smtp-Source: AKy350bwgv6ffB6l7UR3ps4vY3HVKsh7iBWI3JDMTReNUHwA9A8TiD+DSOXsZlJKhxWJ8dQq/nwbMw== X-Received: by 2002:a62:648d:0:b0:624:fb23:c4df with SMTP id y135-20020a62648d000000b00624fb23c4dfmr5003853pfb.16.1679713513938; Fri, 24 Mar 2023 20:05:13 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id o4-20020a655204000000b005133f658f1asm6430pgp.94.2023.03.24.20.05.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Mar 2023 20:05:13 -0700 (PDT) In-Reply-To: <87h6uacadx.fsf@gmail.com> X-Mailer: Apple Mail (2.3731.400.51.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258538 Archived-At: > On Mar 24, 2023, at 10:44 AM, Jo=C3=A3o T=C3=A1vora = wrote: >=20 > Yuan Fu writes: >=20 >> For separator, maybe something like >>=20 >> (insert =E2=80=9CTitle" (propertize "-" 'display >> '(space :align-to right) >> 'font-lock-face '(:strike-through t) >> 'face '(:strike-through t))) >>=20 >> for GUI, and use underline for terminal. >=20 > I've now pushed a commit to master introducing the user variable > eldoc-doc-buffer-separator. It's not a defcustom yet, as I'm not too > familiar with those, but feel free to change it. >=20 > (defvar eldoc-doc-buffer-separator > "String used to separate items in Eldoc documentation buffer." > (concat "\n" (propertize "\n" 'face '(:inherit separator-line = :extend t)) "\n")) >=20 > There is a difference between a separator and a title. I've stopped > short of adding titles, as I fear it would be confusing unless the > content allows it. To be investigated later for > eldoc-display-in-echo-area or maybe you can try it in eldoc-box. >=20 > Also, I've been testing with these unpushed changes to elisp-mode.el, > which render more of the docstring in emacs-lisp-mode. >=20 > The use case here is navigating around in an .el file while having a > window open with the *eldoc* buffer. >=20 > Jo=C3=A3o Looks good to me (except for the =E2=80=9Cdocumentatiok=E2=80=9D ;-) = eldoc-box can also benefit from this (right now if you use it in = emacs-lisp-mode, it just shows a thin strip of text, not very exciting). I=E2=80=99ll experiment with the title thing in eldoc-box. Does eglot = and flymake already pass a :source cookie? Those two displaying stuff = together is the most possible case I can think of. Yuan=