From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andrii Kolomoiets Newsgroups: gmane.emacs.bugs Subject: bug#38156: 27.0.50; [PATCH] VC: ability to skip update buffers prompt Date: Sat, 9 Nov 2019 22:29:28 +0200 Message-ID: Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_FFA8B34B-BDFE-4793-A4BA-47735D4FA1F3" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="123774"; mail-complaints-to="usenet@blaine.gmane.org" To: 38156@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 09 21:30:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iTXN7-000W1v-11 for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Nov 2019 21:30:13 +0100 Original-Received: from localhost ([::1]:39690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTXN5-0001Yb-Jx for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Nov 2019 15:30:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49106) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTXMy-0001YQ-Lx for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 15:30:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iTXMx-0004Hz-QF for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 15:30:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41511) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iTXMx-0004Hj-Mb for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 15:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iTXMx-0005B4-GP for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 15:30:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrii Kolomoiets Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Nov 2019 20:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 38156 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.157333137819846 (code B ref -1); Sat, 09 Nov 2019 20:30:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 Nov 2019 20:29:38 +0000 Original-Received: from localhost ([127.0.0.1]:50332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTXMX-0005A2-VO for submit@debbugs.gnu.org; Sat, 09 Nov 2019 15:29:38 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:41809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTXMV-00059s-Ty for submit@debbugs.gnu.org; Sat, 09 Nov 2019 15:29:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49065) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTXMU-0001Uk-WD for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 15:29:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iTXMU-0003b9-3O for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 15:29:34 -0500 Original-Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]:33165) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iTXMT-0003YI-Qa for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 15:29:34 -0500 Original-Received: by mail-lf1-x144.google.com with SMTP id d6so6606505lfc.0 for ; Sat, 09 Nov 2019 12:29:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:subject:message-id:date:to; bh=RxGRsERZgGCojQr6g7+y5vaGN9aTQSNbKS2YuW41YsI=; b=iJzT0mdo2AR0+K8sZWnGTsj6UjEnzXZrYpM2juYxfvsHBm0B8PS/npLMDVrQtGuiYu wL+noKXPd/mWV30WqQ2tK9RySOSKASpqCPnuVF9utC6o6CLUjqfMQJ0UR3Ac8Zj0ZOkN +hcza7njluaRZ37M3H5z2SmCFy0SNsaON5qt1e6vQg8x4yqkCBfzONKkMLRU9Kybixv6 MdlrtJP3E7IXUx70zEgpw8ornG3kFmWJuL5kFoh6R5UuFPnAbnhst7aoGjkuKt0vT8LQ chsLdMMqHhCoQ0X9f/UBZl56bG2fy8FE+AZLJ3f+QY41J3VmWOIbHRUXBMmhNL2mJEL5 CbRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:message-id:date:to; bh=RxGRsERZgGCojQr6g7+y5vaGN9aTQSNbKS2YuW41YsI=; b=iGYg9oU97QUop1HZx3yNPKsbN4sGhI8iUTWGmIK8xyQMHPWHWX0y+YEj+++e3t1MXo lkK7j+YkUGCAemdzsKsFtBNRgLbo5D+I5CCK3jw2gNJyCVIINpWZmZaZGCJ+XQgFCHOl J4tZS6xW7G4j9kx+dwu1/tejpwscH0QhWMca4kVoYuqChHH9eYG3Aot1c+leoYnG56UH aJwJS5CfCNC8bFXFWLJLGEpdSQWMKRIdj1uqGOPgtvUbeiruPPjCyv8P9ZoXrLPD0VMF IbsFNDXVkNq179wzmO39URyYbq9wObTw3Ov2k2594lvGRu062sQ+9+/7WDtzSvHtqwYg Pk2w== X-Gm-Message-State: APjAAAXM1wc9slX/TkicO1SyCNZCsrvnr9QtVQYh5dhhNqTGVanMhi0b yPAhW6nv+nQaC3QT5KxGnBe47d4DW2Q= X-Google-Smtp-Source: APXvYqwSppJQSSqVBGmhtgIRhS+zWj34FZmvK+50Vj+SzZfrCHKVaYPmghSX8mkoAfcZCRh+VxMX6g== X-Received: by 2002:a19:7617:: with SMTP id c23mr215643lff.175.1573331370944; Sat, 09 Nov 2019 12:29:30 -0800 (PST) Original-Received: from [192.168.0.104] ([91.206.110.132]) by smtp.gmail.com with ESMTPSA id e10sm4403615ljp.23.2019.11.09.12.29.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Nov 2019 12:29:30 -0800 (PST) X-Mailer: Apple Mail (2.3601.0.10) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171355 Archived-At: --Apple-Mail=_FFA8B34B-BDFE-4793-A4BA-47735D4FA1F3 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Hi, The `update' argument of `vc-retrieve-tag' is ignored by git, hg and svn vc backends so the answer for "Update any affected buffers?" prompt doesn't matter. This prompt can be omitted. --Apple-Mail=_FFA8B34B-BDFE-4793-A4BA-47735D4FA1F3 Content-Disposition: attachment; filename=0001-VC-ability-to-skip-update-buffers-prompt.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-VC-ability-to-skip-update-buffers-prompt.patch" Content-Transfer-Encoding: quoted-printable =46rom=2021d63d3a4c8e3348f590f4189da36798bc6e1bfd=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Andrii=20Kolomoiets=20=0A= Date:=20Sat,=209=20Nov=202019=2022:23:13=20+0200=0ASubject:=20[PATCH]=20= VC:=20ability=20to=20skip=20update=20buffers=20prompt=0A=0AThe=20= `update'=20argument=20of=20`vc-retrieve-tag'=20is=20ignored=20by=20git,=20= hg=20and=20svn=20vc=0Abackends=20so=20the=20answer=20for=20"Update=20any=20= affected=20buffers?"=20prompt=20doesn't=0Amatter.=20=20This=20prompt=20= can=20be=20omitted.=0A=0A*=20lisp/vc/vc.el=20= (vc-default-update-on-retrieve-tag):=20New=20function.=0A= (vc-retrieve-tag):=20Call=20`update-on-retrieve-tag'=20backend=20= function=20to=20determine=0Aif=20prompt=20for=20update=20buffers=20is=20= needed;=20Include=20tag=20name=20into=20the=20"Retrieving=0Atag"=20= message.=0A*=20lisp/vc/vc-git.el=20(vc-git-update-on-retrieve-tag):=0A*=20= lisp/vc/vc-hg.el=20(vc-hg-update-on-retrieve-tag):=0A*=20= lisp/vc/vc-svn.el=20(vc-svn-udate-on-retrieve-tag):=20New=20functions.=20= =20Buffers=0Aupdate=20prompt=20on=20`vc-retrieve-tag'=20is=20omitted.=0A=0A= diff=20--git=20a/lisp/vc/vc-git.el=20b/lisp/vc/vc-git.el=0Aindex=20= 3960f725cf..587a37455e=20100644=0A---=20a/lisp/vc/vc-git.el=0A+++=20= b/lisp/vc/vc-git.el=0A@@=20-47,6=20+47,7=20@@=0A=20;;=20FUNCTION=20NAME=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20STATUS=0A=20;;=20BACKEND=20PROPERTIES=0A=20;;=20= *=20revision-granularity=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20OK=0A+;;=20-=20update-on-retrieve-tag=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20OK=0A=20= ;;=20STATE-QUERYING=20FUNCTIONS=0A=20;;=20*=20registered=20(file)=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20OK=0A=20;;=20*=20state=20(file)=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20OK=0A@@=20= -218,6=20+219,7=20@@=20vc-git-history=0A=20=0A=20(defun=20= vc-git-revision-granularity=20()=20'repository)=0A=20(defun=20= vc-git-checkout-model=20(_files)=20'implicit)=0A+(defun=20= vc-git-update-on-retrieve-tag=20()=20nil)=0A=20=0A=20;;;=20= STATE-QUERYING=20FUNCTIONS=0A=20=0Adiff=20--git=20a/lisp/vc/vc-hg.el=20= b/lisp/vc/vc-hg.el=0Aindex=20cc737b30b1..16e5dd6db0=20100644=0A---=20= a/lisp/vc/vc-hg.el=0A+++=20b/lisp/vc/vc-hg.el=0A@@=20-40,6=20+40,7=20@@=0A= =20;;=20FUNCTION=20NAME=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20STATUS=0A=20;;=20BACKEND=20= PROPERTIES=0A=20;;=20*=20revision-granularity=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20OK=0A+;;=20-=20= update-on-retrieve-tag=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20OK=0A=20;;=20STATE-QUERYING=20FUNCTIONS=0A=20;;=20*=20= registered=20(file)=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20OK=0A=20;;=20*=20state=20(file)=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20OK=0A= @@=20-194,6=20+195,7=20@@=20vc-hg-history=0A=20=0A=20(defun=20= vc-hg-revision-granularity=20()=20'repository)=0A=20(defun=20= vc-hg-checkout-model=20(_files)=20'implicit)=0A+(defun=20= vc-hg-update-on-retrieve-tag=20()=20nil)=0A=20=0A=20;;;=20State=20= querying=20functions=0A=20=0Adiff=20--git=20a/lisp/vc/vc-svn.el=20= b/lisp/vc/vc-svn.el=0Aindex=20942dbd5fa5..ed34b357f9=20100644=0A---=20= a/lisp/vc/vc-svn.el=0A+++=20b/lisp/vc/vc-svn.el=0A@@=20-127,6=20+127,7=20= @@=20vc-svn-admin-directory=0A=20=0A=20(defun=20= vc-svn-revision-granularity=20()=20'repository)=0A=20(defun=20= vc-svn-checkout-model=20(_files)=20'implicit)=0A+(defun=20= vc-svn-update-on-retrieve-tag=20()=20nil)=0A=20=0A=20;;;=0A=20;;;=20= State-querying=20functions=0Adiff=20--git=20a/lisp/vc/vc.el=20= b/lisp/vc/vc.el=0Aindex=2020056dec7f..401b39145c=20100644=0A---=20= a/lisp/vc/vc.el=0A+++=20b/lisp/vc/vc.el=0A@@=20-110,6=20+110,12=20@@=0A=20= ;;=20=20=20that=20return=20'file=20have=20per-file=20revision=20= numbering;=20backends=0A=20;;=20=20=20that=20return=20'repository=20have=20= per-repository=20revision=20numbering,=0A=20;;=20=20=20so=20a=20revision=20= level=20implicitly=20identifies=20a=20changeset=0A+;;=0A+;;=20-=20= update-on-retrieve-tag=0A+;;=0A+;;=20=20=20Takes=20no=20arguments.=20=20= Backends=20that=20return=20non-nil=20can=20update=0A+;;=20=20=20buffers=20= on=20`vc-retrieve-tag'=20based=20on=20user=20input.=20=20In=20this=20= case=0A+;;=20=20=20user=20will=20be=20prompted=20to=20update=20buffers=20= on=20`vc-retrieve-tag'.=0A=20=0A=20;;=20STATE-QUERYING=20FUNCTIONS=0A=20= ;;=0A@@=20-2302,14=20+2308,15=20@@=20vc-retrieve-tag=0A=20=20=20=20=20=20= =20(vc-read-revision=20"Tag=20name=20to=20retrieve=20(default=20latest=20= revisions):=20"=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(list=20dir)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(vc-responsible-backend=20dir)))))=0A-=20= =20(let=20((update=20(yes-or-no-p=20"Update=20any=20affected=20buffers?=20= "))=0A-=09(msg=20(if=20(or=20(not=20name)=20(string=3D=20name=20""))=0A-=09= =09=20(format=20"Updating=20%s...=20"=20(abbreviate-file-name=20dir))=0A= -=09=20=20=20=20=20=20=20(format=20"Retrieving=20tag=20into=20%s...=20"=0A= -=09=09=20=20=20=20=20=20=20(abbreviate-file-name=20dir)))))=0A+=20=20= (let*=20((backend=20(vc-responsible-backend=20dir))=0A+=20=20=20=20=20=20= =20=20=20(update=20(when=20(vc-call-backend=20backend=20= 'update-on-retrieve-tag)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(yes-or-no-p=20"Update=20any=20affected=20buffers?=20")))=0A= +=09=20(msg=20(if=20(or=20(not=20name)=20(string=3D=20name=20""))=0A+=09=09= =20=20(format=20"Updating=20%s...=20"=20(abbreviate-file-name=20dir))=0A= +=09=20=20=20=20=20=20=20=20(format=20"Retrieving=20tag=20%s=20into=20= %s...=20"=0A+=09=09=20=20=20=20=20=20=20=20name=20(abbreviate-file-name=20= dir)))))=0A=20=20=20=20=20(message=20"%s"=20msg)=0A-=20=20=20=20= (vc-call-backend=20(vc-responsible-backend=20dir)=0A-=09=09=20=20=20=20=20= 'retrieve-tag=20dir=20name=20update)=0A+=20=20=20=20(vc-call-backend=20= backend=20'retrieve-tag=20dir=20name=20update)=0A=20=20=20=20=20= (vc-resynch-buffer=20dir=20t=20t=20t)=0A=20=20=20=20=20(run-hooks=20= 'vc-retrieve-tag-hook)=0A=20=20=20=20=20(message=20"%s"=20(concat=20msg=20= "done"))))=0A@@=20-3025,6=20+3032,10=20@@=20vc-default-receive-file=0A=20= =20=20"Let=20BACKEND=20receive=20FILE=20from=20another=20version=20= control=20system."=0A=20=20=20(vc-call-backend=20backend=20'register=20= (list=20file)=20rev=20""))=0A=20=0A+(defun=20= vc-default-update-on-retrieve-tag=20()=0A+=20=20"Prompt=20for=20update=20= buffers=20on=20`vc-retrieve-tag'."=0A+=20=20t)=0A+=0A=20(defun=20= vc-default-retrieve-tag=20(backend=20dir=20name=20update)=0A=20=20=20(if=20= (string=3D=20name=20"")=0A=20=20=20=20=20=20=20(progn=0A--=20=0A2.15.1=0A= =0A= --Apple-Mail=_FFA8B34B-BDFE-4793-A4BA-47735D4FA1F3--