bug#44834: 27.1; Tcl mode enforces bad indentation following proc within a namespace

bug#44834: 27.1; Tcl mode enforces bad indentation following proc within a namespace

[Morgan Willcock]

It seems as though an incorrect indentation level is sometimes detected
by Tcl mode. An easy (and commonly used) example is a proc defined in a
namespace: the third line which defines p2 incorrectly wants to indent
into the wrong position:

namespace eval ns {
    proc p1 {} {}
proc p2 {} {}
}

Spreading braces over more lines has the same issue:

namespace eval ns {
    proc p1 {} {
        # ...
    }
proc p2 {} {
    # ...
}
}

The issues seems very specific to detection of the proc, commenting the
first proc delays the problem:

namespace eval ns {
    # proc p1 {} {}
    proc p2 {} {}
proc p3 {} {}
}

...as does using something other than a proc at the start of the
namespace:

namespace eval ns {
    variable x {}
    proc p1 {} {}
proc p2 {} {}
}

I believe the problem originates from this commit:
http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/progmodes/tcl.el?id=cd5bb4bf3dbad8941d25823f398b595b8f0edbb9

To re-create the problem in a new buffer:

1. enter Tcl mode:

M-x tcl-mode

2. paste this text:

namespace eval ns {
    proc p1 {} {}
    proc p2 {} {}
}

3. move point to anywhere on line 3 and press tab



In GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11, cairo version 1.14.8)
 of 2020-08-12 built on inspiron
Windowing system distributor 'The X.Org Foundation', version 11.0.11902000
System Description: Debian GNU/Linux 9 (stretch)

Recent messages:
previous-line: Beginning of buffer
Mark set
Saved text from "It seems as though an incorrect indentat"
Mark set [3 times]
Beginning of buffer [8 times]
Auto-saving...done
Mark set [3 times]
Beginning of buffer [5 times]
Mark set
Buffer *unsent mail to bug-gnu-emacs@gnu.org* modified; kill anyway? (y or n) y

Configured using:
 'configure --with-cairo --with-json --with-xml2'

Configured features:
XPM JPEG TIFF GIF PNG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY
GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE
XIM MODULES THREADS JSON PDUMPER GMP

Important settings:
  value of $LANG: en_GB.utf8
  locale-coding-system: utf-8-unix

Major mode: Tcl

Minor modes in effect:
  erc-list-mode: t
  erc-menu-mode: t
  erc-autojoin-mode: t
  erc-ring-mode: t
  erc-networks-mode: t
  erc-pcomplete-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-netsplit-mode: t
  erc-notifications-mode: t
  erc-match-mode: t
  erc-spelling-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  savehist-mode: t
  icomplete-mode: t
  shell-dirtrack-mode: t
  recentf-mode: t
  global-hl-line-mode: t
  display-time-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
/home/mwillcock/.emacs.d/elpa/org-9.4/ol hides /usr/local/share/emacs/27.1/lisp/org/ol
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-sqlite hides /usr/local/share/emacs/27.1/lisp/org/ob-sqlite
/home/mwillcock/.emacs.d/elpa/org-9.4/org-feed hides /usr/local/share/emacs/27.1/lisp/org/org-feed
/home/mwillcock/.emacs.d/elpa/org-9.4/org-src hides /usr/local/share/emacs/27.1/lisp/org/org-src
/home/mwillcock/.emacs.d/elpa/org-9.4/ox-html hides /usr/local/share/emacs/27.1/lisp/org/ox-html
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-eshell hides /usr/local/share/emacs/27.1/lisp/org/ob-eshell
/home/mwillcock/.emacs.d/elpa/org-9.4/ol-bbdb hides /usr/local/share/emacs/27.1/lisp/org/ol-bbdb
/home/mwillcock/.emacs.d/elpa/org-9.4/org-faces hides /usr/local/share/emacs/27.1/lisp/org/org-faces
/home/mwillcock/.emacs.d/elpa/org-9.4/ox hides /usr/local/share/emacs/27.1/lisp/org/ox
/home/mwillcock/.emacs.d/elpa/org-9.4/ol-docview hides /usr/local/share/emacs/27.1/lisp/org/ol-docview
/home/mwillcock/.emacs.d/elpa/org-9.4/ol-gnus hides /usr/local/share/emacs/27.1/lisp/org/ol-gnus
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-scheme hides /usr/local/share/emacs/27.1/lisp/org/ob-scheme
/home/mwillcock/.emacs.d/elpa/org-9.4/org-footnote hides /usr/local/share/emacs/27.1/lisp/org/org-footnote
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-groovy hides /usr/local/share/emacs/27.1/lisp/org/ob-groovy
/home/mwillcock/.emacs.d/elpa/org-9.4/org hides /usr/local/share/emacs/27.1/lisp/org/org
/home/mwillcock/.emacs.d/elpa/org-9.4/ol-eshell hides /usr/local/share/emacs/27.1/lisp/org/ol-eshell
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-coq hides /usr/local/share/emacs/27.1/lisp/org/ob-coq
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-lilypond hides /usr/local/share/emacs/27.1/lisp/org/ob-lilypond
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-tangle hides /usr/local/share/emacs/27.1/lisp/org/ob-tangle
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-hledger hides /usr/local/share/emacs/27.1/lisp/org/ob-hledger
/home/mwillcock/.emacs.d/elpa/org-9.4/org-keys hides /usr/local/share/emacs/27.1/lisp/org/org-keys
/home/mwillcock/.emacs.d/elpa/org-9.4/org-inlinetask hides /usr/local/share/emacs/27.1/lisp/org/org-inlinetask
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-screen hides /usr/local/share/emacs/27.1/lisp/org/ob-screen
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-exp hides /usr/local/share/emacs/27.1/lisp/org/ob-exp
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-lua hides /usr/local/share/emacs/27.1/lisp/org/ob-lua
/home/mwillcock/.emacs.d/elpa/org-9.4/org-tempo hides /usr/local/share/emacs/27.1/lisp/org/org-tempo
/home/mwillcock/.emacs.d/elpa/org-9.4/org-entities hides /usr/local/share/emacs/27.1/lisp/org/org-entities
/home/mwillcock/.emacs.d/elpa/org-9.4/org-lint hides /usr/local/share/emacs/27.1/lisp/org/org-lint
/home/mwillcock/.emacs.d/elpa/org-9.4/org-num hides /usr/local/share/emacs/27.1/lisp/org/org-num
/home/mwillcock/.emacs.d/elpa/org-9.4/org-capture hides /usr/local/share/emacs/27.1/lisp/org/org-capture
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-dot hides /usr/local/share/emacs/27.1/lisp/org/ob-dot
/home/mwillcock/.emacs.d/elpa/org-9.4/ox-beamer hides /usr/local/share/emacs/27.1/lisp/org/ox-beamer
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-octave hides /usr/local/share/emacs/27.1/lisp/org/ob-octave
/home/mwillcock/.emacs.d/elpa/org-9.4/ox-texinfo hides /usr/local/share/emacs/27.1/lisp/org/ox-texinfo
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-ebnf hides /usr/local/share/emacs/27.1/lisp/org/ob-ebnf
/home/mwillcock/.emacs.d/elpa/org-9.4/ol-bibtex hides /usr/local/share/emacs/27.1/lisp/org/ol-bibtex
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-emacs-lisp hides /usr/local/share/emacs/27.1/lisp/org/ob-emacs-lisp
/home/mwillcock/.emacs.d/elpa/org-9.4/ox-latex hides /usr/local/share/emacs/27.1/lisp/org/ox-latex
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-stan hides /usr/local/share/emacs/27.1/lisp/org/ob-stan
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-abc hides /usr/local/share/emacs/27.1/lisp/org/ob-abc
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-css hides /usr/local/share/emacs/27.1/lisp/org/ob-css
/home/mwillcock/.emacs.d/elpa/org-9.4/ox-md hides /usr/local/share/emacs/27.1/lisp/org/ox-md
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-plantuml hides /usr/local/share/emacs/27.1/lisp/org/ob-plantuml
/home/mwillcock/.emacs.d/elpa/org-9.4/org-crypt hides /usr/local/share/emacs/27.1/lisp/org/org-crypt
/home/mwillcock/.emacs.d/elpa/org-9.4/org-attach hides /usr/local/share/emacs/27.1/lisp/org/org-attach
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-perl hides /usr/local/share/emacs/27.1/lisp/org/ob-perl
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-latex hides /usr/local/share/emacs/27.1/lisp/org/ob-latex
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-core hides /usr/local/share/emacs/27.1/lisp/org/ob-core
/home/mwillcock/.emacs.d/elpa/org-9.4/ol-eww hides /usr/local/share/emacs/27.1/lisp/org/ol-eww
/home/mwillcock/.emacs.d/elpa/org-9.4/ox-odt hides /usr/local/share/emacs/27.1/lisp/org/ox-odt
/home/mwillcock/.emacs.d/elpa/org-9.4/ox-org hides /usr/local/share/emacs/27.1/lisp/org/ox-org
/home/mwillcock/.emacs.d/elpa/org-9.4/org-plot hides /usr/local/share/emacs/27.1/lisp/org/org-plot
/home/mwillcock/.emacs.d/elpa/org-9.4/ol-irc hides /usr/local/share/emacs/27.1/lisp/org/ol-irc
/home/mwillcock/.emacs.d/elpa/org-9.4/ol-mhe hides /usr/local/share/emacs/27.1/lisp/org/ol-mhe
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-shell hides /usr/local/share/emacs/27.1/lisp/org/ob-shell
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-J hides /usr/local/share/emacs/27.1/lisp/org/ob-J
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-R hides /usr/local/share/emacs/27.1/lisp/org/ob-R
/home/mwillcock/.emacs.d/elpa/org-9.4/org-protocol hides /usr/local/share/emacs/27.1/lisp/org/org-protocol
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-haskell hides /usr/local/share/emacs/27.1/lisp/org/ob-haskell
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-io hides /usr/local/share/emacs/27.1/lisp/org/ob-io
/home/mwillcock/.emacs.d/elpa/org-9.4/org-compat hides /usr/local/share/emacs/27.1/lisp/org/org-compat
/home/mwillcock/.emacs.d/elpa/org-9.4/org-element hides /usr/local/share/emacs/27.1/lisp/org/org-element
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-ocaml hides /usr/local/share/emacs/27.1/lisp/org/ob-ocaml
/home/mwillcock/.emacs.d/elpa/org-9.4/org-attach-git hides /usr/local/share/emacs/27.1/lisp/org/org-attach-git
/home/mwillcock/.emacs.d/elpa/org-9.4/org-agenda hides /usr/local/share/emacs/27.1/lisp/org/org-agenda
/home/mwillcock/.emacs.d/elpa/org-9.4/org-list hides /usr/local/share/emacs/27.1/lisp/org/org-list
/home/mwillcock/.emacs.d/elpa/org-9.4/org-pcomplete hides /usr/local/share/emacs/27.1/lisp/org/org-pcomplete
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-mscgen hides /usr/local/share/emacs/27.1/lisp/org/ob-mscgen
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-shen hides /usr/local/share/emacs/27.1/lisp/org/ob-shen
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-fortran hides /usr/local/share/emacs/27.1/lisp/org/ob-fortran
/home/mwillcock/.emacs.d/elpa/org-9.4/org-table hides /usr/local/share/emacs/27.1/lisp/org/org-table
/home/mwillcock/.emacs.d/elpa/org-9.4/ol-info hides /usr/local/share/emacs/27.1/lisp/org/ol-info
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-processing hides /usr/local/share/emacs/27.1/lisp/org/ob-processing
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-sql hides /usr/local/share/emacs/27.1/lisp/org/ob-sql
/home/mwillcock/.emacs.d/elpa/org-9.4/org-mouse hides /usr/local/share/emacs/27.1/lisp/org/org-mouse
/home/mwillcock/.emacs.d/elpa/org-9.4/ox-man hides /usr/local/share/emacs/27.1/lisp/org/ox-man
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-vala hides /usr/local/share/emacs/27.1/lisp/org/ob-vala
/home/mwillcock/.emacs.d/elpa/org-9.4/ob hides /usr/local/share/emacs/27.1/lisp/org/ob
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-asymptote hides /usr/local/share/emacs/27.1/lisp/org/ob-asymptote
/home/mwillcock/.emacs.d/elpa/org-9.4/org-mobile hides /usr/local/share/emacs/27.1/lisp/org/org-mobile
/home/mwillcock/.emacs.d/elpa/org-9.4/org-install hides /usr/local/share/emacs/27.1/lisp/org/org-install
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-lob hides /usr/local/share/emacs/27.1/lisp/org/ob-lob
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-C hides /usr/local/share/emacs/27.1/lisp/org/ob-C
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-ledger hides /usr/local/share/emacs/27.1/lisp/org/ob-ledger
/home/mwillcock/.emacs.d/elpa/org-9.4/ox-publish hides /usr/local/share/emacs/27.1/lisp/org/ox-publish
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-calc hides /usr/local/share/emacs/27.1/lisp/org/ob-calc
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-matlab hides /usr/local/share/emacs/27.1/lisp/org/ob-matlab
/home/mwillcock/.emacs.d/elpa/org-9.4/ox-ascii hides /usr/local/share/emacs/27.1/lisp/org/ox-ascii
/home/mwillcock/.emacs.d/elpa/org-9.4/org-archive hides /usr/local/share/emacs/27.1/lisp/org/org-archive
/home/mwillcock/.emacs.d/elpa/org-9.4/ox-icalendar hides /usr/local/share/emacs/27.1/lisp/org/ox-icalendar
/home/mwillcock/.emacs.d/elpa/org-9.4/org-macs hides /usr/local/share/emacs/27.1/lisp/org/org-macs
/home/mwillcock/.emacs.d/elpa/org-9.4/ol-w3m hides /usr/local/share/emacs/27.1/lisp/org/ol-w3m
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-makefile hides /usr/local/share/emacs/27.1/lisp/org/ob-makefile
/home/mwillcock/.emacs.d/elpa/org-9.4/org-goto hides /usr/local/share/emacs/27.1/lisp/org/org-goto
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-lisp hides /usr/local/share/emacs/27.1/lisp/org/ob-lisp
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-table hides /usr/local/share/emacs/27.1/lisp/org/ob-table
/home/mwillcock/.emacs.d/elpa/org-9.4/org-macro hides /usr/local/share/emacs/27.1/lisp/org/org-macro
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-js hides /usr/local/share/emacs/27.1/lisp/org/ob-js
/home/mwillcock/.emacs.d/elpa/org-9.4/org-colview hides /usr/local/share/emacs/27.1/lisp/org/org-colview
/home/mwillcock/.emacs.d/elpa/org-9.4/org-indent hides /usr/local/share/emacs/27.1/lisp/org/org-indent
/home/mwillcock/.emacs.d/elpa/org-9.4/org-loaddefs hides /usr/local/share/emacs/27.1/lisp/org/org-loaddefs
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-sass hides /usr/local/share/emacs/27.1/lisp/org/ob-sass
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-forth hides /usr/local/share/emacs/27.1/lisp/org/ob-forth
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-gnuplot hides /usr/local/share/emacs/27.1/lisp/org/ob-gnuplot
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-java hides /usr/local/share/emacs/27.1/lisp/org/ob-java
/home/mwillcock/.emacs.d/elpa/org-9.4/org-duration hides /usr/local/share/emacs/27.1/lisp/org/org-duration
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-ruby hides /usr/local/share/emacs/27.1/lisp/org/ob-ruby
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-sed hides /usr/local/share/emacs/27.1/lisp/org/ob-sed
/home/mwillcock/.emacs.d/elpa/org-9.4/org-datetree hides /usr/local/share/emacs/27.1/lisp/org/org-datetree
/home/mwillcock/.emacs.d/elpa/org-9.4/ol-rmail hides /usr/local/share/emacs/27.1/lisp/org/ol-rmail
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-eval hides /usr/local/share/emacs/27.1/lisp/org/ob-eval
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-python hides /usr/local/share/emacs/27.1/lisp/org/ob-python
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-picolisp hides /usr/local/share/emacs/27.1/lisp/org/ob-picolisp
/home/mwillcock/.emacs.d/elpa/org-9.4/org-habit hides /usr/local/share/emacs/27.1/lisp/org/org-habit
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-maxima hides /usr/local/share/emacs/27.1/lisp/org/ob-maxima
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-awk hides /usr/local/share/emacs/27.1/lisp/org/ob-awk
/home/mwillcock/.emacs.d/elpa/org-9.4/org-id hides /usr/local/share/emacs/27.1/lisp/org/org-id
/home/mwillcock/.emacs.d/elpa/org-9.4/org-timer hides /usr/local/share/emacs/27.1/lisp/org/org-timer
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-ditaa hides /usr/local/share/emacs/27.1/lisp/org/ob-ditaa
/home/mwillcock/.emacs.d/elpa/org-9.4/org-ctags hides /usr/local/share/emacs/27.1/lisp/org/org-ctags
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-ref hides /usr/local/share/emacs/27.1/lisp/org/ob-ref
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-comint hides /usr/local/share/emacs/27.1/lisp/org/ob-comint
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-org hides /usr/local/share/emacs/27.1/lisp/org/ob-org
/home/mwillcock/.emacs.d/elpa/org-9.4/org-version hides /usr/local/share/emacs/27.1/lisp/org/org-version
/home/mwillcock/.emacs.d/elpa/org-9.4/org-clock hides /usr/local/share/emacs/27.1/lisp/org/org-clock
/home/mwillcock/.emacs.d/elpa/org-9.4/ob-clojure hides /usr/local/share/emacs/27.1/lisp/org/ob-clojure

Features:
(shadow emacsbug ediff ediff-merg ediff-mult ediff-wind ediff-diff
ediff-help ediff-init ediff-util reveal view finder-inf cl-print
help-fns radix-tree tcl mule-util ibuf-ext mhtml-mode css-mode color js
cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine
cc-vars cc-defs sgml-mode ox-odt rng-loc rng-uri rng-parse rng-match
rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util
ox-latex ox-icalendar ox-html table ox-ascii ox-publish ox sh-script
smie executable org-clock org-duration cal-iso face-remap log-edit
pcvs-util add-log smerge-mode diff vc vc-dispatcher bookmark tabify
vc-git diff-mode erc-list erc-menu erc-join erc-ring erc-networks
erc-pcomplete erc-track erc-button erc-fill erc-stamp erc-netsplit
erc-desktop-notifications erc-match org-element avl-tree generator
ol-eww eww url-queue ol-rmail ol-mhe ol-irc ol-info ol-gnus ol-docview
doc-view jka-compr image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m
mailalias smtpmail sendmail misearch multi-isearch gnus-notifications
gnus-fun notifications dbus flow-fill mail-extr qp sort gnus-cite smiley
gnus-async gnus-bcklg cl-extra help-mode gnus-ml disp-table gnus-topic
mm-archive gnutls url-http url-gw url-cache url-auth nnrss mm-url
nndraft nnmh utf-7 epa-file network-stream nsm nnfolder nnnil gnus-agent
gnus-srvr gnus-score score-mode nnvirtual gnus-cache gnus-demon nntp
org-agenda gnus-icalendar org-capture org-refile icalendar diary-lib
diary-loaddefs nnir lua-mode compile rx renpy-mode imenu python org-msg
htmlize cl gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig
gnus-sum url url-proxy url-privacy url-expand url-methods url-history
mailcap gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail
mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range message rmc
dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader gnus-win erc-spelling flyspell ispell erc-goodies erc
erc-backend erc-compat thingatpt pp erc-loaddefs ob-dot org ob ob-tangle
ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint
org-pcomplete org-list org-faces org-entities noutline outline
easy-mmode org-version ob-emacs-lisp ob-core ob-eval org-table ol
org-keys org-compat advice org-macs org-loaddefs find-func cal-menu
calendar cal-loaddefs savehist icomplete tramp-cache tramp-sh tramp
tramp-loaddefs trampver tramp-integration files-x tramp-compat shell
pcomplete comint ansi-color ring parse-time iso8601 ls-lisp format-spec
recentf tree-widget ibuffer ibuffer-loaddefs hl-line time edmacro kmacro
gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums
time-date mail-utils mm-util mail-prsvr wid-edit shr
text-property-search url-cookie url-domsuf url-util puny svg xml dom
modus-vivendi-theme info package easymenu browse-url url-handlers
url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json subr-x map url-vars seq byte-opt gv bytecomp
byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify dynamic-setting system-font-setting
font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty
make-network-process emacs)

Memory information:
((conses 16 601379 93831)
 (symbols 48 41903 13)
 (strings 32 163981 18423)
 (string-bytes 1 5420629)
 (vectors 16 67450)
 (vector-slots 8 1236339 91558)
 (floats 8 647 1055)
 (intervals 56 5816 2611)
 (buffers 1000 157))

-- 
Morgan Willcock, Support and Development Engineer
Precedence Technologies Ltd              T: +44 (0) 845 6446 800
Technology House, 36a Union Lane         F: +44 (0) 845 6446 899
Cambridge, CB4 1QB, United Kingdom       W: http://www.precedence.co.uk/
Limited company registered in England and Wales. Company number 3725626

bug#44834: change severity

[Anticrisis]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

Just a note that this bug makes the current tcl-mode practically unusable
for anyone writing more than a basic single-file script. I'm not sure
'minor' is the correct severity. Can it be changed to 'normal' and would it
be possible to alert the maintainer, who I imagine must not be aware of the
impact of his commits last year?

[-- Attachment #2: Type: text/html, Size: 375 bytes --]

bug#44834: Patch to provide failing test for bug 44834

[Anticrisis]

--- emacs/test/lisp/progmodes/tcl-tests.el 2021-01-01 22:11:30.620000000 -1000
+++ emacs.patched/test/lisp/progmodes/tcl-tests.el 2021-01-08
12:51:27.420000000 -1000
@@ -50,14 +50,14 @@
(insert "proc notinthis {} {\n # nothing\n}\n\n")
(should-not (add-log-current-defun))))

-(ert-deftest tcl-mode-function-name ()
+(ert-deftest tcl-mode-function-name-2 ()
(with-temp-buffer
(tcl-mode)
(insert "proc simple {} {\n # nothing\n}")
(backward-char 3)
(should (equal "simple" (add-log-current-defun)))))

-(ert-deftest tcl-mode-function-name ()
+(ert-deftest tcl-mode-function-name-3 ()
(with-temp-buffer
(tcl-mode)
(insert "proc inthis {} {\n # nothing\n")
@@ -71,6 +71,15 @@
(insert text)
(indent-region (point-min) (point-max))
(should (equal (buffer-string) text)))))
+
+;; From bug#44834
+(ert-deftest tcl-mode-namespace-indent-2 ()
+ (with-temp-buffer
+ (tcl-mode)
+ (let ((text "namespace eval Foo {\n proc foo {} {}\n\n proc bar {}{}}\n"))
+ (insert text)
+ (indent-region (point-min) (point-max))
+ (should (equal (buffer-string) text)))))

(provide 'tcl-tests)

bug#44834: Patch to provide failing test for bug 44834

[Anticrisis]

Apologies, the patch was munged by gmail even in plain text mode. It
should not be applied.

bug#44834: Patch to provide failing test for bug 44834

[Lars Ingebrigtsen]

Anticrisis <anticrisisg@gmail.com> writes:

> Apologies, the patch was munged by gmail even in plain text mode. It
> should not be applied.

Try resending it as an attachment.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44834: Patch to provide failing test for bug 44834

[Anticrisis]

[-- Attachment #1: Type: text/plain, Size: 63 bytes --]

Trying again with an attachment, thank you for the suggestion.

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 1171 bytes --]

--- emacs/test/lisp/progmodes/tcl-tests.el	2021-01-01 22:11:30.620000000 -1000
+++ emacs.patched/test/lisp/progmodes/tcl-tests.el	2021-01-08 12:51:27.420000000 -1000
@@ -50,14 +50,14 @@
     (insert "proc notinthis {} {\n  # nothing\n}\n\n")
     (should-not (add-log-current-defun))))
 
-(ert-deftest tcl-mode-function-name ()
+(ert-deftest tcl-mode-function-name-2 ()
   (with-temp-buffer
     (tcl-mode)
     (insert "proc simple {} {\n  # nothing\n}")
     (backward-char 3)
     (should (equal "simple" (add-log-current-defun)))))
 
-(ert-deftest tcl-mode-function-name ()
+(ert-deftest tcl-mode-function-name-3 ()
   (with-temp-buffer
     (tcl-mode)
     (insert "proc inthis {} {\n  # nothing\n")
@@ -71,6 +71,15 @@
       (insert text)
       (indent-region (point-min) (point-max))
       (should (equal (buffer-string) text)))))
+
+;; From bug#44834
+(ert-deftest tcl-mode-namespace-indent-2 ()
+  (with-temp-buffer
+    (tcl-mode)
+    (let ((text "namespace eval Foo {\n    proc foo {} {}\n\n    proc bar {}{}}\n"))
+      (insert text)
+      (indent-region (point-min) (point-max))
+      (should (equal (buffer-string) text)))))
 
 (provide 'tcl-tests)
 

bug#44834: Patch to provide failing test for bug 44834

[Lars Ingebrigtsen]

Anticrisis <anticrisisg@gmail.com> writes:

> Trying again with an attachment, thank you for the suggestion.

Thanks; applied to Emacs 28 (but marked the test as failing).

This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Anticrisis]

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

This patch corrects the problem by partially backing out changes
introduced in this commit 2 1/2 years ago:

https://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/progmodes/tcl.el?id=cd5bb4bf3dbad8941d25823f398b595b8f0edbb9

The patch removes the customized tcl-beginning-of-defun-function in
favor of relying on the existing lisp mechanism. It preserves the
customized tcl-end-of-defun-function because that is required for some
test cases.

The expected-failing test was marked as succeeding.

This is a minor change. I did not refer to any code outside of emacs
itself in investigating and correcting this bug. I will not be able to
provide additional paperwork.

[-- Attachment #2: tcl-beginning-of-defun-patch.txt --]
[-- Type: text/plain, Size: 2261 bytes --]

diff --git a/lisp/progmodes/tcl.el b/lisp/progmodes/tcl.el
index 0a0118a5eb..c294a2af22 100644
--- a/lisp/progmodes/tcl.el
+++ b/lisp/progmodes/tcl.el
@@ -651,7 +651,6 @@ tcl-mode
   (setq-local add-log-current-defun-function
        #'tcl-add-log-defun)
 
-  (setq-local beginning-of-defun-function #'tcl-beginning-of-defun-function)
    (setq-local end-of-defun-function #'tcl-end-of-defun-function))
 
 \f
@@ -849,14 +848,12 @@ tcl-calculate-indent
            state
            containing-sexp
            found-next-line)
-      (cond
-       (parse-start
+
+      (if parse-start
           (goto-char parse-start))
-       ((not (beginning-of-defun))
-        ;; If we're not in a function, don't use
-        ;; `tcl-beginning-of-defun-function'.
-        (let ((beginning-of-defun-function nil))
-          (beginning-of-defun))))
+
+      (beginning-of-defun)
+
       (while (< (point) indent-point)
         (setq parse-start (point))
         (setq state (parse-partial-sexp (point) indent-point 0))
@@ -1035,22 +1032,6 @@ tcl-indent-exp
 ;; Interfaces to other packages.
 ;;
 
-(defun tcl-beginning-of-defun-function (&optional arg)
-  "`beginning-of-defun-function' for Tcl mode."
-  (when (or (not arg) (= arg 0))
-    (setq arg 1))
-  (let* ((search-fn (if (> arg 0)
-                        ;; Positive arg means to search backward.
-                        #'re-search-backward
-                      #'re-search-forward))
-         (arg (abs arg))
-         (result t))
-    (while (and (> arg 0) result)
-      (unless (funcall search-fn tcl-proc-regexp nil t)
-        (setq result nil))
-      (setq arg (1- arg)))
-    result))
-
 (defun tcl-end-of-defun-function ()
   "`end-of-defun-function' for Tcl mode."
   ;; Because we let users redefine tcl-proc-list, we don't really know
diff --git a/test/lisp/progmodes/tcl-tests.el b/test/lisp/progmodes/tcl-tests.el
index cf1ed2896e..e55eb6d901 100644
--- a/test/lisp/progmodes/tcl-tests.el
+++ b/test/lisp/progmodes/tcl-tests.el
@@ -74,7 +74,6 @@ tcl-mode-namespace-indent
 
 ;; From bug#44834
 (ert-deftest tcl-mode-namespace-indent-2 ()
-  :expected-result :failed
   (with-temp-buffer
     (tcl-mode)
     (let ((text "namespace eval Foo {\n    proc foo {} {}\n\n    proc bar {}{}}\n"))

bug#44834: Patch also closes bug#44083

[Anticrisis]

This patch also closes bug#44083.

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Lars Ingebrigtsen]

Anticrisis <anticrisisg@gmail.com> writes:

> This is a minor change. I did not refer to any code outside of emacs
> itself in investigating and correcting this bug. I will not be able to
> provide additional paperwork.

The change is unfortunately too big to apply without a copyright
assignment to the FSF.  Are you willing to sign such paperwork?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Anticrisis]

> The change is unfortunately too big to apply without a copyright
> assignment to the FSF.  Are you willing to sign such paperwork?

On further thoughts, I am not willing to complete the paperwork
requested to assign copyright to the FSF. Instead, I waive all
interest in this patch by adopting the CC0 public domain waiver. I
have posted a shortened form of the patch (without the test/ diff) and
waiver to:

  https://gist.github.com/anticrisis/08ca7e7e5a66a4c9d4b445cde7ed75b4

in the hopes that it will be useful to those in the emacs community
who use tcl-mode.

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Dmitry Gutov]

On 27.01.2021 06:37, Lars Ingebrigtsen wrote:
> The change is unfortunately too big to apply without a copyright
> assignment to the FSF.

Is it really?

There are like 2 new [non-empty] lines in there.

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > > The change is unfortunately too big to apply without a copyright
  > > assignment to the FSF.

  > Is it really?

  > There are like 2 new [non-empty] lines in there.

If someone contributes just 2 nontrivial lines, we can treat it as a
trivial change.
-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

I have not looked at the patch or the problem it fixes.
But I can say something about the issue of its copyright.

We can use the program if it is under CC0, but would you
please send the FSF a paper affirming that?

Also, do you have an employer that might claim copyright on it?
-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Anticrisis]

It really is a tiny change, and I explain the rationale in an earlier
comment on this bug report, it would take five minutes for anyone else
to read the explanation and make the same code change. I placed the
CC0 disclaimer using the Creative Commons CC0 tool directly on the
gist at github I posted earlier. I'm afraid any paperwork would
require my real name and signature, which I'm not willing to give. And
I am self-employed. I don't need attribution, I just hope the official
version of tcl-mode can be improved for everyone.

On Sat, Feb 6, 2021 at 7:47 PM Richard Stallman <rms@gnu.org> wrote:
>
> [[[ To any NSA and FBI agents reading my email: please consider    ]]]
> [[[ whether defending the US Constitution against all enemies,     ]]]
> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
>
> I have not looked at the patch or the problem it fixes.
> But I can say something about the issue of its copyright.
>
> We can use the program if it is under CC0, but would you
> please send the FSF a paper affirming that?
>
> Also, do you have an employer that might claim copyright on it?
> --
> Dr Richard Stallman
> Chief GNUisance of the GNU Project (https://gnu.org)
> Founder, Free Software Foundation (https://fsf.org)
> Internet Hall-of-Famer (https://internethalloffame.org)
>
>

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Lars Ingebrigtsen]

Richard Stallman <rms@gnu.org> writes:

>   > > The change is unfortunately too big to apply without a copyright
>   > > assignment to the FSF.
>
>   > Is it really?
>
>   > There are like 2 new [non-empty] lines in there.
>
> If someone contributes just 2 nontrivial lines, we can treat it as a
> trivial change.

Oh, I thought the rule was "15 lines of non-trivial changes", not "15
lines of non-trivial new code"...  (The patch in question mostly just
removes code.)

Let's see...  From CONTRIBUTE:

----
Once the cumulative amount of your submissions exceeds about 15 lines
of non-trivial changes, we will need you to assign to the FSF the
copyright for your contributions. 
----

So if code removal doesn't count, then perhaps this should be rephrased?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Once the cumulative amount of your submissions exceeds about 15 lines
  > of non-trivial changes, we will need you to assign to the FSF the
  > copyright for your contributions. 
  > ----

  > So if code removal doesn't count, then perhaps this should be rephrased?

It can surely be improved, to say that lines deleted or totally replaced don't
count.

However, trying to make it a completely clear and precise statement
is a misguided goal.

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Lars Ingebrigtsen]

Richard Stallman <rms@gnu.org> writes:

>   > Once the cumulative amount of your submissions exceeds about 15 lines
>   > of non-trivial changes, we will need you to assign to the FSF the
>   > copyright for your contributions. 
>   > ----
>
>   > So if code removal doesn't count, then perhaps this should be rephrased?
>
> It can surely be improved, to say that lines deleted or totally replaced don't
> count.
>
> However, trying to make it a completely clear and precise statement
> is a misguided goal.

I've now changed "changes" to "code", and I'll apply the patch.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

The text said

  > >   > Once the cumulative amount of your submissions exceeds about 15 lines
  > >   > of non-trivial changes, we will need you to assign to the FSF the
  > >   > copyright for your contributions. 

I think you changed it to

  > >   > Once the cumulative amount of your submissions exceeds about 15 lines
  > >   > of non-trivial code, we will need you to assign to the FSF the
  > >   > copyright for your contributions. 

but that is not entirely correct either.  People could misinterpret
what is "trivial."

Please put in

   about 10 new or modified nontrivial lines of code.  (A line with
   a symbol is nontrivial.)




-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Lars Ingebrigtsen]

Richard Stallman <rms@gnu.org> writes:

> but that is not entirely correct either.  People could misinterpret
> what is "trivial."
>
> Please put in
>
>    about 10 new or modified nontrivial lines of code.  (A line with
>    a symbol is nontrivial.)

Eli has changed the text further; please have a look.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Tue, 09 Feb 2021 09:24:53 +0100
> Cc: anticrisisg@gmail.com, 44834@debbugs.gnu.org, dgutov@yandex.ru
> 
> Richard Stallman <rms@gnu.org> writes:
> 
> > but that is not entirely correct either.  People could misinterpret
> > what is "trivial."
> >
> > Please put in
> >
> >    about 10 new or modified nontrivial lines of code.  (A line with
> >    a symbol is nontrivial.)
> 
> Eli has changed the text further; please have a look.

FTR, the text now says:

  Once the cumulative amount of your submissions exceeds about 15 lines
  of non-trivial code you added or changed (not counting deleted lines),
  we will need you to assign to the FSF the copyright for your
  contributions.  Ask on emacs-devel@gnu.org, and we will send you the
  necessary form together with the instructions to fill and email it, in
  order to start this legal paperwork.

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > FTR, the text now says:

  >   Once the cumulative amount of your submissions exceeds about 15 lines
  >   of non-trivial code you added or changed (not counting deleted lines),
  >   we will need you to assign to the FSF the copyright for your
  >   contributions.  Ask on emacs-devel@gnu.org, and we will send you the
  >   necessary form together with the instructions to fill and email it, in
  >   order to start this legal paperwork.

Thanks.  Please make it this:

  >   Once the cumulative amount of your submissions exceeds about 10
  >   new or modified nontrivial lines of code, we will need you to
  >   assign to the FSF the copyright for your contributions.  (If a
  >   line contains a symbol, consider it nontrivial.)  Ask on
  >   emacs-devel@gnu.org, and we will send you the necessary form
  >   together with the instructions to fill and email it, in order to
  >   start this legal paperwork.

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Eli Zaretskii]

> From: Richard Stallman <rms@gnu.org>
> Cc: larsi@gnus.org, anticrisisg@gmail.com, 44834@debbugs.gnu.org,
> 	dgutov@yandex.ru
> Date: Wed, 10 Feb 2021 00:32:42 -0500
> 
>   > FTR, the text now says:
> 
>   >   Once the cumulative amount of your submissions exceeds about 15 lines
>   >   of non-trivial code you added or changed (not counting deleted lines),
>   >   we will need you to assign to the FSF the copyright for your
>   >   contributions.  Ask on emacs-devel@gnu.org, and we will send you the
>   >   necessary form together with the instructions to fill and email it, in
>   >   order to start this legal paperwork.
> 
> Thanks.  Please make it this:
> 
>   >   Once the cumulative amount of your submissions exceeds about 10
>   >   new or modified nontrivial lines of code, we will need you to
>   >   assign to the FSF the copyright for your contributions.  (If a
>   >   line contains a symbol, consider it nontrivial.)  Ask on
>   >   emacs-devel@gnu.org, and we will send you the necessary form
>   >   together with the instructions to fill and email it, in order to
>   >   start this legal paperwork.

Why remove the note about not counting deleted lines?  I agree that in
principle "new or modified" covers that, but how many readers will
immediately understand that "modified" doesn't include "deleted"?  I
put that there to make it clear; is there a reason not to say that
explicitly?

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Lars Ingebrigtsen]

Richard Stallman <rms@gnu.org> writes:

>   >   assign to the FSF the copyright for your contributions.  (If a
>   >   line contains a symbol, consider it nontrivial.)  Ask on

I don't quite understand what you mean by "if a line contains a symbol".
Do you mean that strings or comments don't count?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Matt Armstrong]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Richard Stallman <rms@gnu.org> writes:
>
>>   >   assign to the FSF the copyright for your contributions.  (If a
>>   >   line contains a symbol, consider it nontrivial.)  Ask on
>
> I don't quite understand what you mean by "if a line contains a symbol".
> Do you mean that strings or comments don't count?

Yes, "non-blank lines added/changed" seems preferable, simply because it
is clear and unambiguous.

 - I think Richard may have implied that a line with a symbol is a
   sufficient condition for nontriviality, but it isn't clear if
   intended it to be a necessary condition. I suspect he meant
   "sufficient", but I think many people would interpret it as a
   "necessary" condition.

 - The meaning of "symbol" is not immediately clear in non-lisp code
   such as C, makefiles, scripts, etc.

 - If a commit completely rewrites a long comment or doc string, should
   it be considered "trivial" for the purposes of copyright?

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Why remove the note about not counting deleted lines?

Because it is logically not necessary.

  >   I agree that in
  > principle "new or modified" covers that, but how many readers will
  > immediately understand that "modified" doesn't include "deleted"?

The idea is to count lines in the new version which are added or
modified.  If that is clear, you will see that it doesn't count
anything from the old versin.

If that is not clear, we do need to clarify it.  But real
clarification calls for more than "deleted lines don't count".  It's,
"Don't count _anything_ from the old code; count only the added and
modified lines in the _patched_ code."

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > I don't quite understand what you mean by "if a line contains a symbol".
  > Do you mean that strings or comments don't count?

No.  I meant to say that even one symbol on a line maks it nontrivial.
But you're right that strings and comments count.  So do numbers.

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Lars Ingebrigtsen]

Richard Stallman <rms@gnu.org> writes:

>   > Why remove the note about not counting deleted lines?
>
> Because it is logically not necessary.

Preferably, instructions like this shouldn't be brain teasers, but state
(even redundantly) what the terms are.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Eli Zaretskii]

> From: Richard Stallman <rms@gnu.org>
> Cc: larsi@gnus.org, anticrisisg@gmail.com, 44834@debbugs.gnu.org,
> 	dgutov@yandex.ru
> Date: Thu, 11 Feb 2021 08:39:12 -0500
> 
>   >   I agree that in
>   > principle "new or modified" covers that, but how many readers will
>   > immediately understand that "modified" doesn't include "deleted"?
> 
> The idea is to count lines in the new version which are added or
> modified.  If that is clear, you will see that it doesn't count
> anything from the old versin.

The problem is that most modern comparison tools show diffs where
there are no "changed" lines (the "!" mark of "diff -c"), they only
show "-" and "+", i.e. as if the edit distance is a sequence of just 2
operations: delete and add.  So "changed" doesn't have a clear and
immediate interpretation in terms of the presentation in diffs.

> If that is not clear, we do need to clarify it.  But real
> clarification calls for more than "deleted lines don't count".  It's,
> "Don't count _anything_ from the old code; count only the added and
> modified lines in the _patched_ code."

That's clear enough.  How about this text:

  Once the cumulative amount of your submissions exceeds about 10 lines
  of non-trivial changes, we will need you to assign to the FSF the
  copyright for your contributions.  (To see how many lines were
  non-trivially changed, count only added and modified lines in the
  patched code.  An added or changed line is non-trivial if it includes
  at least one identifier.)  Ask on emacs-devel@gnu.org, and we will
  send you the necessary form together with the instructions to fill and
  email it, in order to start this legal paperwork.

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Eli Zaretskii]

> From: Richard Stallman <rms@gnu.org>
> Cc: eliz@gnu.org, anticrisisg@gmail.com, 44834@debbugs.gnu.org,
> 	dgutov@yandex.ru
> Date: Thu, 11 Feb 2021 08:39:24 -0500
> 
>   > I don't quite understand what you mean by "if a line contains a symbol".
>   > Do you mean that strings or comments don't count?
> 
> No.  I meant to say that even one symbol on a line maks it nontrivial.
> But you're right that strings and comments count.  So do numbers.

Empty lines are clearly trivial, but what other examples of trivial
lines exist?  Should we say "non-empty lines"?

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Dmitry Gutov]

On 11.02.2021 16:41, Eli Zaretskii wrote:
> Empty lines are clearly trivial, but what other examples of trivial
> lines exist?  Should we say "non-empty lines"?

I think we should also usually discount the cases of moving code around.

If a line was removed in one place and an exact same line added in 
another, it's not really new code.

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Empty lines are clearly trivial, but what other examples of trivial
  > lines exist?  Should we say "non-empty lines"?

A line with just braces, or parentheses, or just a few operators,
can be taken as trivial.

There is no precise rule here.


-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > > The idea is to count lines in the new version which are added or
  > > modified.  If that is clear, you will see that it doesn't count
  > > anything from the old versin.

  > The problem is that most modern comparison tools show diffs where
  > there are no "changed" lines (the "!" mark of "diff -c"), they only
  > show "-" and "+", i.e. as if the edit distance is a sequence of just 2
  > operations: delete and add.

That seems inconvenient, in general.  Why do they do that?

But it doesn't matter at all for this one purpose.

                                 So "changed" doesn't have a clear and
  > immediate interpretation in terms of the presentation in diffs.

When you're counting the added or changed lines, it should not matter
whether the tool distinguishs added lines from changed lines.
If it labels them all with +, you can still count them.


-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

    > Once the cumulative amount of your submissions exceeds about 10 lines
    > of non-trivial changes, we will need you to assign to the FSF the
    > copyright for your contributions.  (To see how many lines were
    > non-trivially changed, count only added and modified lines in the
    > patched code.  An added or changed line is non-trivial if it includes
    > at least one identifier.)  Ask on emacs-devel@gnu.org, and we will
    > send you the necessary form together with the instructions to fill and
    > email it, in order to start this legal paperwork.

Please change it to this.  (I am taking account of someone else's
feedback.)

    > Once the cumulative amount of your submissions exceeds about 10 lines
    > of non-trivial changes, we will need you to assign to the FSF the
    > copyright for your contributions.  (To see how many lines were
    > non-trivially changed, count only added and modified lines in the
    > patched code.  Consider an added or changed line to be non-trivial
    > if it includes at least one identifier, string, or substantial comment.)
    > Ask on emacs-devel@gnu.org, and we will
    > send you the necessary form together with the instructions to fill and
    > email it, in order to start this legal paperwork.

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Eli Zaretskii]

> From: Richard Stallman <rms@gnu.org>
> Cc: anticrisisg@gmail.com, larsi@gnus.org, 44834@debbugs.gnu.org,
> 	dgutov@yandex.ru
> Date: Fri, 12 Feb 2021 00:48:54 -0500
> 
> Please change it to this.  (I am taking account of someone else's
> feedback.)
> 
>     > Once the cumulative amount of your submissions exceeds about 10 lines
>     > of non-trivial changes, we will need you to assign to the FSF the
>     > copyright for your contributions.  (To see how many lines were
>     > non-trivially changed, count only added and modified lines in the
>     > patched code.  Consider an added or changed line to be non-trivial
>     > if it includes at least one identifier, string, or substantial comment.)
>     > Ask on emacs-devel@gnu.org, and we will
>     > send you the necessary form together with the instructions to fill and
>     > email it, in order to start this legal paperwork.

Thanks, installed.

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>   Once the cumulative amount of your submissions exceeds about 10 lines
>   of non-trivial changes, we will need you to assign to the FSF the

But it used to be 15 lines?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: rms@gnu.org,  anticrisisg@gmail.com,  44834@debbugs.gnu.org,
>   dgutov@yandex.ru
> Date: Fri, 12 Feb 2021 09:14:33 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >   Once the cumulative amount of your submissions exceeds about 10 lines
> >   of non-trivial changes, we will need you to assign to the FSF the
> 
> But it used to be 15 lines?

Richard asked to change it to 10.

AFAIU, what CONTRIBUTE says is just a conservative threshold, above
which human judgment is required.  After all, how much of creative
value is there in any given code is not something one can estimate by
just counting lines.

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > >   Once the cumulative amount of your submissions exceeds about 10 lines
  > >   of non-trivial changes, we will need you to assign to the FSF the

  > But it used to be 15 lines?

If people were counting both old and new code in the patch, and now they
are counting just new code, the total should be smaller.

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Lars Ingebrigtsen]

Richard Stallman <rms@gnu.org> writes:

>   > >   Once the cumulative amount of your submissions exceeds about 10 lines
>   > >   of non-trivial changes, we will need you to assign to the FSF the
>
>   > But it used to be 15 lines?
>
> If people were counting both old and new code in the patch, and now they
> are counting just new code, the total should be smaller.

I was counting that way, but it doesn't sound like Eli was (and I don't
know whether anybody else was).  So if that's the reason for lowering
the number of lines, it should be changed back to 15 again.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Dmitry Gutov]

On 13.02.2021 05:26, Richard Stallman wrote:
> If people were counting both old and new code in the patch

I didn't.

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > > If people were counting both old and new code in the patch

  > I didn't.

It's not about you or one specific case.

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Dmitry Gutov]

On 16.02.2021 07:19, Richard Stallman wrote:
>    > > If people were counting both old and new code in the patch
> 
>    > I didn't.
> 
> It's not about you or one specific case.

I have been accepting patches from users for years, both into Emacs 
proper and into several GNU ELPA packages.

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Lars Ingebrigtsen]

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 16.02.2021 07:19, Richard Stallman wrote:
>>    > > If people were counting both old and new code in the patch
>>    > I didn't.
>> It's not about you or one specific case.
>
> I have been accepting patches from users for years, both into Emacs
> proper and into several GNU ELPA packages.

So I think the text should go back to "15" unless Richard has a better
explanation for the change.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Tue, 16 Feb 2021 13:06:43 +0100
> Cc: anticrisisg@gmail.com, 44834@debbugs.gnu.org, rms@gnu.org
> 
> So I think the text should go back to "15" unless Richard has a better
> explanation for the change.

Would it be good enough to say "about 10" instead?  The exact number
is impossible to define, and arguing about it is waste of time and
energy.  When in doubt (and we rarely are), we can always ask (and
actually do ask).

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> Would it be good enough to say "about 10" instead?  The exact number
> is impossible to define, and arguing about it is waste of time and
> energy.

Sure, that's fine.  Or "about 15".  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Juri Linkov]

>> So I think the text should go back to "15" unless Richard has a better
>> explanation for the change.
>
> Would it be good enough to say "about 10" instead?  The exact number
> is impossible to define, and arguing about it is waste of time and
> energy.  When in doubt (and we rarely are), we can always ask (and
> actually do ask).

Or for a number between 10 and 15 - "a dozen".

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Cc: Lars Ingebrigtsen <larsi@gnus.org>,  anticrisisg@gmail.com,
>   44834@debbugs.gnu.org,  rms@gnu.org,  dgutov@yandex.ru
> Date: Tue, 16 Feb 2021 19:15:20 +0200
> 
> Or for a number between 10 and 15 - "a dozen".

Yes, "a dozen" would also be good, IMO.

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > >> It's not about you or one specific case.
  > >
  > > I have been accepting patches from users for years, both into Emacs
  > > proper and into several GNU ELPA packages.

  > So I think the text should go back to "15" unless Richard has a better
  > explanation for the change.

I can't follow your reasoning.  Why is Dmitri's own interpretation
of the old wording have to do with this question?

It's possible I am mistaken about how people generally interpreted
the previous criterion, but one person's interpretation doesn't show that.

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Or for a number between 10 and 15 - "a dozen".

"a dozen or so" could be good.

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Eli Zaretskii]

> From: Richard Stallman <rms@gnu.org>
> Cc: eliz@gnu.org, larsi@gnus.org, anticrisisg@gmail.com,
> 	44834@debbugs.gnu.org, dgutov@yandex.ru
> Date: Thu, 18 Feb 2021 01:12:46 -0500
> 
>   > Or for a number between 10 and 15 - "a dozen".
> 
> "a dozen or so" could be good.

Thanks, I made that change.

bug#44834: Fix for failing indentation of Tcl procs nested in namespace

[Dmitry Gutov]

On 16.02.2021 17:38, Eli Zaretskii wrote:
> When in doubt (and we rarely are)

I believe this will happen more often now.