From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Francesco =?UTF-8?Q?Potort=C3=AC?= Newsgroups: gmane.emacs.bugs Subject: bug#44617: 26.3; diff-mode ignores diff-switches Date: Sat, 05 Dec 2020 22:05:19 +0100 Message-ID: References: <87361bzz0y.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1797"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44617@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 05 22:06:23 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1klel4-0000Mq-Nj for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Dec 2020 22:06:22 +0100 Original-Received: from localhost ([::1]:42838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klel3-00012c-PR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Dec 2020 16:06:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klekk-00012J-PG for bug-gnu-emacs@gnu.org; Sat, 05 Dec 2020 16:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36792) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klekk-0005JB-IU for bug-gnu-emacs@gnu.org; Sat, 05 Dec 2020 16:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1klekk-0004ea-CO for bug-gnu-emacs@gnu.org; Sat, 05 Dec 2020 16:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Francesco =?UTF-8?Q?Potort=C3=AC?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Dec 2020 21:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44617 X-GNU-PR-Package: emacs Original-Received: via spool by 44617-submit@debbugs.gnu.org id=B44617.160720232417840 (code B ref 44617); Sat, 05 Dec 2020 21:06:02 +0000 Original-Received: (at 44617) by debbugs.gnu.org; 5 Dec 2020 21:05:24 +0000 Original-Received: from localhost ([127.0.0.1]:48338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klek8-0004dg-9N for submit@debbugs.gnu.org; Sat, 05 Dec 2020 16:05:24 -0500 Original-Received: from smtp-clients1.isti.cnr.it ([146.48.28.36]:43946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klek6-0004dX-0T for 44617@debbugs.gnu.org; Sat, 05 Dec 2020 16:05:22 -0500 Original-Received: from tucano.isti.cnr.it (tucano.isti.cnr.it [146.48.81.102]) (Authenticated sender: pot) by smtp-clients1.isti.cnr.it (Postfix) with ESMTPSA id 52C76B07F2; Sat, 5 Dec 2020 22:05:20 +0100 (CET) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.4 at smtp-out.isti.cnr.it Original-Received: from pot by tucano.isti.cnr.it with local (Exim 4.94) (envelope-from ) id 1klek3-002UaW-U6; Sat, 05 Dec 2020 22:05:19 +0100 In-Reply-To: <87361bzz0y.fsf@gnus.org> (larsi@gnus.org) X-fingerprint: 4B02 6187 5C03 D6B1 2E31 7666 09DF 2DC9 BE21 6115 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195056 Archived-At: >> diff-mode relies on the diff-command variables defined in diff.el, but >> ignores diff-switches >> >> I think this is a bug > >Do you mean the `diff-refresh-hunk' command? No, it's a different issue. >What's the use case you have for diff-switches where you'd want this >command to heed diff-switches? I have two use cases. 1) When using dired-diff (hit = in a dired buffer) diff-switches is not used. 2) Same is when using vc-diff (C-x v =) in a VC buffer. Apparently case 2) is a bug, because the docs of vc-diff-switches says that diff-switches should be used. Case 1) could simply be unexpected behaviour.