From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: ams@gnu.org (Alfred M. Szmidt) Newsgroups: gmane.emacs.bugs Subject: bug#43615: 26.3; eshell: face for directory and symlink the same in terminal Date: Sat, 26 Sep 2020 04:33:00 -0400 Message-ID: References: <83ft75ss47.fsf@gnu.org> <83eempsqn8.fsf@gnu.org> <83a6xdsp2k.fsf@gnu.org> <833635rqyx.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32124"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43615@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 26 10:34:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kM5f0-0008Fh-MC for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Sep 2020 10:34:26 +0200 Original-Received: from localhost ([::1]:47980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kM5ez-00074e-Mg for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Sep 2020 04:34:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kM5ec-00074J-BR for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2020 04:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34226) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kM5eb-0004Ru-VX for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2020 04:34:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kM5eb-0000dw-QP for bug-gnu-emacs@gnu.org; Sat, 26 Sep 2020 04:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: ams@gnu.org (Alfred M. Szmidt) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Sep 2020 08:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43615 X-GNU-PR-Package: emacs Original-Received: via spool by 43615-submit@debbugs.gnu.org id=B43615.16011091882405 (code B ref 43615); Sat, 26 Sep 2020 08:34:01 +0000 Original-Received: (at 43615) by debbugs.gnu.org; 26 Sep 2020 08:33:08 +0000 Original-Received: from localhost ([127.0.0.1]:45772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kM5dj-0000cj-NC for submit@debbugs.gnu.org; Sat, 26 Sep 2020 04:33:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kM5di-0000cK-BQ for 43615@debbugs.gnu.org; Sat, 26 Sep 2020 04:33:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58010) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kM5dd-0004OI-3U for 43615@debbugs.gnu.org; Sat, 26 Sep 2020 04:33:01 -0400 Original-Received: from ams by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1kM5dc-0002er-Cj; Sat, 26 Sep 2020 04:33:00 -0400 In-reply-to: <833635rqyx.fsf@gnu.org> (message from Eli Zaretskii on Sat, 26 Sep 2020 09:29:10 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189002 Archived-At: > black black #000000 > red red #ff0000 > green green #00ff00 > yellow yellow #ffff00 > blue blue #0000ff > magenta magenta #ff00ff > cyan cyan #00ffff > white white #ffffff This indicates you have only 8 colors, not 16. I based the 16 colors on the documentation for the console; it might be that there is some switch one can flip for more. > I'd think that magenta would make most sense, but that would require > changing what is used for eshell-ls-archive? Doing TRT with just 8 colors is a tough nut, since there are 11 file types for which Eshell uses colors. Maybe colors should be disabled for such terminals? Or maybe some faces should have no color definitions for 8-color terminals, leaving only the most frequent and important files shown in color? I think the later would make most sense. What would a good criteria be for frequet/important? In my mind, I'd like to know first and for most if a file is a plain file, directory, symlink or special. Then, if it is executable -- to know if ./foo will work. After that, I think it is mostly nice things, being able to know if a file is missing, unreadable, or readonly is useful information since that means you know what happens if you open the file. This is slightly different thant for archives, since Emacs will switch to whatever mode the file suffix is anyway for any file, and archives aren't "that" special. Lastly, not showing backup/junk/product files in a highly contrasted color. Does that make sense? That would make the list of faces for 8 color (though this would require to modify the scheme slightly): plain directory symlink special executable readonly / unreadable/ missing backup / product / clutter So maybe just limit it to the plain / directory / symlink / special / executable group?