bug#43275: Upgrade antlr-mode to latest version

bug#43275: Upgrade antlr-mode to latest version

[Stefan Kangas]

Severity: wishlist

The antlr-mode shipped with Emacs is version 2.2c, but there is a
version 3.1.5 available at:

    https://sourceforge.net/projects/antlr-mode/files/

Could we upgrade it to the latest version?

Best regards,
Stefan Kangas

bug#43275: Upgrade antlr-mode to latest version

[Stefan Kangas]

Stefan Kangas <stefan@marxist.se> writes:

> The antlr-mode shipped with Emacs is version 2.2c, but there is a
> version 3.1.5 available at:
>
>     https://sourceforge.net/projects/antlr-mode/files/
>
> Could we upgrade it to the latest version?

Here's a relevant thread from 2015:
https://lists.gnu.org/archive/html/emacs-devel/2015-11/msg02057.html

bug#43275: Upgrade antlr-mode to latest version

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > The antlr-mode shipped with Emacs is version 2.2c, but there is a
  > version 3.1.5 available at:

  >     https://sourceforge.net/projects/antlr-mode/files/

  > Could we upgrade it to the latest version?

I hope we can, but the fact that updating has not occurred all along
indicates a lack of communication with the developer of antlr-mode.
Would one of the maintainers please try to make contact with
the current developers and establish a relationship to get their
future changes installed when they are made?
-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#43275: Upgrade antlr-mode to latest version

[Wedler, Christoph]

  >> The antlr-mode shipped with Emacs is version 2.2c, but there is a
  >> version 3.1.5 available at:

  >>     https://sourceforge.net/projects/antlr-mode/files/

  >> Could we upgrade it to the latest version?

> I hope we can, but the fact that updating has not occurred all along
> indicates a lack of communication with the developer of antlr-mode.

If you need anything from my side (I am the author of antlr-mode),
please let me know.
Unfortunately, it is unrealistic for me to change the Emacs code base directly
(due to inexperience in it & time constraints).

I use antlr-3.1.5 myself on Emacs 26.3 with ANTLR v4.8/JS,
so there is hopefully no bigger adaption necessary...

Best regards,
Christoph

bug#43275: Upgrade antlr-mode to latest version

[Stefan Kangas]

"Wedler, Christoph" <christoph.wedler@sap.com> writes:

>   >> The antlr-mode shipped with Emacs is version 2.2c, but there is a
>   >> version 3.1.5 available at:
>
>   >>     https://sourceforge.net/projects/antlr-mode/files/
>
>   >> Could we upgrade it to the latest version?
>
>> I hope we can, but the fact that updating has not occurred all along
>> indicates a lack of communication with the developer of antlr-mode.
>
> If you need anything from my side (I am the author of antlr-mode),
> please let me know.
> Unfortunately, it is unrealistic for me to change the Emacs code base directly
> (due to inexperience in it & time constraints).
>
> I use antlr-3.1.5 myself on Emacs 26.3 with ANTLR v4.8/JS,
> so there is hopefully no bigger adaption necessary...

Thank you, your help is appreciated.

What is the best way to get the version of your code most suitable to
add to Emacs?  Should I use the above sourceforge link?

Best regards,
Stefan Kangas

bug#43275: Upgrade antlr-mode to latest version

[Stefan Kangas]

Stefan Kangas <stefan@marxist.se> writes:

> What is the best way to get the version of your code most suitable to
> add to Emacs?  Should I use the above sourceforge link?

I see now that there have been some changes in antlr-mode.el in the
Emacs source tree.  None of them look very big to me, and I would expect
that they would not take too much time for you to review.

Would you be willing to merge those changes into your version and send
an updated version here?

Best regards,
Stefan Kangas

bug#43275: Upgrade antlr-mode to latest version

[Wedler, Christoph]

Stefan Kangas <stefan@marxist.se> writes:

> I see now that there have been some changes in antlr-mode.el in the
> Emacs source tree.  None of them look very big to me, and I would expect
> that they would not take too much time for you to review.

> Would you be willing to merge those changes into your version and send
> an updated version here?

OK - I would basically do M-x emerge-files-with-ancestor:

- A: my antlr-mode.el 3.1.5
- B: lisp/progmodes/antlr-mode.el
- Ancestor: lisp/progmodes/antlr-mode.el.~emacs-25.1~ (see my ChangeLog comment 2016-11-22),

Does that sounds reasonable?

If someone can guide me how Emacs handles git, I can probably directly push a change

- starting at branch "master"?
- which branch to push to?
- change comment: my ChangeLog starting at 2.2c?

bug#43275: Upgrade antlr-mode to latest version

[Stefan Kangas]

"Wedler, Christoph" <christoph.wedler@sap.com> writes:

> OK - I would basically do M-x emerge-files-with-ancestor:
>
> - A: my antlr-mode.el 3.1.5
> - B: lisp/progmodes/antlr-mode.el
> - Ancestor: lisp/progmodes/antlr-mode.el.~emacs-25.1~ (see my ChangeLog comment 2016-11-22),
>
> Does that sounds reasonable?

I've never used that command, so I unfortunately can't help you with
that.  Why not just give it a spin and see what happens?  :-)

Another idea is to just manually look over the commits and apply them
one by one to your sources as it makes sense.

> If someone can guide me how Emacs handles git, I can probably directly push a change
>
> - starting at branch "master"?
> - which branch to push to?

To get commit access, you will need to apply for it on Savannah.  I'm
not sure about the exact requirements to get commit access.

If it's easier, you could send a patch here and we can push it for you.

> - change comment: my ChangeLog starting at 2.2c?

If you send the patch here first, we can look over the formatting.  But
if you already have a GNU conforming ChangeLog, it sounds like a good
idea to adapt it for Emacs.  If it's much too big to adapt, I think it's
also okay to fall back to something like:

* lisp/progmodes/antlr-mode.el: Sync with latest upstream.

bug#43275: Upgrade antlr-mode to latest version

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > If you need anything from my side (I am the author of antlr-mode),
  > please let me know.
  > Unfortunately, it is unrealistic for me to change the Emacs code base directly
  > (due to inexperience in it & time constraints).

For the long term, I expect we can make it feasible for you to do that,
if you are willing to.

For the short term, can you prepare a patch you recommend installing,
with suitable commit notes?

-- 
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

bug#43275: Upgrade antlr-mode to latest version

[Stefan Kangas]

Stefan Kangas <stefan@marxist.se> writes:

> "Wedler, Christoph" <christoph.wedler@sap.com> writes:
>
>> OK - I would basically do M-x emerge-files-with-ancestor:
>>
>> - A: my antlr-mode.el 3.1.5
>> - B: lisp/progmodes/antlr-mode.el
>> - Ancestor: lisp/progmodes/antlr-mode.el.~emacs-25.1~ (see my ChangeLog comment 2016-11-22),
>>
>> Does that sounds reasonable?
>
> I've never used that command, so I unfortunately can't help you with
> that.  Why not just give it a spin and see what happens?  :-)
>
> Another idea is to just manually look over the commits and apply them
> one by one to your sources as it makes sense.
>
>> If someone can guide me how Emacs handles git, I can probably directly push a change
>>
>> - starting at branch "master"?
>> - which branch to push to?
>
> To get commit access, you will need to apply for it on Savannah.  I'm
> not sure about the exact requirements to get commit access.
>
> If it's easier, you could send a patch here and we can push it for you.
>
>> - change comment: my ChangeLog starting at 2.2c?
>
> If you send the patch here first, we can look over the formatting.  But
> if you already have a GNU conforming ChangeLog, it sounds like a good
> idea to adapt it for Emacs.  If it's much too big to adapt, I think it's
> also okay to fall back to something like:
>
> * lisp/progmodes/antlr-mode.el: Sync with latest upstream.

That was 16 weeks ago.  Any updates here?

Thanks in advance.

bug#43275: Upgrade antlr-mode to latest version

[Stefan Kangas]

Stefan Kangas <stefan@marxist.se> writes:

> Stefan Kangas <stefan@marxist.se> writes:
>
>> "Wedler, Christoph" <christoph.wedler@sap.com> writes:
>>
>>> OK - I would basically do M-x emerge-files-with-ancestor:
>>>
>>> - A: my antlr-mode.el 3.1.5
>>> - B: lisp/progmodes/antlr-mode.el
>>> - Ancestor: lisp/progmodes/antlr-mode.el.~emacs-25.1~ (see my ChangeLog comment 2016-11-22),
>>>
>>> Does that sounds reasonable?
>>
>> I've never used that command, so I unfortunately can't help you with
>> that.  Why not just give it a spin and see what happens?  :-)
>>
>> Another idea is to just manually look over the commits and apply them
>> one by one to your sources as it makes sense.
>>
>>> If someone can guide me how Emacs handles git, I can probably directly push a change
>>>
>>> - starting at branch "master"?
>>> - which branch to push to?
>>
>> To get commit access, you will need to apply for it on Savannah.  I'm
>> not sure about the exact requirements to get commit access.
>>
>> If it's easier, you could send a patch here and we can push it for you.
>>
>>> - change comment: my ChangeLog starting at 2.2c?
>>
>> If you send the patch here first, we can look over the formatting.  But
>> if you already have a GNU conforming ChangeLog, it sounds like a good
>> idea to adapt it for Emacs.  If it's much too big to adapt, I think it's
>> also okay to fall back to something like:
>>
>> * lisp/progmodes/antlr-mode.el: Sync with latest upstream.
>
> That was 16 weeks ago.  Any updates here?
>
> Thanks in advance.

Just a friendly ping about this, thanks in advance.

bug#43275: Upgrade antlr-mode to latest version

[Stefan Kangas]

Dear Christoph,

The last time we discussed this was three years ago, and this fell off
my radar.  I'm hoping we could pick up the thread now.

Did you make any progress with merging the changes in Emacs into your
tree?  I think this is still blocking merging the latest version of
antlr-mode into Emacs.

I think the best workflow here is that you merge all changes you like,
release that as a new version 3.1.6, and then we can just install that
version into Emacs.

The other option is that we do the work of merging the changes and send
a new proposed version 3.1.6 to you.  Supposedly, you will then want to
release it on SourceForge.  It will be harder for you to review any
changes on the Emacs side, of course, and it will be a bit more
error-prone since the merge isn't handled by the person that knows the
code best.

Thanks in advance.

Stefan Kangas <stefankangas@gmail.com> writes:

> "Wedler, Christoph" <christoph.wedler@sap.com> writes:
>
>> OK - I would basically do M-x emerge-files-with-ancestor:
>>
>> - A: my antlr-mode.el 3.1.5
>> - B: lisp/progmodes/antlr-mode.el
>> - Ancestor: lisp/progmodes/antlr-mode.el.~emacs-25.1~ (see my ChangeLog comment 2016-11-22),
>>
>> Does that sounds reasonable?
>
> I've never used that command, so I unfortunately can't help you with
> that.  Why not just give it a spin and see what happens?  :-)
>
> Another idea is to just manually look over the commits and apply them
> one by one to your sources as it makes sense.
>
>> If someone can guide me how Emacs handles git, I can probably directly push a change
>>
>> - starting at branch "master"?
>> - which branch to push to?
>
> To get commit access, you will need to apply for it on Savannah.  I'm
> not sure about the exact requirements to get commit access.
>
> If it's easier, you could send a patch here and we can push it for you.
>
>> - change comment: my ChangeLog starting at 2.2c?
>
> If you send the patch here first, we can look over the formatting.  But
> if you already have a GNU conforming ChangeLog, it sounds like a good
> idea to adapt it for Emacs.  If it's much too big to adapt, I think it's
> also okay to fall back to something like:
>
> * lisp/progmodes/antlr-mode.el: Sync with latest upstream.