bug#31271: 25.2; exported deleted RMAIL emails should have theit deleted flag reset

bug#31271: 25.2; exported deleted RMAIL emails should have theit deleted flag reset

[Francesco Potortì]

In Rmail, suppose you want to archive your last received email to two
different mboxes.  Then you 'o' to the first one, then 'o' to the second
one.  After the first one, the email is marked as filed, deleted.

I argue that the 'deleted' flag should be reset when archiving the email
to the second mbox.



In GNU Emacs 25.2.1 (x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2018-02-19, modified by Debian built on x86-ubc-01
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description:	Debian GNU/Linux testing (buster)

Configured using:
 'configure --build x86_64-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/lib
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs25:/etc/emacs:/usr/local/share/emacs/25.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.2/site-lisp:/usr/share/emacs/site-lisp
 --with-sound=alsa --without-gconf --build x86_64-linux-gnu
 --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs25:/etc/emacs:/usr/local/share/emacs/25.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.2/site-lisp:/usr/share/emacs/site-lisp
 --with-sound=alsa --without-gconf --with-x=yes --with-x-toolkit=lucid
 --with-toolkit-scroll-bars --without-gsettings 'CFLAGS=-g -O2
 -fdebug-prefix-map=/build/emacs25-oNxPKC/emacs25-25.2+1=. -fstack-protector-strong
 -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time
 -D_FORTIFY_SOURCE=2' LDFLAGS=-Wl,-z,relro'

Configured features:
XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS NOTIFY ACL
LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS LUCID X11

Important settings:
  value of $LC_COLLATE: it_IT.UTF-8
  value of $LC_CTYPE: it_IT.UTF-8
  value of $LC_NUMERIC: C
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: RMAIL

Minor modes in effect:
  TeX-PDF-mode: t
  desktop-save-mode: t
  epa-global-mail-mode: t
  shell-dirtrack-mode: t
  openwith-mode: t
  xterm-mouse-mode: t
  display-time-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  column-number-mode: t
  line-number-mode: t

Recent messages:
Counting messages...done
Showing message 2...done
Showing message 2...done
Saving file /home/pot/Mail/lavoro/pubblicazioni/4anchors...
Wrote /home/pot/Mail/lavoro/pubblicazioni/4anchors [2 times]
Expunging deleted messages...done
Showing message 266...
Saving file /home/pot/Mail/RMAIL...
Wrote /home/pot/Mail/RMAIL [2 times]
Making completion list... [2 times]

Load-path shadows:
~/elisp/bhl hides /usr/share/emacs/25.2/site-lisp/bhl
~/elisp/bhl hides /usr/share/emacs/site-lisp/bhl
/usr/share/emacs/25.2/site-lisp/debian-startup hides /usr/share/emacs/site-lisp/debian-startup
/usr/share/emacs25/site-lisp/flim/md4 hides /usr/share/emacs/25.2/lisp/md4
/usr/share/emacs25/site-lisp/flim/hex-util hides /usr/share/emacs/25.2/lisp/hex-util
/usr/share/emacs/site-lisp/rst hides /usr/share/emacs/25.2/lisp/textmodes/rst
~/elisp/bibtex hides /usr/share/emacs/25.2/lisp/textmodes/bibtex
~/elisp/octave hides /usr/share/emacs/25.2/lisp/progmodes/octave
/usr/share/emacs25/site-lisp/flim/ntlm hides /usr/share/emacs/25.2/lisp/net/ntlm
/usr/share/emacs25/site-lisp/flim/hmac-md5 hides /usr/share/emacs/25.2/lisp/net/hmac-md5
/usr/share/emacs25/site-lisp/flim/sasl-ntlm hides /usr/share/emacs/25.2/lisp/net/sasl-ntlm
/usr/share/emacs25/site-lisp/flim/sasl-digest hides /usr/share/emacs/25.2/lisp/net/sasl-digest
/usr/share/emacs25/site-lisp/flim/sasl hides /usr/share/emacs/25.2/lisp/net/sasl
/usr/share/emacs25/site-lisp/flim/sasl-cram hides /usr/share/emacs/25.2/lisp/net/sasl-cram
/usr/share/emacs25/site-lisp/flim/hmac-def hides /usr/share/emacs/25.2/lisp/net/hmac-def
/usr/share/emacs25/site-lisp/latex-cjk-thai/thai-word hides /usr/share/emacs/25.2/lisp/language/thai-word
/usr/share/emacs25/site-lisp/auctex/tex-fold hides /usr/share/emacs/site-lisp/auctex/tex-fold
/usr/share/emacs25/site-lisp/auctex/context-en hides /usr/share/emacs/site-lisp/auctex/context-en
/usr/share/emacs25/site-lisp/auctex/tex-info hides /usr/share/emacs/site-lisp/auctex/tex-info
/usr/share/emacs25/site-lisp/auctex/plain-tex hides /usr/share/emacs/site-lisp/auctex/plain-tex
/usr/share/emacs25/site-lisp/auctex/tex-mik hides /usr/share/emacs/site-lisp/auctex/tex-mik
/usr/share/emacs25/site-lisp/auctex/texmathp hides /usr/share/emacs/site-lisp/auctex/texmathp
/usr/share/emacs25/site-lisp/auctex/context-nl hides /usr/share/emacs/site-lisp/auctex/context-nl
/usr/share/emacs25/site-lisp/auctex/toolbar-x hides /usr/share/emacs/site-lisp/auctex/toolbar-x
/usr/share/emacs25/site-lisp/auctex/tex hides /usr/share/emacs/site-lisp/auctex/tex
/usr/share/emacs25/site-lisp/auctex/tex-jp hides /usr/share/emacs/site-lisp/auctex/tex-jp
/usr/share/emacs25/site-lisp/auctex/tex-ispell hides /usr/share/emacs/site-lisp/auctex/tex-ispell
/usr/share/emacs25/site-lisp/auctex/bib-cite hides /usr/share/emacs/site-lisp/auctex/bib-cite
/usr/share/emacs25/site-lisp/auctex/multi-prompt hides /usr/share/emacs/site-lisp/auctex/multi-prompt
/usr/share/emacs25/site-lisp/auctex/font-latex hides /usr/share/emacs/site-lisp/auctex/font-latex
/usr/share/emacs25/site-lisp/auctex/prv-emacs hides /usr/share/emacs/site-lisp/auctex/prv-emacs
/usr/share/emacs25/site-lisp/auctex/tex-style hides /usr/share/emacs/site-lisp/auctex/tex-style
/usr/share/emacs25/site-lisp/auctex/context hides /usr/share/emacs/site-lisp/auctex/context
/usr/share/emacs25/site-lisp/auctex/preview hides /usr/share/emacs/site-lisp/auctex/preview
/usr/share/emacs25/site-lisp/auctex/tex-font hides /usr/share/emacs/site-lisp/auctex/tex-font
/usr/share/emacs25/site-lisp/auctex/tex-bar hides /usr/share/emacs/site-lisp/auctex/tex-bar
/usr/share/emacs25/site-lisp/auctex/latex hides /usr/share/emacs/site-lisp/auctex/latex
/usr/share/emacs25/site-lisp/auctex/tex-buf hides /usr/share/emacs/site-lisp/auctex/tex-buf

Features:
(shadow emacsbug reporter debian-bug tramp-cache add-log unrmail repeat
pp parse-time network-stream nsm starttls url-http tls gnutls url-gw
url-cache url-auth url url-proxy url-privacy url-expand url-methods
url-history url-cookie url-domsuf mailcap tabify table ispell cus-start
cus-load autorevert filenotify locate wdired anything-config anything
woman man cl two-column iso-transl eieio-opt speedbar sb-image ezimage
dframe find-func face-remap w3m-form w3m-filter w3m-cookie w3m-bookmark
w3m-tabmenu w3m-session w3m doc-view image-mode w3m-hist w3m-fb
bookmark-w3m w3m-ems wid-edit w3m-ccl ccl w3m-favicon w3m-image w3m-proc
w3m-util url-handlers texmathp arc-mode archive-mode tramp-sh undigest
macros dabbrev rmailedit etags dired-aux timezone rmailsort shr-color
color rect xref project rmailkwd misearch multi-isearch url-util shr dom
subr-x browse-url rmailout mailalias time-stamp server bibtex info
jka-compr sh-script executable generic js sgml-mode json map imenu
vc-dispatcher vc-svn cc-mode cc-fonts cc-guess cc-menus cc-cmds
cc-styles cc-align cc-engine cc-vars cc-defs latexenc preview prv-emacs
tex-bar tex-buf toolbar-x noutline outline font-latex latex edmacro
kmacro tex-ispell tex-style tex dbus xml crm tex-mode compile view gud
easy-mmode vc-filewise vc-rcs octave texinfo smie qp rmailmm message
rfc822 mml mml-sec mm-decode mm-bodies mm-encode mailabbrev gmm-utils
mailheader mail-parse rfc2231 desktop frameset term/xterm xterm solar
cal-dst pot skeleton warnings rmailsum rmail sendmail rfc2047 rfc2045
ietf-drums mime-compose epa-mail mail-utils epa derived epg holidays
hol-loaddefs appt diary-lib diary-loaddefs cal-menu calendar
cal-loaddefs tramp tramp-compat tramp-loaddefs trampver ucs-normalize
shell pcomplete comint ring format-spec advice bhl visual-fill-column
switch-to-shell openwith hi-lock xt-mouse ffap thingatpt url-parse
auth-source cl-seq eieio eieio-core cl-macs gnus-util time-date mm-util
help-fns mail-prsvr password-cache url-vars scroll-in-place filladapt
ansi-color time quail dired-x dired generic-x disp-table finder-inf
package epg-config seq byte-opt gv bytecomp byte-compile cl-extra
help-mode easymenu cconv cl-loaddefs pcase cl-lib debian-el
debian-el-loaddefs w3m-load vm-autoload vm-autoloads vm-version vm-vars
vm-init preview-latex tex-site auto-loads mule-util tooltip eldoc
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces
cus-face macroexp files text-properties overlay sha1 md5 base64 format
env code-pages mule custom widget hashtable-print-readable backquote
dbusbind inotify dynamic-setting font-render-setting x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 943967 170671)
 (symbols 48 56007 55)
 (miscs 40 3450 5189)
 (strings 32 173720 26292)
 (string-bytes 1 5071606)
 (vectors 16 74082)
 (vector-slots 8 2114828 132396)
 (floats 8 1173 1580)
 (intervals 56 52698 5806)
 (buffers 976 170))

bug#31271: 25.2; exported deleted RMAIL emails should have theit deleted flag reset

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > I argue that the 'deleted' flag should be reset when archiving the email
  > to the second mbox.

Ideally it would turn off the deleted flag
only in the copy that gets put in the other file.

However, if that is too hard,
turning it off in the current message itself before copying it
would be ok.


-- 
Dr Richard Stallman
President, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)
Skype: No way! See https://stallman.org/skype.html.

bug#31271: 25.2; exported deleted RMAIL emails should have theit deleted flag reset

[Eli Zaretskii]

> Date: Thu, 26 Apr 2018 14:27:04 +0200
> From: Francesco Potortì <pot@gnu.org>
> 
> In Rmail, suppose you want to archive your last received email to two
> different mboxes.  Then you 'o' to the first one, then 'o' to the second
> one.  After the first one, the email is marked as filed, deleted.
> 
> I argue that the 'deleted' flag should be reset when archiving the email
> to the second mbox.

Does the patch below give good results?  I didn't feel like changing
the default behavior, on account of it being so old, so I added an
option one can customize to get the new behavior.

What about invoking 'o' with a prefix argument -- should it stop
ignoring deleted messages when it looks for the N-1 additional
messages to output to a file, when this option is set non-nil?

diff --git a/lisp/mail/rmailout.el b/lisp/mail/rmailout.el
index eee8805..6d91ac5 100644
--- a/lisp/mail/rmailout.el
+++ b/lisp/mail/rmailout.el
@@ -56,6 +56,13 @@ rmail-fields-not-to-output
 		 regexp)
   :group 'rmail-output)
 
+(defcustom rmail-output-reset-deleted-flag nil
+  "Non-nil means reset the \"deleted\" flag when outputting a message to a file."
+  :type '(choice (const :tag "Output with the \"deleted\" flag reset" t)
+                 (const :tag "Output with the \"deleted\" flag intact" nil))
+  :version "27.1"
+  :group 'rmail-output)
+
 (defun rmail-output-read-file-name ()
   "Read the file name to use for `rmail-output'.
 Set `rmail-default-file' to this name as well as returning it.
@@ -533,8 +540,12 @@ rmail-output
       (if (zerop rmail-total-messages)
 	  (error "No messages to output"))
       (let ((orig-count count)
-	    beg end)
+	    beg end delete-attr-reset-p)
 	(while (> count 0)
+          (when (and rmail-output-reset-deleted-flag
+                     (rmail-message-deleted-p rmail-current-message))
+            (rmail-set-attribute rmail-deleted-attr-index nil)
+            (setq delete-attr-reset-p t))
 	  (setq beg (rmail-msgbeg rmail-current-message)
 		end (rmail-msgend rmail-current-message))
 	  ;; All access to the buffer's local variables is now finished...
@@ -549,6 +560,8 @@ rmail-output
 		(if babyl-format
 		    (rmail-output-as-babyl file-name noattribute)
 		  (rmail-output-as-mbox file-name noattribute)))))
+          (if delete-attr-reset-p
+              (rmail-set-attribute rmail-deleted-attr-index t))
 	  (or noattribute		; mark message as "filed"
 	      (rmail-set-attribute rmail-filed-attr-index t))
 	  (setq count (1- count))

bug#31271: 25.2; exported deleted RMAIL emails should have theit deleted flag reset

[Eli Zaretskii]

Ping!  I'd like to commit this change and close the bug, please
provide your feedback.

> Date: Sat, 19 May 2018 12:40:14 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 31271@debbugs.gnu.org
> 
> > Date: Thu, 26 Apr 2018 14:27:04 +0200
> > From: Francesco Potortì <pot@gnu.org>
> > 
> > In Rmail, suppose you want to archive your last received email to two
> > different mboxes.  Then you 'o' to the first one, then 'o' to the second
> > one.  After the first one, the email is marked as filed, deleted.
> > 
> > I argue that the 'deleted' flag should be reset when archiving the email
> > to the second mbox.
> 
> Does the patch below give good results?  I didn't feel like changing
> the default behavior, on account of it being so old, so I added an
> option one can customize to get the new behavior.
> 
> What about invoking 'o' with a prefix argument -- should it stop
> ignoring deleted messages when it looks for the N-1 additional
> messages to output to a file, when this option is set non-nil?
> 
> diff --git a/lisp/mail/rmailout.el b/lisp/mail/rmailout.el
> index eee8805..6d91ac5 100644
> --- a/lisp/mail/rmailout.el
> +++ b/lisp/mail/rmailout.el
> @@ -56,6 +56,13 @@ rmail-fields-not-to-output
>  		 regexp)
>    :group 'rmail-output)
>  
> +(defcustom rmail-output-reset-deleted-flag nil
> +  "Non-nil means reset the \"deleted\" flag when outputting a message to a file."
> +  :type '(choice (const :tag "Output with the \"deleted\" flag reset" t)
> +                 (const :tag "Output with the \"deleted\" flag intact" nil))
> +  :version "27.1"
> +  :group 'rmail-output)
> +
>  (defun rmail-output-read-file-name ()
>    "Read the file name to use for `rmail-output'.
>  Set `rmail-default-file' to this name as well as returning it.
> @@ -533,8 +540,12 @@ rmail-output
>        (if (zerop rmail-total-messages)
>  	  (error "No messages to output"))
>        (let ((orig-count count)
> -	    beg end)
> +	    beg end delete-attr-reset-p)
>  	(while (> count 0)
> +          (when (and rmail-output-reset-deleted-flag
> +                     (rmail-message-deleted-p rmail-current-message))
> +            (rmail-set-attribute rmail-deleted-attr-index nil)
> +            (setq delete-attr-reset-p t))
>  	  (setq beg (rmail-msgbeg rmail-current-message)
>  		end (rmail-msgend rmail-current-message))
>  	  ;; All access to the buffer's local variables is now finished...
> @@ -549,6 +560,8 @@ rmail-output
>  		(if babyl-format
>  		    (rmail-output-as-babyl file-name noattribute)
>  		  (rmail-output-as-mbox file-name noattribute)))))
> +          (if delete-attr-reset-p
> +              (rmail-set-attribute rmail-deleted-attr-index t))
>  	  (or noattribute		; mark message as "filed"
>  	      (rmail-set-attribute rmail-filed-attr-index t))
>  	  (setq count (1- count))
> 
> 
> 
> 

bug#31271: 25.2; exported deleted RMAIL emails should have theit deleted flag reset

[Francesco Potortì]

Sorry for the delay, I am submerged by work...

I just tried it and it seems to work, thanks.

I deleted an email,  I then output it to an mbox file which I was not
visiting.  Whan I opend it, the mail was there, and was not deleted.
Its flags are

 X-RMAIL-ATTRIBUTES: -----S--

But I don't know what it means.

bug#31271: 25.2; exported deleted RMAIL emails should have theit deleted flag reset

[Eli Zaretskii]

> Date: Mon, 04 Jun 2018 18:59:12 +0200
> From: Francesco Potortì <pot@gnu.org>
> Cc: 31271@debbugs.gnu.org
> 
> Sorry for the delay, I am submerged by work...

Happens to all of us.

> I just tried it and it seems to work, thanks.
> 
> I deleted an email,  I then output it to an mbox file which I was not
> visiting.  Whan I opend it, the mail was there, and was not deleted.
> Its flags are
> 
>  X-RMAIL-ATTRIBUTES: -----S--
> 
> But I don't know what it means.

That attribute means the message was forwarded.  See rmail-attr-array
and rmail-forwarded-attr-index.

What about the question I asked:

> What about invoking 'o' with a prefix argument -- should it stop
> ignoring deleted messages when it looks for the N-1 additional
> messages to output to a file, when this option is set non-nil?

The code I posted still ignores deleted messages, except for the
message that is current when the command is invoked.  Is that
reasonable?

Thanks.

bug#31271: 25.2; exported deleted RMAIL emails should have theit deleted flag reset

[Francesco Potortì]

>What about the question I asked:
>
>> What about invoking 'o' with a prefix argument -- should it stop
>> ignoring deleted messages when it looks for the N-1 additional
>> messages to output to a file, when this option is set non-nil?

Sorry, I had missed that one.

>The code I posted still ignores deleted messages, except for the
>message that is current when the command is invoked.  Is that
>reasonable?

I'd say it is reasonable, but I am not sure.

Suggestion: when the new option is set to t, RMAIL ignores the deleted
flag (that is, it goes through all messages, deleted or not) and asks
for confirmation for every deleted message it meets.  The archived
message has its deleted flag cleared.

This behaviour is not surprising, it is consistent, it does not break
old macros because you have to set the new option to t.

bug#31271: 25.2; exported deleted RMAIL emails should have theit deleted flag reset

[Eli Zaretskii]

> Date: Tue, 05 Jun 2018 18:13:47 +0200
> From: Francesco Potortì <pot@gnu.org>
> Cc: 31271@debbugs.gnu.org
> 
> >What about the question I asked:
> >
> >> What about invoking 'o' with a prefix argument -- should it stop
> >> ignoring deleted messages when it looks for the N-1 additional
> >> messages to output to a file, when this option is set non-nil?
> 
> Sorry, I had missed that one.
> 
> >The code I posted still ignores deleted messages, except for the
> >message that is current when the command is invoked.  Is that
> >reasonable?
> 
> I'd say it is reasonable, but I am not sure.
> 
> Suggestion: when the new option is set to t, RMAIL ignores the deleted
> flag (that is, it goes through all messages, deleted or not) and asks
> for confirmation for every deleted message it meets.  The archived
> message has its deleted flag cleared.
> 
> This behaviour is not surprising, it is consistent, it does not break
> old macros because you have to set the new option to t.

OK, done as suggested, and closing the bug report.

The change is on the master branch.