unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#25337: space after compile-command is a hack
@ 2017-01-02 21:39 積丹尼 Dan Jacobson
  2017-01-02 21:51 ` npostavs
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: 積丹尼 Dan Jacobson @ 2017-01-02 21:39 UTC (permalink / raw)
  To: 25337

compile-command is a variable defined in ‘compile.el’.
Its value is "make -k "

You know that trailing space is a hack and shouldn't need to be inserted
by the user.

E.g., I did
(setq compile-command "make")
and now I regret it... I'm now going to have to use
(setq compile-command "make ")





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#25337: space after compile-command is a hack
  2017-01-02 21:39 bug#25337: space after compile-command is a hack 積丹尼 Dan Jacobson
@ 2017-01-02 21:51 ` npostavs
  2017-01-02 21:58 ` 積丹尼 Dan Jacobson
  2017-01-02 23:22 ` 積丹尼 Dan Jacobson
  2 siblings, 0 replies; 8+ messages in thread
From: npostavs @ 2017-01-02 21:51 UTC (permalink / raw)
  To: 積丹尼 Dan Jacobson; +Cc: 25337

tags 25337 moreinfo
quit

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

> compile-command is a variable defined in ‘compile.el’.
> Its value is "make -k "
>
> You know that trailing space is a hack and shouldn't need to be inserted
> by the user.

I don't understand, the user *doesn't* need to insert it.  They can do
so if they wish...

>
> E.g., I did
> (setq compile-command "make")
> and now I regret it... I'm now going to have to use
> (setq compile-command "make ")

What do you want to be different?





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#25337: space after compile-command is a hack
  2017-01-02 21:39 bug#25337: space after compile-command is a hack 積丹尼 Dan Jacobson
  2017-01-02 21:51 ` npostavs
@ 2017-01-02 21:58 ` 積丹尼 Dan Jacobson
  2017-01-02 22:28   ` npostavs
  2017-01-02 23:22 ` 積丹尼 Dan Jacobson
  2 siblings, 1 reply; 8+ messages in thread
From: 積丹尼 Dan Jacobson @ 2017-01-02 21:58 UTC (permalink / raw)
  To: npostavs; +Cc: 25337

If one doesn't insert the space, then you have to add it each time,
else you will execute makea.out instead of make a.out.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#25337: space after compile-command is a hack
  2017-01-02 21:58 ` 積丹尼 Dan Jacobson
@ 2017-01-02 22:28   ` npostavs
  0 siblings, 0 replies; 8+ messages in thread
From: npostavs @ 2017-01-02 22:28 UTC (permalink / raw)
  To: 積丹尼 Dan Jacobson; +Cc: 25337

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

> If one doesn't insert the space, then you have to add it each time,
> else you will execute makea.out instead of make a.out.

So how do you want Emacs to behave differently?





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#25337: space after compile-command is a hack
  2017-01-02 21:39 bug#25337: space after compile-command is a hack 積丹尼 Dan Jacobson
  2017-01-02 21:51 ` npostavs
  2017-01-02 21:58 ` 積丹尼 Dan Jacobson
@ 2017-01-02 23:22 ` 積丹尼 Dan Jacobson
  2017-01-03  0:58   ` npostavs
  2 siblings, 1 reply; 8+ messages in thread
From: 積丹尼 Dan Jacobson @ 2017-01-02 23:22 UTC (permalink / raw)
  To: npostavs; +Cc: 25337

n> So how do you want Emacs to behave differently?

At least in the compile-command docstring mention "be sure to add a
space at the end."





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#25337: space after compile-command is a hack
  2017-01-02 23:22 ` 積丹尼 Dan Jacobson
@ 2017-01-03  0:58   ` npostavs
  2017-01-03 23:22     ` Richard Stallman
  0 siblings, 1 reply; 8+ messages in thread
From: npostavs @ 2017-01-03  0:58 UTC (permalink / raw)
  To: 積丹尼 Dan Jacobson; +Cc: 25337

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

> n> So how do you want Emacs to behave differently?
>
> At least in the compile-command docstring mention "be sure to add a
> space at the end."

I feel like this is redundant.  "If you want a space at the end of the
string, don't remove the space from the end of the string."  It could
apply to any variable.





^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#25337: space after compile-command is a hack
  2017-01-03  0:58   ` npostavs
@ 2017-01-03 23:22     ` Richard Stallman
  2017-01-08 17:15       ` npostavs
  0 siblings, 1 reply; 8+ messages in thread
From: Richard Stallman @ 2017-01-03 23:22 UTC (permalink / raw)
  To: npostavs; +Cc: jidanni, 25337

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > I feel like this is redundant.  "If you want a space at the end of the
  > string, don't remove the space from the end of the string."  It could
  > apply to any variable.

I suggest, "It is often useful to leave a space at the end of the
value."

-- 
Dr Richard Stallman
President, Free Software Foundation (gnu.org, fsf.org)
Internet Hall-of-Famer (internethalloffame.org)
Skype: No way! See stallman.org/skype.html.






^ permalink raw reply	[flat|nested] 8+ messages in thread

* bug#25337: space after compile-command is a hack
  2017-01-03 23:22     ` Richard Stallman
@ 2017-01-08 17:15       ` npostavs
  0 siblings, 0 replies; 8+ messages in thread
From: npostavs @ 2017-01-08 17:15 UTC (permalink / raw)
  To: Richard Stallman; +Cc: 25337, jidanni

tags 25337 = fixed
close 25337 25.2
quit

Richard Stallman <rms@gnu.org> writes:
>
> I suggest, "It is often useful to leave a space at the end of the
> value."

Looks reasonable, I've pushed a patch with that addition to emacs-25.

1: 2017-01-07 09:30:00 -0500 fc38671988d2d9c3ddb865bdc3a44e827fdb23ed
  Add helpful comment to compile-command's docstring





^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2017-01-08 17:15 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-02 21:39 bug#25337: space after compile-command is a hack 積丹尼 Dan Jacobson
2017-01-02 21:51 ` npostavs
2017-01-02 21:58 ` 積丹尼 Dan Jacobson
2017-01-02 22:28   ` npostavs
2017-01-02 23:22 ` 積丹尼 Dan Jacobson
2017-01-03  0:58   ` npostavs
2017-01-03 23:22     ` Richard Stallman
2017-01-08 17:15       ` npostavs

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).