From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#10592: Bug#655118: Please enabled hardened build flags Date: Wed, 25 Jan 2012 01:40:26 -0500 Message-ID: References: <20120108171359.6340.17517.reportbug@pisco.westfalen.local> <20120108180151.GA919@pisco.westfalen.local> <87wr8h8zhu.fsf@trouble.defaultvalue.org> <87pqe98zc9.fsf@trouble.defaultvalue.org> <8739b45xmr.fsf@trouble.defaultvalue.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1327473648 27678 80.91.229.12 (25 Jan 2012 06:40:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 25 Jan 2012 06:40:48 +0000 (UTC) Cc: 10592@debbugs.gnu.org, 655118-forwarded@bugs.debian.org, jmm@inutil.org, 655118@bugs.debian.org To: Rob Browning Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 25 07:40:43 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RpwXD-0007LU-2I for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Jan 2012 07:40:43 +0100 Original-Received: from localhost ([::1]:50382 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpwXC-00041L-A0 for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Jan 2012 01:40:42 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:45854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpwX9-000411-6Y for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2012 01:40:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RpwX8-0005KN-1y for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2012 01:40:39 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpwX8-0005KF-0H for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2012 01:40:38 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RpwXV-00016q-Oa for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2012 01:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jan 2012 06:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10592 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10592-submit@debbugs.gnu.org id=B10592.13274736564251 (code B ref 10592); Wed, 25 Jan 2012 06:41:01 +0000 Original-Received: (at 10592) by debbugs.gnu.org; 25 Jan 2012 06:40:56 +0000 Original-Received: from localhost ([127.0.0.1]:42478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RpwXP-00016U-LU for submit@debbugs.gnu.org; Wed, 25 Jan 2012 01:40:56 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:56208 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RpwXM-00016M-IF for 10592@debbugs.gnu.org; Wed, 25 Jan 2012 01:40:53 -0500 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RpwWw-0001pz-Oq; Wed, 25 Jan 2012 01:40:26 -0500 In-reply-to: <8739b45xmr.fsf@trouble.defaultvalue.org> (message from Rob Browning on Tue, 24 Jan 2012 20:22:52 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55974 Archived-At: > From: Rob Browning > Cc: 10592@debbugs.gnu.org, 655118@bugs.debian.org, 655118-forwarded@bugs.debian.org, jmm@inutil.org > Date: Tue, 24 Jan 2012 20:22:52 -0600 > > Eli Zaretskii writes: > > > I think the right fix for this is to declare `error' with the > > appropriate printf attribute. Alternatively, you could use variable > > argument lists and call vprintf instead. > > Would something like this be acceptable, and if not, how would you like > to see it adjusted? The patch changes error() to use an ANSI > declaration, and it relies on the printf format attribute: This is fine with me, but please use ATTRIBUTE_FORMAT_PRINTF (defined in src/config.h) instead of a literal __attribute__(...), which is a GCC-only thing. Thanks.