unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Rob Browning <rlb@defaultvalue.org>
Cc: 10592@debbugs.gnu.org, 655118-forwarded@bugs.debian.org,
	jmm@inutil.org, 655118@bugs.debian.org
Subject: bug#10592: Bug#655118: Please enabled hardened build flags
Date: Wed, 25 Jan 2012 01:40:26 -0500	[thread overview]
Message-ID: <E1RpwWw-0001pz-Oq@fencepost.gnu.org> (raw)
In-Reply-To: <8739b45xmr.fsf@trouble.defaultvalue.org> (message from Rob Browning on Tue, 24 Jan 2012 20:22:52 -0600)

> From: Rob Browning <rlb@defaultvalue.org>
> Cc: 10592@debbugs.gnu.org,  655118@bugs.debian.org,  655118-forwarded@bugs.debian.org,  jmm@inutil.org
> Date: Tue, 24 Jan 2012 20:22:52 -0600
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > I think the right fix for this is to declare `error' with the
> > appropriate printf attribute.  Alternatively, you could use variable
> > argument lists and call vprintf instead.
> 
> Would something like this be acceptable, and if not, how would you like
> to see it adjusted?  The patch changes error() to use an ANSI
> declaration, and it relies on the printf format attribute:

This is fine with me, but please use ATTRIBUTE_FORMAT_PRINTF (defined
in src/config.h) instead of a literal __attribute__(...), which is a
GCC-only thing.

Thanks.





  reply	other threads:[~2012-01-25  6:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120108171359.6340.17517.reportbug@pisco.westfalen.local>
     [not found] ` <20120108180151.GA919@pisco.westfalen.local>
2012-01-24  5:02   ` bug#10591: Bug#655118: Please enabled hardened build flags Rob Browning
2012-01-24  5:05     ` bug#10592: " Rob Browning
2012-01-24  6:06       ` Eli Zaretskii
2012-01-24 16:17         ` Rob Browning
2012-01-25  2:22         ` Rob Browning
2012-01-25  6:40           ` Eli Zaretskii [this message]
2012-01-26  3:13             ` Rob Browning
2012-01-26  3:25               ` Rob Browning
2012-01-31  4:22       ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1RpwWw-0001pz-Oq@fencepost.gnu.org \
    --to=eliz@gnu.org \
    --cc=10592@debbugs.gnu.org \
    --cc=655118-forwarded@bugs.debian.org \
    --cc=655118@bugs.debian.org \
    --cc=jmm@inutil.org \
    --cc=rlb@defaultvalue.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).