From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#10592: Bug#655118: Please enabled hardened build flags Date: Tue, 24 Jan 2012 01:06:40 -0500 Message-ID: References: <20120108171359.6340.17517.reportbug@pisco.westfalen.local> <20120108180151.GA919@pisco.westfalen.local> <87wr8h8zhu.fsf@trouble.defaultvalue.org> <87pqe98zc9.fsf@trouble.defaultvalue.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1327385276 24344 80.91.229.12 (24 Jan 2012 06:07:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 24 Jan 2012 06:07:56 +0000 (UTC) Cc: 10592@debbugs.gnu.org, 655118-forwarded@bugs.debian.org, jmm@inutil.org, 655118@bugs.debian.org To: Rob Browning Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 24 07:07:51 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RpZXq-0005Qs-3j for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Jan 2012 07:07:50 +0100 Original-Received: from localhost ([::1]:34229 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpZXp-0003Oe-5O for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Jan 2012 01:07:49 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:48617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpZXl-0003OW-TD for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2012 01:07:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RpZXk-0004uX-Ve for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2012 01:07:45 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpZXk-0004uS-PO for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2012 01:07:44 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RpZY2-0005VJ-Eb for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2012 01:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Jan 2012 06:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10592 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10592-submit@debbugs.gnu.org id=B10592.132738522321001 (code B ref 10592); Tue, 24 Jan 2012 06:08:02 +0000 Original-Received: (at 10592) by debbugs.gnu.org; 24 Jan 2012 06:07:03 +0000 Original-Received: from localhost ([127.0.0.1]:41260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RpZX4-0005ST-A5 for submit@debbugs.gnu.org; Tue, 24 Jan 2012 01:07:02 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:60524 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RpZX1-0005S7-Rk for 10592@debbugs.gnu.org; Tue, 24 Jan 2012 01:07:01 -0500 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RpZWi-0006sb-8K; Tue, 24 Jan 2012 01:06:40 -0500 In-reply-to: <87pqe98zc9.fsf@trouble.defaultvalue.org> (message from Rob Browning on Mon, 23 Jan 2012 23:05:26 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55946 Archived-At: > From: Rob Browning > Date: Mon, 23 Jan 2012 23:05:26 -0600 > Cc: 655118@bugs.debian.org, 655118-forwarded@bugs.debian.org, > Moritz Mühlenhoff > > --- emacs23-23.3+1.orig/lib-src/movemail.c 2011-12-29 05:07:27.000000000 +0100 > +++ emacs23-23.3+1/lib-src/movemail.c 2012-01-08 17:31:22.000000000 +0100 > @@ -615,11 +615,11 @@ > { > fprintf (stderr, "movemail: "); > if (s3) > - fprintf (stderr, s1, s2, s3); > + fprintf (stderr, "%s%s%s", s1, s2, s3); > else if (s2) > - fprintf (stderr, s1, s2); > + fprintf (stderr, "%s%s", s1, s2); > else > - fprintf (stderr, s1); > + fprintf (stderr, "%s", s1); > fprintf (stderr, "\n"); > } How can this possibly be TRT? The commentary to this function says: /* Print error message. `s1' is printf control string, `s2' and `s3' are args for it or null. */ If S1 is the printf control string, how will printing it with %s DTRT? E.g., in this invocation: error ("Error connecting to POP server: %s", pop_error, 0); or in this one: error ("Error in open: %s, %s", strerror (errno), outfile); I think the right fix for this is to declare `error' with the appropriate printf attribute. Alternatively, you could use variable argument lists and call vprintf instead.