From: Eli Zaretskii <eliz@gnu.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 9722@debbugs.gnu.org
Subject: bug#9722: list-colors-duplicates does not exclude enough colors on Windows
Date: Tue, 11 Oct 2011 02:01:33 -0400 [thread overview]
Message-ID: <E1RDVPB-0000HK-FA@fencepost.gnu.org> (raw)
In-Reply-To: <CAAeL0STtGorq8+53c=Qu-4K2x0xWX0-Wm_mmSDarhpo4Bqgj8Q@mail.gmail.com> (message from Juanma Barranquero on Tue, 11 Oct 2011 00:49:43 +0200)
> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Tue, 11 Oct 2011 00:49:43 +0200
>
> On Windows, `list-colors-duplicates' matches the color name against
> the output of `w32-default-color-map', to avoid conflating colors
> which are RGB-equal, but semantically different, like SystemMenuText
> and SystemWindowText.
>
> Unfortunately, that makes colors not in that list different even if
> they are not, in particular all the grayNN/greyNN pairs.
The duplicates annoyed me as well; thanks for taking care of it.
However, there's something I'm missing here: why doesn't
list-colors-duplicates recognize grayNN and greyNN as duplicates?
We don't have them in the list that w32-default-color-map returns.
As for duplicates such as "Dark Slate Gray" and "Dark Slate Grey",
which are not filtered out because they _are_ in
w32-default-color-map, would something break if we modify the list
returned by that function to not include any duplicates in the first
place?
next prev parent reply other threads:[~2011-10-11 6:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 22:49 bug#9722: list-colors-duplicates does not exclude enough colors on Windows Juanma Barranquero
2011-10-11 6:01 ` Eli Zaretskii [this message]
2011-10-11 11:24 ` Juanma Barranquero
2011-10-11 19:39 ` Eli Zaretskii
2011-10-11 20:54 ` Juanma Barranquero
2011-10-17 12:00 ` Juanma Barranquero
2011-10-17 16:41 ` Eli Zaretskii
2011-10-17 16:55 ` Juanma Barranquero
2011-10-17 17:15 ` Eli Zaretskii
2011-10-18 14:50 ` Juanma Barranquero
[not found] ` <83obxeuwa8.fsf@gnu.org>
[not found] ` <CAAeL0SRRkqY2r6QwASsb1JVdeSfTd9UDz3RY5QTx-PHME2iZsQ@mail.gmail.com>
[not found] ` <83k482ut21.fsf@gnu.org>
2011-10-18 19:25 ` Juanma Barranquero
2011-10-18 21:01 ` Eli Zaretskii
2011-10-24 19:29 ` Juanma Barranquero
2011-10-19 8:20 ` Juri Linkov
2011-10-19 8:36 ` Eli Zaretskii
2011-10-19 8:57 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1RDVPB-0000HK-FA@fencepost.gnu.org \
--to=eliz@gnu.org \
--cc=9722@debbugs.gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).