From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#7848: 23.2.91; Can't build with MinGW Date: Sun, 16 Jan 2011 05:03:54 -0500 Message-ID: References: <20110115073410.74410360038@msa102.auone-net.jp> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1295173491 12117 80.91.229.12 (16 Jan 2011 10:24:51 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 16 Jan 2011 10:24:51 +0000 (UTC) Cc: kzhr@d1.dion.ne.jp, 7848@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jan 16 11:24:47 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PePmw-00057F-Vy for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Jan 2011 11:24:47 +0100 Original-Received: from localhost ([127.0.0.1]:41934 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PePmv-000258-SQ for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Jan 2011 05:24:46 -0500 Original-Received: from [140.186.70.92] (port=40034 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PePmf-00023k-Ow for bug-gnu-emacs@gnu.org; Sun, 16 Jan 2011 05:24:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PePme-0002V1-9a for bug-gnu-emacs@gnu.org; Sun, 16 Jan 2011 05:24:29 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PePme-0002Ux-85 for bug-gnu-emacs@gnu.org; Sun, 16 Jan 2011 05:24:28 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PePM5-0003yS-Qg; Sun, 16 Jan 2011 04:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jan 2011 09:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7848 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7848-submit@debbugs.gnu.org id=B7848.129517178015229 (code B ref 7848); Sun, 16 Jan 2011 09:57:01 +0000 Original-Received: (at 7848) by debbugs.gnu.org; 16 Jan 2011 09:56:20 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PePLQ-0003xa-AE for submit@debbugs.gnu.org; Sun, 16 Jan 2011 04:56:20 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PePLN-0003xO-K7 for 7848@debbugs.gnu.org; Sun, 16 Jan 2011 04:56:18 -0500 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1PePSk-0005gL-5l; Sun, 16 Jan 2011 05:03:54 -0500 In-reply-to: (message from Stefan Monnier on Sat, 15 Jan 2011 23:41:51 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 16 Jan 2011 04:57:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:43397 Archived-At: > From: Stefan Monnier > Cc: Kazuhiro Ito , 7848@debbugs.gnu.org > Date: Sat, 15 Jan 2011 23:41:51 -0500 > > > Sorry. Please try replacing this: > > > SET_SYMBOL_VAL (XSYMBOL (Qlibpng_version), make_number (PNG_LIBPNG_VER)); > [...] > > XSYMBOL (Qlibpng_version)->value = make_number (PNG_LIBPNG_VER); > > I would recommend to stay away from such low-level code unless you're > writing code that tries to implement part of the binding-semantics > of Emacs. I.e. just use Fset. Using Fset here would be a terrible overkill, IMO. I'm not even sure I understand all of its semantics, and not sure it will work correctly in the context of an init_* function that is called when Emacs is dumped. OTOH, direct assignments of symbol's value like above _are_ used in several init_* functions and elsewhere. Also, I wanted to un-break the release branch as fast as I could. Having said all that, feel free to change what I did to use Fset, both on the branch and on the trunk.