unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Kazuhiro Ito <kzhr@d1.dion.ne.jp>
Cc: 7848@debbugs.gnu.org
Subject: bug#7848: 23.2.91; Can't build with MinGW
Date: Sat, 15 Jan 2011 19:41:04 -0500	[thread overview]
Message-ID: <E1PeGg4-00041q-K7@fencepost.gnu.org> (raw)
In-Reply-To: <20110115073410.74410360038@msa102.auone-net.jp> (message from Kazuhiro Ito on Sat, 15 Jan 2011 16:34:08 +0900)

> Date: Sat, 15 Jan 2011 16:34:08 +0900
> From: Kazuhiro Ito <kzhr@d1.dion.ne.jp>
> Cc: 
> 
> When I build emacs-23 branch at present with MinGW, below error
> occurs while linking.
> 
> > oo-spd/i386/temacs1.a(image.o):image.c:(.text+0xa8fa): undefined reference to `SET_SYMBOL_VAL'
> > collect2: ld returned 1 exit status
> > make[1]: *** [oo-spd/i386/temacs.exe] Error 1
> > make[1]: Leaving directory `/f/build/emacs-23/src'
> > make: *** [all-other-dirs-gmake] Error 2
> 
> SET_SYMBOL_VAL is defined in src/lisp.h on trunk but not on emacs-23
> branch.

Sorry.  Please try replacing this:

  SET_SYMBOL_VAL (XSYMBOL (Qlibpng_version), make_number (PNG_LIBPNG_VER));

with this:

  XSYMBOL (Qlibpng_version)->value = make_number (PNG_LIBPNG_VER);

and make a similar change in this line:

  SET_SYMBOL_VAL (XSYMBOL (Qlibpng_version), make_number (-1));

I cannot test this where I'm typing this mail, but if you tell me that
these two changes fix the problem, I will commit this change to the
release branch.





  reply	other threads:[~2011-01-16  0:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-15  7:34 bug#7848: 23.2.91; Can't build with MinGW Kazuhiro Ito
2011-01-16  0:41 ` Eli Zaretskii [this message]
2011-01-16  4:41   ` Stefan Monnier
2011-01-16 10:03     ` Eli Zaretskii
2011-01-16 15:21       ` Stefan Monnier
2011-01-16 15:58         ` Eli Zaretskii
2011-01-16  6:16   ` Kazuhiro Ito
2011-01-16  9:57     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1PeGg4-00041q-K7@fencepost.gnu.org \
    --to=eliz@gnu.org \
    --cc=7848@debbugs.gnu.org \
    --cc=kzhr@d1.dion.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).