From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#7307: 24.0.50; Mode line had more than just dashes removed Date: Tue, 02 Nov 2010 01:35:20 -0400 Message-ID: References: <871v78mwg3.fsf@escher.home> <831v786un1.fsf@gnu.org> <87wrozbykb.fsf@escher.home> <87iq0g6hi2.fsf@escher.home> <83lj5c6ds3.fsf@gnu.org> <87bp6862iq.fsf@escher.home> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1288676805 14601 80.91.229.12 (2 Nov 2010 05:46:45 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 2 Nov 2010 05:46:45 +0000 (UTC) Cc: 7307@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 02 06:46:40 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PD9hf-0005sa-P3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Nov 2010 06:46:40 +0100 Original-Received: from localhost ([127.0.0.1]:60589 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PD9hf-0003YG-3m for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Nov 2010 01:46:39 -0400 Original-Received: from [140.186.70.92] (port=53919 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PD9eU-0002aJ-Bq for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2010 01:43:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PD9eT-0003qr-7o for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2010 01:43:22 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PD9eT-0003qn-6H for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2010 01:43:21 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PD9TV-0003ny-PO; Tue, 02 Nov 2010 01:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Nov 2010 05:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7307 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7307-submit@debbugs.gnu.org id=B7307.128867586114605 (code B ref 7307); Tue, 02 Nov 2010 05:32:01 +0000 Original-Received: (at 7307) by debbugs.gnu.org; 2 Nov 2010 05:31:01 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PD9SX-0003nW-KQ for submit@debbugs.gnu.org; Tue, 02 Nov 2010 01:31:01 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PD9SV-0003nK-Pi for 7307@debbugs.gnu.org; Tue, 02 Nov 2010 01:31:00 -0400 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1PD9Wi-00087W-7g; Tue, 02 Nov 2010 01:35:20 -0400 In-reply-to: <87bp6862iq.fsf@escher.home> (message from Stephen Berman on Tue, 02 Nov 2010 00:35:25 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 02 Nov 2010 01:32:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41362 Archived-At: > From: Stephen Berman > Cc: 7307@debbugs.gnu.org > Date: Tue, 02 Nov 2010 00:35:25 +0100 > > On Mon, 01 Nov 2010 21:32:12 +0200 Eli Zaretskii wrote: > > >> From: Stephen Berman > >> Date: Mon, 01 Nov 2010 19:11:49 +0100 > >> Cc: 7307@debbugs.gnu.org > >> > >> + mode_line_filler = !NILP (Fwindow_system (Qnil)) ? lots_of_spaces > >> + : lots_of_dashes; > > > > Actually, you want to use `FRAME_WINDOW_P (f)' here. It does exactly > > what you mean, but with much smaller overhead (for starters, it > > doesn't call Lisp). > > Thanks. (I copied Fwindow_system, with the accompanying "This is wrong" > comment, from keyboard.c; I wonder why `FRAME_WINDOW_P (f)' isn't used > there.) Indeed. Chong, this is your change: 2010-08-31 Chong Yidong * keyboard.c (command_loop_1): Don't call x-set-selection on tty. Can you tell why you didn't use FRAME_WINDOW_P? Am I missing some subtlety?