bug#6828: 24.0.50; [PATCH] rcirc process buffer log filenames invalid on Windows

bug#6828: 24.0.50; [PATCH] rcirc process buffer log filenames invalid on Windows

[Deniz Dogan]

[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]

The rcirc logging facility doesn't play nicely when it comes to
writing process buffers (or "server buffers") to disk on Windows
systems. The generated log filenames contain asterisks which are not
allowed on Windows systems. This makes rcirc and Emacs as a whole
unusable when rcirc-log-flag is non-nil, i.e. when logging to disk is
turned on. Emacs just messages errors in the echo area when this
happens and you can't easily stop it.

Attached is a patch which introduces a new function and a new
customizable variable.

rcirc-generate-log-filename is the function which takes care of
generating filenames for rcirc buffer logs. It is now the default
instead of the old rcirc-generate-new-buffer-name.

rcirc-log-process-buffers is the new variable which decides whether or
not to log process buffers to disk at all. I get the feeling that not
that many people are interested in logging this as it rarely contains
any useful information that you would want to store. Nevertheless, the
variable is non-nil by default which turns on process buffer logging.

The setup I'm using by the way:

In GNU Emacs 24.0.50.1 (i386-mingw-nt6.1.7600)
 of 2010-08-02 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 6.1.7600
configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/xpm/include'

-- 
Deniz Dogan

[-- Attachment #2: rcirc-log-patch-dd.diff --]
[-- Type: application/octet-stream, Size: 778 bytes --]

1510,1511c1510,1513
<       (when rcirc-log-flag
<         (rcirc-log process sender response target text))
---
>       (when (and rcirc-log-flag
>                    (or target
>                        rcirc-log-process-buffers))
>           (rcirc-log process sender response target text))
1517c1519,1529
< (defcustom rcirc-log-filename-function 'rcirc-generate-new-buffer-name
---
> (defun rcirc-generate-log-filename (process target)
>   (if target
>       (rcirc-generate-new-buffer-name process target)
>     (process-name process)))
>
> (defcustom rcirc-log-process-buffers t
>   "Non-nil if rcirc process buffers should be logged to disk."
>   :group 'rcirc
>   :type 'boolean)
>
> (defcustom rcirc-log-filename-function 'rcirc-generate-log-filename

bug#6828: 24.0.50; [PATCH] rcirc process buffer log filenames invalid on Windows

[Chong Yidong]

Hi Ryan,

Could you review the patch at

  http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6828

?  Thanks.

bug#6828: (no subject)

[Ryan Yeske]

From: Ryan Yeske <rcyeske@gmail.com>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 6828@debbugs.gnu.org
Subject: Re: 24.0.50; [PATCH] rcirc process buffer log filenames invalid on Windows
References: <87d3tk7pzy.fsf@stupidchicken.com>
Date: Sun, 15 Aug 2010 20:26:52 -0700
In-Reply-To: <87d3tk7pzy.fsf@stupidchicken.com> (Chong Yidong's message of
	"Sat, 14 Aug 2010 19:07:13 -0400")
Message-ID: <878w47s0eb.fsf@gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

These are good changes.  

I agree with Deniz that logging the process buffer is hardly ever
desirable, so I suggest `rcirc-log-process-buffers' should be nil by
default.

Ryan

Chong Yidong <cyd@stupidchicken.com> writes:

> Hi Ryan,
>
> Could you review the patch at
>
>   http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6828
>
> ?  Thanks.

bug#6828: 24.0.50; [PATCH] rcirc process buffer log filenames invalid on Windows

[Chong Yidong]

Ryan Yeske <rcyeske@gmail.com> writes:

> These are good changes.
>
> I agree with Deniz that logging the process buffer is hardly ever
> desirable, so I suggest `rcirc-log-process-buffers' should be nil by
> default.

OK.  I've checked the patch into the trunk, with
rcirc-log-process-buffers defaulting to nil.  Thanks.