From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.bugs Subject: bug#2435: Bug 2435 Date: Fri, 06 Mar 2009 12:38:07 +0900 Message-ID: References: <87fxhvcmvf.fsf@cyd.mit.edu> <87zlg2a7b9.fsf@cyd.mit.edu> <87ab81293z.fsf@cyd.mit.edu> <877i34shq2.fsf@cyd.mit.edu> Reply-To: Kenichi Handa , 2435@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1236312293 4695 80.91.229.12 (6 Mar 2009 04:04:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 6 Mar 2009 04:04:53 +0000 (UTC) Cc: cyd@stupidchicken.com, 2435@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 06 05:06:08 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LfRJD-0006hQ-Gk for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Mar 2009 05:05:43 +0100 Original-Received: from localhost ([127.0.0.1]:48314 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LfRHr-0003NV-I5 for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Mar 2009 23:03:51 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LfRHn-0003NG-1g for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2009 23:03:47 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LfRHl-0003MN-6C for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2009 23:03:45 -0500 Original-Received: from [199.232.76.173] (port=46918 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LfRHl-0003MI-3r for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2009 23:03:45 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42564) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LfRHj-0004QO-Oc for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2009 23:03:44 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2643dpx000488; Thu, 5 Mar 2009 20:03:40 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n263j207028078; Thu, 5 Mar 2009 19:45:02 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Kenichi Handa Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 06 Mar 2009 03:45:02 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2435 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2435-submit@emacsbugs.donarmstrong.com id=B2435.123631065126774 (code B ref 2435); Fri, 06 Mar 2009 03:45:02 +0000 Original-Received: (at 2435) by emacsbugs.donarmstrong.com; 6 Mar 2009 03:37:31 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mx1.aist.go.jp (mx1.aist.go.jp [150.29.246.133]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n263bOGT026766 for <2435@emacsbugs.donarmstrong.com>; Thu, 5 Mar 2009 19:37:26 -0800 Original-Received: from rqsmtp1.aist.go.jp (rqsmtp1.aist.go.jp [150.29.254.115]) by mx1.aist.go.jp with ESMTP id n263bME9014040; Fri, 6 Mar 2009 12:37:22 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp3.aist.go.jp by rqsmtp1.aist.go.jp with ESMTP id n263bMnI006046; Fri, 6 Mar 2009 12:37:22 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp3.aist.go.jp with ESMTP id n263bMdu021187; Fri, 6 Mar 2009 12:37:22 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken with local (Exim 4.69) (envelope-from ) id 1LfQsx-00076s-69; Fri, 06 Mar 2009 12:38:07 +0900 In-reply-to: (message from Stefan Monnier on Thu, 05 Mar 2009 11:46:39 -0500) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 05 Mar 2009 23:03:45 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26028 Archived-At: In article , Stefan Monnier writes: > > It will fix the current problem of bufp contents being > > changed by recursive call, but we still have a danger of > > Lisp code being called in re_compile_pattern, which may lead > > to relocation of string data pointed by the arg "pattern". > > So, I think we must avoid any Lisp calls within > > re_compile_pattern. > Indeed, tho it's not clear how we could do that. One way that occurs to > me is: if we need to `load' or do some such dangerous operation in > re_compile_pattern, signal an error so we exit re_compile_pattern. > Then catch this error in the calling code where we can do the > corresponding operation safely and call re_compile_pattern again. > Kind of ugly, but for autoload-style operations it seems acceptable. We should take care of re_search_2 and re_match_2_internal too. If the problem is only the call of openp in load_charset_map_from_file, and building various Lisp object is ok, we can change load_charset_map_from_file to open a charset map by itself without using openp. --- Kenichi Handa handa@m17n.org