unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard M Stallman <rms@gnu.org>
To: Glenn Morris <rgm@gnu.org>
Cc: 2228@emacsbugs.donarmstrong.com
Subject: bug#2228: 23.0.90; rmail-cease-edit ignores changes to the message headers
Date: Wed, 11 Feb 2009 01:22:50 -0500	[thread overview]
Message-ID: <E1LX8Uk-0005hc-GK@fencepost.gnu.org> (raw)
In-Reply-To: <srk57zhsg9.fsf@fencepost.gnu.org> (message from Glenn Morris on Mon, 09 Feb 2009 22:38:30 -0500)

    > As it is now, you get the choice.  If you display the full headers and
    > then edit, then you get to edit the full headers.

    With the minor drawback that it doesn't actually work, hence this bug report.

It works fine for the usual job, editing the message body.
Making it work for editing headers probably takes 200 lines of code.

    rmailedit as a whole seems overly complex to me. If I were doing it,
    I'd copy the expanded message text to a new buffer for editing, rather
    than re-using the rmail buffer. Aborting an edit would just kill the
    buffer. Saving an edit would compare the buffer text with the region
    between msgbeg and msgend in rmail-view-buffer, and swap it in if it
    differed, then call rmail-show-message.

I would not object to switching to that approach, but still it shouldn't
normally show all the unpruned headers.







  parent reply	other threads:[~2009-02-11  6:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-07 15:30 bug#2228: 23.0.90; rmail-cease-edit ignores changes to the message headers Eli Zaretskii
2009-02-08  1:20 ` Richard M Stallman
2009-02-08 20:43   ` Glenn Morris
2009-02-09 20:38     ` Eli Zaretskii
2009-02-09 20:48       ` Glenn Morris
2009-02-10 20:02         ` Richard M Stallman
2009-02-10 20:27           ` Eli Zaretskii
2009-02-11  6:22             ` Richard M Stallman
2009-02-11 20:22               ` Eli Zaretskii
2009-02-18  4:39                 ` Glenn Morris
2009-02-18  4:50                   ` Processed: " Emacs bug Tracking System
2009-02-18 18:48                   ` Eli Zaretskii
2009-02-21 11:42                   ` Eli Zaretskii
2009-02-10  0:11     ` Richard M Stallman
2009-02-10  3:38       ` Glenn Morris
2009-02-10  8:56         ` Eli Zaretskii
2009-02-11  6:22         ` Richard M Stallman [this message]
2009-02-11 20:52           ` Glenn Morris
2009-02-12  2:35             ` Stefan Monnier
2009-02-12  2:36               ` Glenn Morris
2009-02-12  8:21                 ` Glenn Morris
2009-02-12 13:47             ` Richard M Stallman
2009-02-12 17:44               ` Glenn Morris
2009-02-12 18:25                 ` Glenn Morris
2009-02-13  6:32                 ` Richard M Stallman
2009-02-10  8:40       ` Eli Zaretskii
2009-02-11  1:48         ` Stefan Monnier
  -- strict thread matches above, loose matches on Subject: below --
2009-02-19  0:24 Xavier Maillard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1LX8Uk-0005hc-GK@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=2228@emacsbugs.donarmstrong.com \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).