From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard M Stallman Newsgroups: gmane.emacs.bugs Subject: bug#2137: 23.0.60; Saving Rmail buffer does not show the "Saving file ..." message Date: Wed, 04 Feb 2009 13:27:49 -0500 Message-ID: References: Reply-To: rms@gnu.org, 2137@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: ger.gmane.org 1233773223 14160 80.91.229.12 (4 Feb 2009 18:47:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Feb 2009 18:47:03 +0000 (UTC) Cc: 2137@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 04 19:48:17 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LUmnF-0008Nz-Kq for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Feb 2009 19:48:14 +0100 Original-Received: from localhost ([127.0.0.1]:46771 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUmlw-0002Jy-Pj for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Feb 2009 13:46:52 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LUmio-0000rv-3Z for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2009 13:43:38 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LUmil-0000rH-VU for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2009 13:43:36 -0500 Original-Received: from [199.232.76.173] (port=41727 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUmil-0000r5-JX for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2009 13:43:35 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42855) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LUmik-0000hu-Bz for bug-gnu-emacs@gnu.org; Wed, 04 Feb 2009 13:43:34 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n14IhVXG004923; Wed, 4 Feb 2009 10:43:32 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n14IZ4Ux002671; Wed, 4 Feb 2009 10:35:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Richard M Stallman Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , Rmail Maintainers Resent-Date: Wed, 04 Feb 2009 18:35:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2137 X-Emacs-PR-Package: emacs,rmail X-Emacs-PR-Keywords: Original-Received: via spool by 2137-submit@emacsbugs.donarmstrong.com id=B2137.12337721821293 (code B ref 2137); Wed, 04 Feb 2009 18:35:04 +0000 Original-Received: (at 2137) by emacsbugs.donarmstrong.com; 4 Feb 2009 18:29:42 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n14ITdh2001286 for <2137@emacsbugs.donarmstrong.com>; Wed, 4 Feb 2009 10:29:40 -0800 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LUmTV-0000Gb-QB; Wed, 04 Feb 2009 13:27:49 -0500 In-reply-to: (message from Stefan Monnier on Tue, 03 Feb 2009 16:26:21 -0500) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 04 Feb 2009 13:43:36 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24947 Archived-At: > IMO, using annotations for the job of saving the mailbox is also a > horrible kludge. All that just to avoid defining an Rmail-specific > binding for C-x C-s ... Thanks for your support, An Rmail-specific binding for C-x C-s is not enough to make saving work correctly. Users can save the file through C-x s also, and other commands too. The common mechanism for these commands is `save-buffer'; whatever makes them save the right text has to work inside there. Eli wrote: we could add to rmail-write-region-annotate another hack: a call to buffer-size followed by the same message "Saving file ..." that should have been displayed by save-buffer. The difficulty here is to display that message only in the case where the hook was ultimately called from `save-buffer'. This could be done by making `save-buffer' bind some variable for such hooks to check. However, such fixes are less clean that implementing `buffer-swapped-with' and checking it in the necessary places. I previously implemented it in `basic-save-buffer', but just moving the implementation to `save-buffer' would make it DTRT for this. The fix would add no complexity. The simplest fix is to simply always output the message rather than only for files larger than 50KB. That would be easy, but not quite the most convenient behavior. The more difficult one is to move the message from save-buffer to write-region.