From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.bugs Subject: bug#122: 23.0.60; Slowdown in directory scanning over time. Date: Tue, 16 Sep 2008 10:27:43 +0900 Message-ID: References: <87r68bwgu9.fsf@cyd.mit.edu> Reply-To: Kenichi Handa , 122@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1221529672 24415 80.91.229.12 (16 Sep 2008 01:47:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Sep 2008 01:47:52 +0000 (UTC) Cc: 122@emacsbugs.donarmstrong.com, cyd@stupidchicken.com, bug-submit-list@donarmstrong.com, lenbok@gmail.com, bug-gnu-emacs@gnu.org To: rms@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 16 03:48:47 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KfPgM-0000jc-53 for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Sep 2008 03:48:46 +0200 Original-Received: from localhost ([127.0.0.1]:43519 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KfPfL-0002oH-Di for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Sep 2008 21:47:43 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KfPfH-0002nR-4E for bug-gnu-emacs@gnu.org; Mon, 15 Sep 2008 21:47:39 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KfPfF-0002mt-63 for bug-gnu-emacs@gnu.org; Mon, 15 Sep 2008 21:47:38 -0400 Original-Received: from [199.232.76.173] (port=39224 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KfPfF-0002mo-26 for bug-gnu-emacs@gnu.org; Mon, 15 Sep 2008 21:47:37 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:45558) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KfPfE-0007dP-CG for bug-gnu-emacs@gnu.org; Mon, 15 Sep 2008 21:47:36 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8G1lYcX007552; Mon, 15 Sep 2008 18:47:34 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m8G1Z4HH002759; Mon, 15 Sep 2008 18:35:04 -0700 X-Loop: don@donarmstrong.com Resent-From: Kenichi Handa Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 16 Sep 2008 01:35:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 122 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 122-submit@emacsbugs.donarmstrong.com id=B122.1221528473562 (code B ref 122); Tue, 16 Sep 2008 01:35:04 +0000 Original-Received: (at 122) by emacsbugs.donarmstrong.com; 16 Sep 2008 01:27:53 +0000 Original-Received: from mx1.aist.go.jp (mx1.aist.go.jp [150.29.246.133]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8G1Rn85000556 for <122@emacsbugs.donarmstrong.com>; Mon, 15 Sep 2008 18:27:51 -0700 Original-Received: from rqsmtp1.aist.go.jp (rqsmtp1.aist.go.jp [150.29.254.115]) by mx1.aist.go.jp with ESMTP id m8G1Rhv0029355; Tue, 16 Sep 2008 10:27:43 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp3.aist.go.jp by rqsmtp1.aist.go.jp with ESMTP id m8G1RhIv027168; Tue, 16 Sep 2008 10:27:43 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp3.aist.go.jp with ESMTP id m8G1RhsL006537; Tue, 16 Sep 2008 10:27:43 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken.m17n.org with local (Exim 4.69) (envelope-from ) id 1KfPLz-00037c-9H; Tue, 16 Sep 2008 10:27:43 +0900 In-reply-to: (rms@gnu.org) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 15 Sep 2008 21:47:38 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:20557 Archived-At: In article , "Richard M. Stallman" writes: > The code looks inefficient too. Even when it reuses the > code-conversion buffer, it calls Fget_buffer_create. > It seems to be killing and recreating these buffers, > which must be slow. > ??? I don't see what's wrong with the current code. I > think the functions make_conversion_work_buffer, > code_conversion_save, and code_conversion_restore do the > right thing. > They do the right thing, but it looks like they do it inefficiently. I've just modified the current code to avoid calling Fget_buffer_create when we alreay have Vcode_conversion_reused_workbuf. But, I think it doens't influence the efficiency that much because Fget_buffer_create doesn't create a new buffer if a buffer of the specified name already exists. I think the current problem of slowness was fixed by a fix of Finsert_file_contents as in my previous mail. --- Kenichi Handa handa@ni.aist.go.jp