bug#481: Crashes with non-default language environments

bug#481: Crashes with non-default language environments

[Kenichi Handa]

This is the thread of long ago.

In article <jwvk5lab0qd.fsf-monnier+emacs@gnu.org>, Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> > But, even if we implement string-to-unibyte, it should be
> > used for a string containing only ascii and eight-bit chars.
> > And in that case, string-make-unibyte behaves exactly the
> > same as string-to-unibyte.

> No it would be different: it would also signal an error if some
> non-binary char is found.  (I might potentially be convinced that it's
> OK to additionally accept the 128-255 latin1 chars as alternatives to
> eight-bit chars, since they now get character codes 128-255).

I've just installed a change to implement string-to-unibyte
as below and used it to fix the problem of jpeg detection.

(string-to-unibyte string &optional accept-latin-1)

Return a unibyte string with the same individual chars as string.
If string is unibyte, the result is string itself.
Otherwise it is a newly created string, with no text properties,
where each `eight-bit' character is converted to the corresponding byte.
If string contains a non-ASCII, non-`eight-bit' character,
an error is signalled.
If the optional 2nd arg accept-latin-1 is non-nil, a Latin-1 character
doesn't cause an error, but is converted to a byte of same code.

---
Kenichi Handa
handa@ni.aist.go.jp

bug#482: Crashes with non-default language environments

[Stefan Monnier]

Thank you.

> If the optional 2nd arg accept-latin-1 is non-nil, a Latin-1 character
> doesn't cause an error, but is converted to a byte of same code.

Hopefully this argument will never be used.


        Stefan

bug#517: Crashes with non-default language environments

[Kenichi Handa]

In article <jwv63rykwc9.fsf-monnier+emacs@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Thank you.
> > If the optional 2nd arg accept-latin-1 is non-nil, a Latin-1 character
> > doesn't cause an error, but is converted to a byte of same code.

> Hopefully this argument will never be used.

I don't mind deleting that argument.

---
Kenichi Handa
handa@ni.aist.go.jp

bug#529: Crashes with non-default language environments

[Stefan Monnier]

>> > If the optional 2nd arg accept-latin-1 is non-nil, a Latin-1 character
>> > doesn't cause an error, but is converted to a byte of same code.
>> Hopefully this argument will never be used.
> I don't mind deleting that argument.

Then let's remove it.  We can easily add it later if it proves
necessary,


        Stefan

bug#531: Crashes with non-default language environments

[Kenichi Handa]

In article <jwvskuqehfl.fsf-monnier+emacs@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> > If the optional 2nd arg accept-latin-1 is non-nil, a Latin-1 character
>>> > doesn't cause an error, but is converted to a byte of same code.
>>> Hopefully this argument will never be used.
> > I don't mind deleting that argument.

> Then let's remove it.  We can easily add it later if it proves
> necessary,

Ok, just done.

---
Kenichi Handa
handa@ni.aist.go.jp