unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
To: Martin von Gagern <Martin.vGagern@gmx.net>, bug-gnu-emacs@gnu.org
Cc: bug-gnu-emacs@gnu.org
Subject: Re: backup-buffer-copy loops if old backup can't be deleted
Date: Thu, 23 Aug 2007 16:59:49 -0400	[thread overview]
Message-ID: <E1IOJmP-0003vq-UE@fencepost.gnu.org> (raw)
In-Reply-To: <46CAD810.3050904@gmx.net> (message from Martin von Gagern on Tue, 21 Aug 2007 14:18:24 +0200)

    -		       (condition-case nil
    -			   (delete-file to-name)
    -			 (file-error nil))
    +		       (and (file-exists-p to-name)
    +			    (delete-file to-name))

I think that fix is actually correct.
It is copy-file that detects the race condition.
As long as copy-file is inside a loop, creation of
the file by another process will be dealt with.

So this change should be installed.

I think there is no need to explicitly check whether the directory
is writable.  What would be the purpose of that?

  parent reply	other threads:[~2007-08-23 20:59 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.5018.1187641790.32220.bug-gnu-emacs@gnu.org>
2007-08-20 22:01 ` backup-buffer-copy loops if old backup can't be deleted Martin von Gagern
     [not found] ` <mailman.5021.1187647310.32220.bug-gnu-emacs@gnu.org>
2007-08-21 12:18   ` Martin von Gagern
2007-08-21 14:37     ` martin rudalics
2007-08-21 14:51       ` Martin von Gagern
2007-08-21 15:28         ` martin rudalics
2007-08-21 19:35         ` Glenn Morris
2007-08-21 21:01           ` martin rudalics
2007-08-21 21:50             ` Glenn Morris
2007-08-22  9:13               ` Martin von Gagern
2007-08-22  9:44                 ` martin rudalics
2007-08-22  9:48                   ` Martin von Gagern
2007-08-22 12:40                     ` martin rudalics
2007-08-22 21:37                     ` Michael Schierl
2007-08-21 22:21             ` Martin von Gagern
2007-08-22  9:51               ` Ulrich Mueller
2007-08-23 20:59     ` Richard Stallman [this message]
2007-08-24  7:13       ` Martin von Gagern
2007-08-24  9:10         ` martin rudalics
2007-08-25  4:07           ` Richard Stallman
2007-08-25  4:07         ` Richard Stallman
     [not found]     ` <mailman.5219.1187902794.32220.bug-gnu-emacs@gnu.org>
2007-08-24  6:11       ` Ulrich Mueller
2007-08-20 19:58 Martin von Gagern
2007-08-21  6:50 ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1IOJmP-0003vq-UE@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=Martin.vGagern@gmx.net \
    --cc=bug-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).