From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Barzilay Newsgroups: gmane.emacs.bugs Subject: isearch scrolling Date: Tue, 07 Aug 2007 02:38:16 -0400 Message-ID: NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1186468727 12508 80.91.229.12 (7 Aug 2007 06:38:47 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 7 Aug 2007 06:38:47 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 07 08:38:45 2007 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IIIiI-0007dw-PB for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Aug 2007 08:38:43 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IIIiC-0002PM-DQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Aug 2007 02:38:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IIIiA-0002OZ-6g for bug-gnu-emacs@gnu.org; Tue, 07 Aug 2007 02:38:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IIIi7-0002MT-N3 for bug-gnu-emacs@gnu.org; Tue, 07 Aug 2007 02:38:32 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IIIi7-0002MG-K0 for bug-gnu-emacs@gnu.org; Tue, 07 Aug 2007 02:38:31 -0400 Original-Received: from amber.ccs.neu.edu ([129.10.116.51]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IIIi6-0001ZW-2S for bug-gnu-emacs@gnu.org; Tue, 07 Aug 2007 02:38:30 -0400 Original-Received: from kinyarwanda.ccs.neu.edu ([129.10.116.235]) by amber.ccs.neu.edu with esmtps (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.50) id 1IIIhs-0000Ut-I9 for bug-gnu-emacs@gnu.org; Tue, 07 Aug 2007 02:38:16 -0400 Original-Received: from eli by kinyarwanda.ccs.neu.edu with local (Exim 4.50) id 1IIIhs-0006rI-F2 for bug-gnu-emacs@gnu.org; Tue, 07 Aug 2007 02:38:16 -0400 X-Detected-Kernel: Solaris 9 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:16292 Archived-At: The `isearch-allow-scroll' feature changes modifiers of keys that are used to exit isearch. In particular, this gets in the way of using CUA-mode -- for example, isearch for something and use C-S-left -- no selection is done. The problem is in "isearch.el": ;; Handle a scrolling function. ((and isearch-allow-scroll (progn (setq key (isearch-reread-key-sequence-naturally keylist)) HERE ---> (setq keylist (listify-key-sequence key)) (setq main-event (aref key 0)) (setq scroll-command (isearch-lookup-scroll-key key)))) ...) You can put messages before and after that line that show the current key, and you'll see that a shift modifier is removed. Commenting this line out makes things work fine again. I believe that this is a correct fix: I don't see any use of keylist in the code, except for: (search-exit-option (let (window) (isearch-unread-key-sequence keylist) ... and that's clearly the source of the problem (grab the previous value of keylist, and use it in the above fragement, and things work again). -- ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: http://www.barzilay.org/ Maze is Life!