unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* isearch scrolling
@ 2007-08-07  6:38 Eli Barzilay
  0 siblings, 0 replies; only message in thread
From: Eli Barzilay @ 2007-08-07  6:38 UTC (permalink / raw)
  To: bug-gnu-emacs

The `isearch-allow-scroll' feature changes modifiers of keys that are
used to exit isearch.  In particular, this gets in the way of using
CUA-mode -- for example, isearch for something and use C-S-left -- no
selection is done.

The problem is in "isearch.el":

          ;; Handle a scrolling function.
          ((and isearch-allow-scroll
                (progn (setq key (isearch-reread-key-sequence-naturally keylist))
  HERE --->            (setq keylist (listify-key-sequence key))
                       (setq main-event (aref key 0))
                       (setq scroll-command (isearch-lookup-scroll-key key))))
           ...)

You can put messages before and after that line that show the current
key, and you'll see that a shift modifier is removed.  Commenting this
line out makes things work fine again.  I believe that this is a
correct fix: I don't see any use of keylist in the code, except for:

	  (search-exit-option
	   (let (window)
             (isearch-unread-key-sequence keylist)
             ...

and that's clearly the source of the problem (grab the previous value
of keylist, and use it in the above fragement, and things work again).

-- 
          ((lambda (x) (x x)) (lambda (x) (x x)))          Eli Barzilay:
                  http://www.barzilay.org/                 Maze is Life!

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-08-07  6:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-07  6:38 isearch scrolling Eli Barzilay

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).