unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Barzilay <eli@barzilay.org>
To: bug-gnu-emacs@gnu.org
Subject: isearch scrolling
Date: Tue, 07 Aug 2007 02:38:16 -0400	[thread overview]
Message-ID: <E1IIIhs-0006rI-F2@kinyarwanda.ccs.neu.edu> (raw)

The `isearch-allow-scroll' feature changes modifiers of keys that are
used to exit isearch.  In particular, this gets in the way of using
CUA-mode -- for example, isearch for something and use C-S-left -- no
selection is done.

The problem is in "isearch.el":

          ;; Handle a scrolling function.
          ((and isearch-allow-scroll
                (progn (setq key (isearch-reread-key-sequence-naturally keylist))
  HERE --->            (setq keylist (listify-key-sequence key))
                       (setq main-event (aref key 0))
                       (setq scroll-command (isearch-lookup-scroll-key key))))
           ...)

You can put messages before and after that line that show the current
key, and you'll see that a shift modifier is removed.  Commenting this
line out makes things work fine again.  I believe that this is a
correct fix: I don't see any use of keylist in the code, except for:

	  (search-exit-option
	   (let (window)
             (isearch-unread-key-sequence keylist)
             ...

and that's clearly the source of the problem (grab the previous value
of keylist, and use it in the above fragement, and things work again).

-- 
          ((lambda (x) (x x)) (lambda (x) (x x)))          Eli Barzilay:
                  http://www.barzilay.org/                 Maze is Life!

                 reply	other threads:[~2007-08-07  6:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1IIIhs-0006rI-F2@kinyarwanda.ccs.neu.edu \
    --to=eli@barzilay.org \
    --cc=bug-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).