From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#42147: 28.0.50; pure vs side-effect-free, missing optimizations? Date: Fri, 3 Jul 2020 20:35:34 +0200 Message-ID: References: <3A9CC2A3-8307-47B2-8D80-795C0AF020E1@acm.org> <0433A879-C98D-4B1A-B85C-A15DA9289099@acm.org> <1621669100.2102667.1593639091621@mail.yahoo.com> <775819003.2516724.1593687594435@mail.yahoo.com> <5F2B4684-34D1-4474-8909-9F435369FE54@acm.org> <705260433.2731607.1593698199171@mail.yahoo.com> <6CF8EE58-9A49-40E7-AA86-48AB39BF94BA@acm.org> <28B19D86-343C-4126-B95F-1F38735F73F2@acm.org> <1288c6a5-545b-f68c-ff6b-7683db3e54c1@cs.ucla.edu> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13567"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Paul Eggert , Andrea Corallo , 42147@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 03 20:36:24 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jrQXu-0003P5-S6 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Jul 2020 20:36:23 +0200 Original-Received: from localhost ([::1]:36408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jrQXt-0005lt-T7 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Jul 2020 14:36:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jrQXa-0005ki-O4 for bug-gnu-emacs@gnu.org; Fri, 03 Jul 2020 14:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46122) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jrQXa-0004eo-Eu for bug-gnu-emacs@gnu.org; Fri, 03 Jul 2020 14:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jrQXa-0004zT-CT for bug-gnu-emacs@gnu.org; Fri, 03 Jul 2020 14:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Jul 2020 18:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42147 X-GNU-PR-Package: emacs Original-Received: via spool by 42147-submit@debbugs.gnu.org id=B42147.159380135719173 (code B ref 42147); Fri, 03 Jul 2020 18:36:02 +0000 Original-Received: (at 42147) by debbugs.gnu.org; 3 Jul 2020 18:35:57 +0000 Original-Received: from localhost ([127.0.0.1]:57668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrQXU-0004zA-U4 for submit@debbugs.gnu.org; Fri, 03 Jul 2020 14:35:57 -0400 Original-Received: from mail1451c50.megamailservers.eu ([91.136.14.51]:56962 helo=mail266c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jrQXS-0004yl-2a for 42147@debbugs.gnu.org; Fri, 03 Jul 2020 14:35:55 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1593801339; bh=JsrY+6moARlLqfWCU/g7vv3f/2I2a8sbitAhxsw9WDw=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=KkcIhY4/NKXPw/kqP5Aq/GgeNaPN3LAY0NECy12f0AxoHhW1CFjpCWkDCH/BoKHg7 y5N5myixGVsJHw/aw4mFkOs5DKMssKxfHzNxn7RAuRnqwtIZZZJMVqG4ELHqP4bJoD skSKlH5kXKzuUjHraQnYg6MvBPTOAsSNI8sdnUbw= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail266c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 063IZZB6027054; Fri, 3 Jul 2020 18:35:37 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.14) X-CTCH-RefID: str=0001.0A782F24.5EFF79F6.001F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=A5MSwJeG c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=iRZporoAAAAA:8 a=3eXLOUZK9UX6dtRRiNQA:9 a=CjuIK1q_8ugA:10 a=NOBgFS-JBQ2l-kSd6-zu:22 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182669 Archived-At: 3 juli 2020 kl. 15.11 skrev Stefan Monnier : >=20 >> Fortunately modern compilers generate SSE code by default, only = passing >> return values on the x87 stack as per the x86 ABI (which causes no >> harm). This reduces an already tiny risk to nil. We could add an = elaborate >> configure or run-time test and admonishments to the installation >> instructions but frankly we have better use of our time. I suggest we >> replace byte-opt--portable-numberp with numberp (or nothing at all, >> depending on where it occurs) and be done with it. >=20 > Agreed, Thanks -- patch attached. Some expressions will still not be = constant-folded entirely; for example (byte-optimize-form '(+ #x100000000000000 1 1)) =3D> (+ 72057594037927936 1 1) This will be fixed automatically by marking + as pure; the same should = be done for the other arithmetic functions. By the way, is it a bug or a feature that calls to pure functions with = constant but invalid arguments raise an error at compile-time? For = example: (disassemble (lambda () (if nil (regexp-quote nil)))) will raise an error despite none would be generated at run time if this = function were interpreted. It's easy to suppress those errors, but I see how they can be useful in = practice.