From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.bugs Subject: Re: find-file and friends doc string improvements Date: Sat, 10 Apr 2004 22:35:54 -0400 Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Message-ID: References: <16503.7480.436692.391082@ihs.com> Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1081651778 29445 80.91.224.253 (11 Apr 2004 02:49:38 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 11 Apr 2004 02:49:38 +0000 (UTC) Cc: gnu-emacs-bug@moderators.isc.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 11 04:49:31 2004 Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BCV2J-0003Qy-00 for ; Sun, 11 Apr 2004 04:49:31 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BCUx1-0002tx-OE for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Apr 2004 22:44:03 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BCUsV-0001JR-Mi for bug-gnu-emacs@prep.ai.mit.edu; Sat, 10 Apr 2004 22:39:23 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BCUrw-0000sb-CJ for bug-gnu-emacs@prep.ai.mit.edu; Sat, 10 Apr 2004 22:39:21 -0400 Original-Received: from [216.168.1.22] (helo=trinity.supernews.net) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.30) id 1BCUpS-0007tl-3v for bug-gnu-emacs@prep.ai.mit.edu; Sat, 10 Apr 2004 22:36:14 -0400 Original-Received: from fencepost.gnu.org ([199.232.76.164]:38121) by trinity.supernews.net with esmtp (Exim 4.24; FreeBSD) id 1BCUpQ-000LvS-Re for gnu-emacs-bug@moderators.isc.org; Sun, 11 Apr 2004 02:36:12 +0000 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.24) id 1BCUp8-00070k-6W; Sat, 10 Apr 2004 22:35:54 -0400 Original-To: Kevin Rodgers In-reply-to: <16503.7480.436692.391082@ihs.com> (message from Kevin Rodgers on Fri, 9 Apr 2004 16:01:28 -0600) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.bugs:7568 X-Report-Spam: http://spam.gmane.org/gmane.emacs.bugs:7568 Some of those changes are good, but there are some problems. If `find-file-visit-truename' is set, a buffer ! visiting the same file under a different name will be selected. ! Please avoid the passive voice when writing documentation. It makes text harder to read and sometimes causes vagueness. ! "Edit file FILENAME, in another window. ! May create a new window, or reuse an existing one. ! See the function `display-buffer'. ! Interactively, or if WILDCARDS is non-nil in a call from Lisp, ! expand wildcards (if any) and visit multiple files." (interactive "FFind file in other window: \np") (let ((value (find-file-noselect filename nil nil wildcards))) (if (listp value) --- 742,753 ---- (switch-to-buffer value)))) (defun find-file-other-window (filename &optional wildcards) ! "Edit file FILENAME as with `find-file', in another window. ! May create a new window, or reuse an existing one. See the function ! `display-buffer'. ! ! Interactively, or if WILDCARDS is non-nil in a call from Lisp, expand ! wildcards (if any) and visit multiple files." The current text has line breaks that make it easier to read. Filling the text to make longer lines would not be an improvement. *************** *** 768,775 **** (switch-to-buffer-other-frame value)))) (defun find-file-read-only (filename &optional wildcards) ! "Edit file FILENAME but don't allow changes. ! Like `find-file' but marks buffer as read-only. Use \\[toggle-read-only] to permit editing." (interactive "fFind file read-only: \np") (find-file filename wildcards) --- 774,781 ---- (switch-to-buffer-other-frame value)))) (defun find-file-read-only (filename &optional wildcards) ! "Edit file FILENAME as with `find-file', but don't allow changes. ! Marks buffer as read-only. Use \\[toggle-read-only] to permit editing." (interactive "fFind file read-only: \np") (find-file filename wildcards) *************** *** 777,784 **** (current-buffer)) (defun find-file-read-only-other-window (filename &optional wildcards) ! "Edit file FILENAME in another window but don't allow changes. ! Like \\[find-file-other-window] but marks buffer as read-only. Use \\[toggle-read-only] to permit editing." (interactive "fFind file read-only other window: \np") (find-file-other-window filename wildcards) --- 783,790 ---- (current-buffer)) (defun find-file-read-only-other-window (filename &optional wildcards) ! "Edit file FILENAME as with `find-file-read-only', in another window. ! Like \\[find-file-other-window], but marks buffer as read-only. Use \\[toggle-read-only] to permit editing." (interactive "fFind file read-only other window: \np") (find-file-other-window filename wildcards) Those are good changes. The rest of the changes are also good. If someone would like to install them, that would be good.