unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* patch for image.el
@ 2004-01-29 21:20 chrisl
  2004-01-31  7:50 ` Richard Stallman
  0 siblings, 1 reply; 2+ messages in thread
From: chrisl @ 2004-01-29 21:20 UTC (permalink / raw)


Hi,

I'm using GNU emacs 21.3.1 under Linux.  I discovered that image.el
didn't recognize some of my jpeg files (it reported them as not being
image files).  By using file(1) and looking at the magic(5) file, I
saw that there is a different jpeg format in addition to JFIF: Exif.
I also found that image-jpeg-p can cause substring to run past the end
of the data array, which causes an error.  I made the following change
that fixes both problems:

67,69c67
< 		     (string-match "JFIF\\|Exif" 
< 				   (substring data i 
< 					      (min (+ i nbytes) len)))))
---
> 		     (string-match "JFIF" (substring data i (+ i nbytes)))))

Thanks for maintaining The One True Editor. :)

- Chris

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: patch for image.el
  2004-01-29 21:20 patch for image.el chrisl
@ 2004-01-31  7:50 ` Richard Stallman
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Stallman @ 2004-01-31  7:50 UTC (permalink / raw)
  Cc: bug-gnu-emacs

      By using file(1) and looking at the magic(5) file, I
    saw that there is a different jpeg format in addition to JFIF: Exif.

We have fixed this in the version in CVS on Savannah.gnu.org, but
thanks anyway.

    I'm using GNU emacs 21.3.1 under Linux...
    Thanks for maintaining The One True Editor. :)

This editor is one of the programs we developed for the GNU operating
system.  It looks like you're using the entire GNU system.

Most users of GNU don't realize it is GNU, because they think the
whole system is "Linux".  You could help inform them, simply by saying
you are running GNU Emacs 21.3.1 under GNU/Linux.  That is the form
of thanks that will really help.

See http://www.gnu.org/gnu/gnu-linux-faq.html for more
explanation of the situation.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-01-31  7:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-01-29 21:20 patch for image.el chrisl
2004-01-31  7:50 ` Richard Stallman

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).