From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Howard Melman Newsgroups: gmane.emacs.bugs Subject: bug#50435: 27.2; browse-url-encode-url not encoding spaces Date: Mon, 6 Sep 2021 14:06:33 -0400 Message-ID: Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11222"; mail-complaints-to="usenet@ciao.gmane.io" To: 50435@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 06 20:07:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNJ1W-0002k7-Ed for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Sep 2021 20:07:14 +0200 Original-Received: from localhost ([::1]:34104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNJ1U-0004Zn-R1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Sep 2021 14:07:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNJ1K-0004ZP-JA for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2021 14:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42872) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNJ1K-0003pD-BK for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2021 14:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNJ1K-0002YX-4Z for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2021 14:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Howard Melman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Sep 2021 18:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50435 X-GNU-PR-Package: emacs X-Debbugs-Original-To: GNU Emacs Original-Received: via spool by submit@debbugs.gnu.org id=B.16309516009794 (code B ref -1); Mon, 06 Sep 2021 18:07:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Sep 2021 18:06:40 +0000 Original-Received: from localhost ([127.0.0.1]:54418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNJ0y-0002Xu-4G for submit@debbugs.gnu.org; Mon, 06 Sep 2021 14:06:40 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:37470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNJ0w-0002Xn-MD for submit@debbugs.gnu.org; Mon, 06 Sep 2021 14:06:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNJ0w-0004Wc-Hr for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2021 14:06:38 -0400 Original-Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]:33701) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNJ0u-0003XV-TD for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2021 14:06:38 -0400 Original-Received: by mail-qk1-x730.google.com with SMTP id b64so7654730qkg.0 for ; Mon, 06 Sep 2021 11:06:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=Kkt+QD88sYybB4VmEBsih0wvANzJC6DClqlQXJsok8g=; b=PNCl5siuIqyf1XmXU5TZqBeDAM8QQxfb5HFYRAccRPfkSnu+ns+1jFf+PI//OMcq+0 gLv11p2Rp3eDVHmlbFa2mI05O7zVCz0sR0JyNMa+E9S4ToGARTCGVtJcUPO1NVm/QWE4 IWGFaFEb9X+VVQJuhULhq36v5oywhjXGRTX+8wfQOQmDOfZnWG0AKYqF5faXHoyM8GYx LRAKUEA+gsqkNbtyILwJuGG///lQFnxAbqk5rU38Lk+zzkBQKuK05XAfFoIBNFeaUjuY KKx7yi4wx12QGZLaFKKeKJo/kboPyTCkUnaVjOz7BSTl9qpTY3EwHKTJz2ijJL+8T/9S y46g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=Kkt+QD88sYybB4VmEBsih0wvANzJC6DClqlQXJsok8g=; b=L+D3SOBrsfCjlH62Zu/9DtfkuHVTKw+r53kO6HxDR95NwUMoC2rTUxXqKYUJFsheSm CWDB9tkn2s/gyDliOsn0N9R1HEFXP9VjJoPeOhDImGJrS4+TUA5E9maFeYCZxu5EPHA2 SLtlnci+RWQnE5a0mZoZ0ZayzugZdT4oVmjZbMyFxhqPUxx1Gw+7CzCKphdW3UVmo++z 8Rrq2HJ16rbDMTkmmXowsPxecCa2qCTF4EbJNu2xLJ9TwSho4ae3cWNRYrCSpWMCCXay bDQd4CS7KO7T4o3ciuBI1yNEBTt6lAi+F1wPzIxjAzu+6xOEd3KkrMtnJ5BWg37fq6QW RUng== X-Gm-Message-State: AOAM532Tq/nOFwRT5UuTb5BPvEWdRoQ+3KiEGBivyikI1bQN1QR9P4eK /C5KkUQPH2xgXITy7X//TZykWPBj0dg= X-Google-Smtp-Source: ABdhPJxHZjOkKwv+y/btmaEY7S4DBnCDbXYNbjvND41H2ajAt+09kwUHY+f2iqvI/NM1bR8jN1M2uA== X-Received: by 2002:a05:620a:1998:: with SMTP id bm24mr12325614qkb.444.1630951595114; Mon, 06 Sep 2021 11:06:35 -0700 (PDT) Original-Received: from smtpclient.apple (pool-108-26-204-101.bstnma.fios.verizon.net. [108.26.204.101]) by smtp.gmail.com with ESMTPSA id j18sm6986001qkl.12.2021.09.06.11.06.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Sep 2021 11:06:34 -0700 (PDT) X-Mailer: Apple Mail (2.3654.120.0.1.13) Received-SPF: pass client-ip=2607:f8b0:4864:20::730; envelope-from=hmelman@gmail.com; helo=mail-qk1-x730.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213623 Archived-At: I may be misunderstanding something, but browse-url-encode-url does not encode spaces. (browse-url-encode-url "foo bar") returns "foo bar" and I think it should return "foo%20bar" It looks like a simple typo in browse-url-encode-url since it calls: (browse-url-url-encode-chars url "[\")$] ")) I think the space should be before the ], but from what I can=20 tell it's been that way since 2012. Also browse-url-encode-url is used in several browser specific browse-url functions like browse-url-netscape and browse-url-firefox but not in browse-url-default-windows-browser and browse-url-default-macosx-browser. Is this intentional? I'm on a mac (using the macport) and it seems frustrating. I'm trying to do something like this: (let ((url "https://www.dndbeyond.com/search?q=3D%s") (str (browse-url-encode-url (buffer-substring-no-properties = (region-beginning) (region-end))))) (browse-url (format url str)))) Maybe I'm supposed to use something else? Like url-hexify-string (which seems to work)? I found it frustrating that there's no mention of any of this stuff in the elisp manual. I'm not sure which is the preferred mechanism. I feel like browse-url.el should call url-hexify-string but it doesn't (probably for historical reasons) though it does call url-unhex-string once. In GNU Emacs 27.2 (build 1, x86_64-apple-darwin18.7.0, Carbon Version = 158 AppKit 1671.6) of 2021-03-27 built on Traviss-Mac.local --=20 Howard