From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Bodo Schulze Newsgroups: gmane.emacs.bugs Subject: Command `browse-url-galeon' in browse-url.el Date: Sat, 09 Aug 2003 22:06:07 +0200 Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Message-ID: NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1060459709 8240 80.91.224.253 (9 Aug 2003 20:08:29 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 9 Aug 2003 20:08:29 +0000 (UTC) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 09 22:08:28 2003 Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19la0p-00016f-00 for ; Sat, 09 Aug 2003 22:08:27 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19la0I-0007FQ-7r for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Aug 2003 16:07:54 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19la0D-00079y-4T for bug-gnu-emacs@gnu.org; Sat, 09 Aug 2003 16:07:49 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19lZzf-0006SK-W6 for bug-gnu-emacs@gnu.org; Sat, 09 Aug 2003 16:07:47 -0400 Original-Received: from [62.26.116.129] (helo=webmail.tiscali.de) by monty-python.gnu.org with esmtp (Exim 4.20) id 19lZzf-0006R3-Mr for bug-gnu-emacs@gnu.org; Sat, 09 Aug 2003 16:07:15 -0400 Original-Received: from mardochee (62.246.163.131) by webmail.tiscali.de (6.7.019) id 3F2FB4290011993C for bug-gnu-emacs@gnu.org; Sat, 9 Aug 2003 22:07:01 +0200 Original-Received: from localhost ([127.0.0.1] helo=letras.net) by mardochee with esmtp (Exim 3.35 #1 (Debian)) id 19lZyZ-0000he-00 for ; Sat, 09 Aug 2003 22:06:07 +0200 Original-To: bug-gnu-emacs@gnu.org X-Mailer: mh-e 6.1; nmh 1.0.4+dev; Emacs 21.2 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Bug reports for GNU Emacs, the Swiss army knife of text editors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.bugs:5517 X-Report-Spam: http://spam.gmane.org/gmane.emacs.bugs:5517 This bug report will be sent to the Free Software Foundation, not to your local site managers! Please write in English, because the Emacs maintainers do not have translators to read other languages for them. Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list, and to the gnu.emacs.bug news group. In GNU Emacs 21.2.1 (i386-debian-linux-gnu, X toolkit, Xaw3d scroll bars) of 2002-03-22 on raven, modified by Debian configured using `configure i386-debian-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --with-x=yes --with-x-toolkit=athena --without-gif' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: C value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: de_DE locale-coding-system: iso-latin-1 default-enable-multibyte-characters: t Please describe exactly what actions triggered the bug and the precise symptoms of the bug: Using galeon version 1.2.5 In a buffer being in text-mode, I placed point on file:///usr/local/doc/HOWTO/Text-Terminal-HOWTO-9.html then called M-x browse-url-galeon This works fine. Then I issue: M-x browse-url-new-window-flag RET t RET place point on file:///usr/local/doc/HOWTO/Text-Terminal-HOWTO-8.html and call again M-x browse-url-galeon This last file gets shown in the same window as the first one, but should be shown in a new window. In defun browse-url-galeon in browse-url-el, I read this: (process (apply 'start-process (concat "galeon " url) nil browse-url-galeon-program (append browse-url-galeon-arguments (if new-window '("-w" "--noraise")) (list "-x" url))))) I guess the option -x (for 'show in same window') shadows the earlier option -w (for 'show in new window'). Also --noraise is not mentioned in the manual of Galeon version 1.2.5 Here is a patch that I found to correct the problem: *** browse-url.el.orig Sat Aug 9 19:58:27 2003 --- browse-url.el Sat Aug 9 19:58:27 2003 *************** *** 901,908 **** browse-url-galeon-program (append browse-url-galeon-arguments ! (if new-window '("-w" "--noraise")) ! (list "-x" url))))) (set-process-sentinel process `(lambda (process change) (browse-url-galeon-sentinel process ,url))))) --- 904,912 ---- browse-url-galeon-program (append browse-url-galeon-arguments ! ;; -w does not pass through with -x ! (list (if new-window "-w" "-x") ! url))))) (set-process-sentinel process `(lambda (process change) (browse-url-galeon-sentinel process ,url))))) Hope it helps. Additional remark: Galeon now can open a file in a new Tab. Emacs does not yet provide a flag for this useful option. I already mentioned this in an earlier bug-report on `browse-url-mozilla' in browse-url.el. Should there be a new flag, or would it be better to leave it to the user to specify the desired behaviour in `browse-url-galeon-arguments' and `browse-url-mozilla-arguments' altogether? Best regards, Bodo Schulze