From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#14257: 24.3.50; (elisp) `Modifying Menus' - clarify second example Date: Wed, 24 Apr 2013 09:21:08 -0700 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1366820530 11685 80.91.229.3 (24 Apr 2013 16:22:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Apr 2013 16:22:10 +0000 (UTC) To: 14257@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 24 18:22:14 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UV2SP-0005XS-Ml for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Apr 2013 18:22:09 +0200 Original-Received: from localhost ([::1]:48340 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV2SP-0005gr-9c for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Apr 2013 12:22:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV2SK-0005gL-RJ for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 12:22:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UV2SG-0005kM-27 for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 12:22:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV2SF-0005kB-V2 for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 12:21:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UV2X8-0005ZI-5Z for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 12:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Apr 2013 16:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.136682078921343 (code B ref -1); Wed, 24 Apr 2013 16:27:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Apr 2013 16:26:29 +0000 Original-Received: from localhost ([127.0.0.1]:41218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UV2Wa-0005YB-4W for submit@debbugs.gnu.org; Wed, 24 Apr 2013 12:26:28 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33294) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UV2WU-0005Y1-PC for submit@debbugs.gnu.org; Wed, 24 Apr 2013 12:26:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UV2Ra-0005Sd-Bs for submit@debbugs.gnu.org; Wed, 24 Apr 2013 12:21:19 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:57596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV2Ra-0005SY-90 for submit@debbugs.gnu.org; Wed, 24 Apr 2013 12:21:18 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV2RV-0004bq-7w for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 12:21:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UV2RT-0005R7-VS for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 12:21:13 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:40708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UV2RT-0005Qv-QQ for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2013 12:21:11 -0400 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r3OGL9w1010921 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 24 Apr 2013 16:21:10 GMT Original-Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r3OGL9Rb025051 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Wed, 24 Apr 2013 16:21:09 GMT Original-Received: from abhmt111.oracle.com (abhmt111.oracle.com [141.146.116.63]) by userz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r3OGL9V8025036 for ; Wed, 24 Apr 2013 16:21:09 GMT Original-Received: from dradamslap1 (/130.35.178.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 24 Apr 2013 09:21:08 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac5BB7nmxRbo/o8FQNeKtpBADUiDoQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73631 Archived-At: It might help if some motivation were given for the second example: (define-key-after (lookup-key shell-mode-map [menu-bar signals]) [work] '("Work" . work-command) 'break) My guess is that that example was added to tell users how to deal with the error that used to be raised if you used something like this: (define-key-after minibuffer-local-completion-map [menu-bar minibuf foo] '(menu-item "Foo" foo) 'quit) Instead of this: (define-key-after (lookup-key minibuffer-local-completion-map [menu-bar minibuf]) [foo] '(menu-item "Foo" foo) 'quit) That error is no longer raised. And the doc string has been updated to no longer say this: "KEY must contain just one event type--that is to say, it must be a string or vector of length 1." If the example still has a purpose (some other purpose), then consider mentioning it. And it would at least help to mention that the `lookup-key' sexp in the example returns a keymap, not a key. Without knowing that, the second example would not make much sense (hence, some readers will guess it, but it would still help to mention it). In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600) of 2013-04-17 on ODIEONE Bzr revision: 112320 monnier@iro.umontreal.ca-20130418001233-g6wsqi5bpq2hsd0k Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.7) --no-opt --enable-checking --cflags -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib'