From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59788: 29.0.60; [PATCH] Make treesit-end-of-defun handle nil node Date: Sun, 4 Dec 2022 22:22:41 -0800 Message-ID: References: <87h6ydfsag.fsf@thornhill.no> Reply-To: Yuan Fu Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15062"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eliz@gnu.org, 59788-done@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 05 07:23:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p24sp-0003cE-KF for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Dec 2022 07:23:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p24sb-0002sa-7n; Mon, 05 Dec 2022 01:23:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p24sZ-0002s1-KU for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 01:23:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p24sY-0000EN-8N for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 01:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p24sX-00006L-W4 for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 01:23:02 -0500 In-Reply-To: <87h6ydfsag.fsf@thornhill.no> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Dec 2022 06:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59788 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 59788@debbugs.gnu.org, yuf011@ucsd.edu, theo@thornhill.no Original-Received: via spool by 59788-done@debbugs.gnu.org id=D59788.1670221375359 (code D ref 59788); Mon, 05 Dec 2022 06:23:01 +0000 Original-Received: (at 59788-done) by debbugs.gnu.org; 5 Dec 2022 06:22:55 +0000 Original-Received: from localhost ([127.0.0.1]:33951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p24sQ-00005i-Rc for submit@debbugs.gnu.org; Mon, 05 Dec 2022 01:22:55 -0500 Original-Received: from mx0b-0016e101.pphosted.com ([148.163.141.31]:43062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p24sM-00005c-SO for 59788-done@debbugs.gnu.org; Mon, 05 Dec 2022 01:22:53 -0500 Original-Received: from pps.filterd (m0151357.ppops.net [127.0.0.1]) by mx0b-0016e101.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B56DMMX007410 for <59788-done@debbugs.gnu.org>; Sun, 4 Dec 2022 22:22:45 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucsd.edu; h=from : content-type : content-transfer-encoding : mime-version : subject : message-id : date : cc : to; s=campus; bh=bWpxNAr9AAWQ7pljWHO9/pTXFD23jTDXbU82aLoqaOU=; b=pOuZe0PPiM5t6CuuzaE0/juLbbm/D1D4wB0RdhwOiqDNSv2116mkjwQO63rLhSmpo2/m 8w76xv7CZyRytQnILop1UPjzVpzysCvqBd261nv9t3RHwQvQ4hpCLdfs7vvoB4DTGAwH zVkdISXVa1rjw7hp0K+H2g4m7cSk778ml2ZGueHM/ppdu5zWaQLBxqmSnK6p9kTAj5+d /zFBaIv+Owpg4OfFi5n/lV4IZ0qFMmqQohzLt/KcQrYO83jN22rJnfi3KaMePzwHXD3/ RJiiNaNsw4ksmblKNxqSnUTFzgL8VROrI/2CKRF+mj83eK13km6K1ySHpXr5DK8asvmc 9g== Original-Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0b-0016e101.pphosted.com (PPS) with ESMTPS id 3m96kh9gd4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for <59788-done@debbugs.gnu.org>; Sun, 04 Dec 2022 22:22:44 -0800 Original-Received: by mail-pg1-f198.google.com with SMTP id r126-20020a632b84000000b004393806c06eso9368467pgr.4 for <59788-done@debbugs.gnu.org>; Sun, 04 Dec 2022 22:22:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucsd.edu; s=google; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=bWpxNAr9AAWQ7pljWHO9/pTXFD23jTDXbU82aLoqaOU=; b=l/ALOcQ4uxklJ7fJHnlFQCultMmC4mXvYOOs0GQtea2I5FdaVcTBkh+ewUGDRA9OvO hlosGp2S+StwbTBp2XQPRqBcZXNCR/YO/e4UZwhK2s//p9fxj2lF/AW9kmxZyDblEIxA xuf0PTEUylxGZjrFg8iKqwh3IgXzFnduyb61Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bWpxNAr9AAWQ7pljWHO9/pTXFD23jTDXbU82aLoqaOU=; b=DhQZme05V1GoRAvqYWuCHdI26s/8uYX3Jm+TtaurfnAMf469sz3bTA/w07zs3wleZM XkCAsltF2Gx3BWOjwpMSA8fyMHLKSnTDtPeJtNGuqf5o7DtcCQBzNNw6geLLj10pF3oF 8B+Ucy1dkWGQiroxQk+vPY/dd/OyCw4R3f0P22OwIJDEw0rZb+JdjG1XHiNYKWJifXE9 OMH99NBZhbjnjXHOA5GA8ngEhy4zOuL95qahcyT3XDHnImarK4wnxMNWUkjquG55BNhe eAqyktMU79VbcJ7moTuoF0m0ZRVWsTJevdGIv4JTVFsJNRhc9eGRbn/w+TfkZknKZqeC Q/pw== X-Gm-Message-State: ANoB5pm9/f7vkXh/jW904ZCMTvlkRbse6GMPXVfEx4Y7tRQv2M1Jfv9t a3rSw2zJ+KbQPv5DkiY4z1qVE/5/9P0jfr0Xy+HuHCPa1uUqO3vgENupaJlG4cSzAuC/YrFo5P/ 06iboczTpkokAW0AS0SJ6 X-Received: by 2002:a05:6a00:1625:b0:576:48b4:2b06 with SMTP id e5-20020a056a00162500b0057648b42b06mr15900815pfc.30.1670221363487; Sun, 04 Dec 2022 22:22:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf64pB1O+Onwb1N7cQwtMdj79kTPvXWNSNTMGGTE7YM7sh50RReaqPGj+ifVVLaj5XCTz9Y/uQ== X-Received: by 2002:a05:6a00:1625:b0:576:48b4:2b06 with SMTP id e5-20020a056a00162500b0057648b42b06mr15900794pfc.30.1670221363197; Sun, 04 Dec 2022 22:22:43 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id e7-20020a630f07000000b004777c56747csm7516645pgl.11.2022.12.04.22.22.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Dec 2022 22:22:42 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-campus_gsuite: gsuite_33445511 X-Proofpoint-ORIG-GUID: jgz3Inc-l25TIMei7yNeulsMKE-bHJTh X-Proofpoint-GUID: jgz3Inc-l25TIMei7yNeulsMKE-bHJTh pp_allow_relay: proofpoint_allowed X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-05_01,2022-12-01_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1011 phishscore=0 mlxlogscore=662 adultscore=0 bulkscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212050026 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249989 Archived-At: Theodor Thornhill writes: > On 3 December 2022 07:33:46 CET, Eli Zaretskii wrote: >>> Cc: casouri@gmail.com, eliz@gnu.org >>> From: Theodor Thornhill >>> Date: Fri, 02 Dec 2022 21:45:59 +0100 >>> >>> However, I notice that treesit-beginning-of-defun returns t after it is >>> done. Is there a reason for end-of-defun not to return the same? >> >>The return value of end-of-defun is not documented, so it can be anything. > > Ok thanks, then I think this patch is ok now :) > > Theo I think I applied a similar patch sent in another bug report, closing this. Thanks as always :-) Yuan