From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59268: [PATCH] Utilize new font-lock faces for C/C++ and Python tree-sitter use Date: Wed, 16 Nov 2022 19:39:59 -0800 Message-ID: References: <_eVZXSOw6ehYHpOX5-Uf76Mz8SW9Q1mqy0mEzCSlKU4p9obGA8eaEPhf5yrFKdG293X9pQw7qvz_JYQKQ9gd9Oxxzn4aazUq-5RSp-8-tok=@rjt.dev> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40416"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59268@debbugs.gnu.org To: Randy Taylor Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 17 04:41:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovVmG-000AHV-Le for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Nov 2022 04:41:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovVlx-0007fN-Ms; Wed, 16 Nov 2022 22:41:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovVlv-0007dj-5o for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 22:41:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovVlu-0008H0-Tu for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 22:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ovVlu-0007mD-9s for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 22:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Nov 2022 03:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59268 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59268-submit@debbugs.gnu.org id=B59268.166865641229817 (code B ref 59268); Thu, 17 Nov 2022 03:41:02 +0000 Original-Received: (at 59268) by debbugs.gnu.org; 17 Nov 2022 03:40:12 +0000 Original-Received: from localhost ([127.0.0.1]:58689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovVl6-0007kr-4h for submit@debbugs.gnu.org; Wed, 16 Nov 2022 22:40:12 -0500 Original-Received: from mail-pg1-f173.google.com ([209.85.215.173]:33679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovVl2-0007kY-JT for 59268@debbugs.gnu.org; Wed, 16 Nov 2022 22:40:10 -0500 Original-Received: by mail-pg1-f173.google.com with SMTP id b62so900336pgc.0 for <59268@debbugs.gnu.org>; Wed, 16 Nov 2022 19:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iuqWKJdxjpu+nbi8f6IksMN9y1tNmHUaJqugpnp8kEg=; b=PFdgCSOcXIHgt1MaCR2cOk5TaZvebO1x8nivShziPiCeUqURyWglaWk7xsOADGEcNW k4SJkEcNBRyMNOeKS40+6FH6rCGMjQePtoPnRWSUrPMzzzj0kvObHJWhNqwqzRlutB70 PE13Fifhk7ST9SHax1cqx7v68DGPxR0j49aIxSI51h/pVEw1nk5i3ggCDrA5Ibqjz/bC A72nGvCvZBgxOuQ0AqZaHafdERFZyXB02BxDW5K4MZVxTP/T0bZB1dAkNtL2x1XTvyzj 1qIt8LgeUwXGqUCSIcpuwnK7JyrtSVe7QFqg/uENDnaS48DpaWfqgzODQ2ZVJNz5B1H3 myzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iuqWKJdxjpu+nbi8f6IksMN9y1tNmHUaJqugpnp8kEg=; b=LKjj2JzQV7BwicR78sPENGoEVm5Y4T1QR9jEPBbksrDuBvSzwjg72UnhFHxGVItpBi hVnLBe06k1Q4e5Zu/LAPVnfR4/TNkAqT7TycVqvJHUfxS49YNZVQvgznuNE3AsBKMHLI qlZVnwBxTG99z9FevbiEknHN8VTrF9L7v7PhfuNM20N0jcAYfviq3sgYCsIeF7gn8bKS jbXqrPzdchuwsICBBNx9ohMKdMqm+ZV3d/o3aR8ycISRxHoFQ9XK3yzJkllC9/Qx/Omh dyHvYNJcoqh1dPJindq6wjGlrZuwc4Wjg/iWlxitK2jWGiKQaIX7F6UsRIDm7srx4NTF Z3fA== X-Gm-Message-State: ANoB5pkSyh+8Ub63dqa012m26eJeuvqo+pi4TeJfQ7Ap7OQKD1ZWafyL 8UL+SVC9DIbg/32H46Hr9/8= X-Google-Smtp-Source: AA0mqf7RUKiY2g8tY+Jl4CCXXFbj0y0awfeS3h02hCHuo29+Wrto2cZ4R0OyNCIvmYURBHHu841wAA== X-Received: by 2002:a62:6409:0:b0:563:3c15:f891 with SMTP id y9-20020a626409000000b005633c15f891mr1044649pfb.76.1668656402347; Wed, 16 Nov 2022 19:40:02 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id p7-20020a170902780700b00187033cc287sm12961697pll.190.2022.11.16.19.40.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Nov 2022 19:40:01 -0800 (PST) In-Reply-To: <_eVZXSOw6ehYHpOX5-Uf76Mz8SW9Q1mqy0mEzCSlKU4p9obGA8eaEPhf5yrFKdG293X9pQw7qvz_JYQKQ9gd9Oxxzn4aazUq-5RSp-8-tok=@rjt.dev> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248077 Archived-At: > On Nov 16, 2022, at 7:26 PM, Randy Taylor wrote: >=20 > Updated the patch again to apply cleanly, as there were some more = changes to c-ts-mode.el. >=20 >=20 > <0001-Utilize-new-font-lock-faces-for-C-C-and-Python-tree-.patch> Ah, for making you updating the patch for so many times! I just see this = report. The only comment I have is that I see you removed the field rule = from assignment feature: - (assignment_expression - left: (field_expression field: (_) @font-lock-property-face)) I envisioned the assignment feature to highlight =E2=80=9Cthe thing = being assigned to=E2=80=9D, in which case it would highlight the field = when it=E2=80=99s in LHS. It=E2=80=99s perfectly fine to have both the = field rule and the assignment rule to highlight fields, I think. So if = you don=E2=80=99t mind, I=E2=80=99d add it back to assignment group. Yuan=