From: Yuan Fu <casouri@gmail.com>
To: Randy Taylor <dev@rjt.dev>
Cc: 59268@debbugs.gnu.org
Subject: bug#59268: [PATCH] Utilize new font-lock faces for C/C++ and Python tree-sitter use
Date: Wed, 16 Nov 2022 19:39:59 -0800 [thread overview]
Message-ID: <E01CB7E2-ED4A-465D-81CA-21ACAD9C1FB6@gmail.com> (raw)
In-Reply-To: <_eVZXSOw6ehYHpOX5-Uf76Mz8SW9Q1mqy0mEzCSlKU4p9obGA8eaEPhf5yrFKdG293X9pQw7qvz_JYQKQ9gd9Oxxzn4aazUq-5RSp-8-tok=@rjt.dev>
> On Nov 16, 2022, at 7:26 PM, Randy Taylor <dev@rjt.dev> wrote:
>
> Updated the patch again to apply cleanly, as there were some more changes to c-ts-mode.el.
>
>
> <0001-Utilize-new-font-lock-faces-for-C-C-and-Python-tree-.patch>
Ah, for making you updating the patch for so many times! I just see this report. The only comment I have is that I see you removed the field rule from assignment feature:
- (assignment_expression
- left: (field_expression field: (_) @font-lock-property-face))
I envisioned the assignment feature to highlight “the thing being assigned to”, in which case it would highlight the field when it’s in LHS. It’s perfectly fine to have both the field rule and the assignment rule to highlight fields, I think. So if you don’t mind, I’d add it back to assignment group.
Yuan
next prev parent reply other threads:[~2022-11-17 3:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 3:27 bug#59268: [PATCH] Utilize new font-lock faces for C/C++ and Python tree-sitter use Randy Taylor
2022-11-15 1:26 ` Randy Taylor
2022-11-16 2:04 ` Randy Taylor
2022-11-17 3:26 ` Randy Taylor
2022-11-17 3:39 ` Yuan Fu [this message]
2022-11-17 13:50 ` Randy Taylor
2022-11-17 18:39 ` Yuan Fu
2022-11-17 20:02 ` Randy Taylor
2022-11-17 20:07 ` Yuan Fu
2022-11-17 20:19 ` Randy Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E01CB7E2-ED4A-465D-81CA-21ACAD9C1FB6@gmail.com \
--to=casouri@gmail.com \
--cc=59268@debbugs.gnu.org \
--cc=dev@rjt.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).