From: Noah Evans <noah@nevans.me>
To: 50220@debbugs.gnu.org
Subject: bug#50220: 27.2; follow.el: follow-recenter does not work correctly if invoked in a follow window before the middle follow window.
Date: Fri, 27 Aug 2021 00:39:26 +0000 [thread overview]
Message-ID: <DsmWQ9k4_RNGYmA3cUs-ALGKYGJzgqoJPRYpVAAQVF_dsbBeyeUUmhgAhQHrK9gG7-kbAKrO-hJMGfOkJcVBFBkRMpmJ6_wHe1mF8W91gmg=@nevans.me> (raw)
[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]
In GNU Emacs 27.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0)
Windowing system distributor 'The X.Org Foundation', version 11.0.12013000
System Description: Arch Linux
In follow mode, 'follow-mode-recenter` with no argument should center
the middle window around point. It works fine if it is used in the
middle window or a window after it, but if it is used in a window before
middle the post-command-hook moves the window back.
Reproduce:
Find a long file.
Split the window vertically two or more times.
M-x follow-mode
Go to the leftmost window and do C-c . C-l
Patch to fix:
From 65c6ccae67a5b2744711c3bfae2ebff3e530c2c1 Mon Sep 17 00:00:00 2001
From: Noah Evans <noah@nevans.me>
Date: Thu, 26 Aug 2021 20:27:45 -0400
Subject: [PATCH] follow.el: Fix bug#XXXXX in follow-recenter.
When follow-recenter is called in a follow window before the middle
follow window, the post-command-hook undoes the recentering.
* list/follow.el (follow-recenter): Set
follow-internal-force-redisplay when dest point is before start of
middle window.
---
lisp/follow.el | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lisp/follow.el b/lisp/follow.el
index dde140d0fd5..b64f4cb7348 100644
--- a/lisp/follow.el
+++ b/lisp/follow.el
@@ -858,8 +858,11 @@ from the bottom."
(windows (follow-all-followers))
(win (nth (/ (- (length windows) 1) 2) windows)))
(select-window win)
- (goto-char dest)
- (recenter))))
+ (let ((win-s (window-start)))
+ (goto-char dest)
+ (recenter)
+ (when (< dest win-s)
+ (setq follow-internal-force-redisplay t))))))
(defun follow-redraw ()
--
2.33.0
[-- Attachment #2: Type: text/html, Size: 27193 bytes --]
next reply other threads:[~2021-08-27 0:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 0:39 Noah Evans [this message]
2021-08-27 1:43 ` bug#50220: 27.2; follow.el: follow-recenter does not work correctly if invoked in a follow window before the middle follow window Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='DsmWQ9k4_RNGYmA3cUs-ALGKYGJzgqoJPRYpVAAQVF_dsbBeyeUUmhgAhQHrK9gG7-kbAKrO-hJMGfOkJcVBFBkRMpmJ6_wHe1mF8W91gmg=@nevans.me' \
--to=noah@nevans.me \
--cc=50220@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).