From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro Date: Fri, 20 Dec 2024 15:43:15 +0000 Message-ID: References: <20241219223632.37894-1-hong@topbug.net> <86pllmkfcm.fsf@gnu.org> Reply-To: Drew Adams Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5944"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "74983@debbugs.gnu.org" <74983@debbugs.gnu.org> To: Eli Zaretskii , Hong Xu , Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 20 16:44:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tOfAm-0001Nd-4j for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Dec 2024 16:44:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOfAa-0007fH-VK; Fri, 20 Dec 2024 10:44:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOfAZ-0007es-Cd for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 10:44:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tOfAZ-0005Hn-41 for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 10:44:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:In-Reply-To:References:Date:From:To:Subject; bh=MgtifrD4w9oS2d2r0fIf4hXPmgRl5YZmzMw471vDCzY=; b=Wi/8Q4j+2Uk0q8SZW6mukAMNNK47IJayt5RzQyg6aKYWO7LUizxCVSsF4fb6DEtrYKQaV9CPg3i1VoB9+hx3j1cl6oZ8kFCjgFSuWJrOHoff/7AiKbt7OqoGs3inFYNIpcjP1v1p8gbR+uYqGryMUv5m0GHCfFCxk9ybFpltq5r1+lI97Wy2+AKU0khDwo9o+sd81npybcDWYkwPG7l7dzARkWPHiNENW4w1/1QLUuSpshs5wrSt1nElIEqy07ZNeegSQqy0ZES3EQDXFT7mIAvjF4CarcvJ8gGSxvnnXBsRAgNXoFdHCS1XL84bv6R1uGKX8JEsUIJrUMu5OFTDEQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tOfAY-0007dk-1T for bug-gnu-emacs@gnu.org; Fri, 20 Dec 2024 10:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Dec 2024 15:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74983 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74983-submit@debbugs.gnu.org id=B74983.173470941829329 (code B ref 74983); Fri, 20 Dec 2024 15:44:01 +0000 Original-Received: (at 74983) by debbugs.gnu.org; 20 Dec 2024 15:43:38 +0000 Original-Received: from localhost ([127.0.0.1]:43701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOfAA-0007cy-DL for submit@debbugs.gnu.org; Fri, 20 Dec 2024 10:43:38 -0500 Original-Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:55660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tOfA6-0007cp-TS for 74983@debbugs.gnu.org; Fri, 20 Dec 2024 10:43:36 -0500 Original-Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BKFXqBf003024; Fri, 20 Dec 2024 15:43:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=MgtifrD4w9oS2d2r0fIf4hXPmgRl5YZmzMw471vDCzY=; b= eFLxv25vl9eCwSjqrvW+tlPyVe0WmNXoNJM51vtMctq8OIVJf3zJR3uTYngZHSeH sn7wjmNo+HSKudOhzsrtQyW8d7lXNlYtVO/CVdCKm90fe4n3fHRW3oOdSf/be0l0 xyHKVMFAK8731i2/DY/KUee6k9qpafulsxvXPb0TdLPc4Huuy54eXHsM5iUl4+5e Rbju2YKnivd7ucxZTMJ8laHC/HgYxwui5492QrLxX/nf8LDH94MC7bTmcH7HFX2e zog44t0UYwvyOTNm2AVnmHbEvWO/hhViMiZ6efOksnoqsWfpmPU5krMjqTEDhw5L SvRS4NcJhLl5m6nhASq9IA== Original-Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 43h0xb5hg3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 20 Dec 2024 15:43:33 +0000 (GMT) Original-Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 4BKESNOs032928; Fri, 20 Dec 2024 15:43:32 GMT Original-Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2173.outbound.protection.outlook.com [104.47.55.173]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 43h0fjtptp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 20 Dec 2024 15:43:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QhEw5tCb9iD2JLwt8zzA4bkB8MaTvo/w9CFTpZSZ/F+FRLFTXoNncnvfwPxO4PrkTKW9KIFI7/bbY7EN8VWAJpULX2IXaHArvhi1coHVA2xd9Qqrh7mSmdClAPEl+3en9R2ylTC7aZfSY7cQ4FLN2O4CK7RP45K/SaHMJF6JGB9FQhF3H1DGKQm8e2a6u9S0FFCDdkxDxF0ilCmlLcQYA4C2FOHHlcoZtRM3aHJedQpKq+qGu3+PluN86ZN3L+gyo5FlWC4o9I7dOJvzIMffneghnxjwj1MA4GiKAL9aU7CDRcXVHItPKzCXteQg1uCUWpmpqwoEBu3oH95+r8fUxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MgtifrD4w9oS2d2r0fIf4hXPmgRl5YZmzMw471vDCzY=; b=ghNVhOzYYa0Vk7iizDDpzVt7lKaUSunJ8GH6U9SKbX/W7Ytwtq3z4ABicx9KidaN86ykz0Yqay7+KCoBtkeLAPJs8v0XF1MzXW0mz5L+o4/dnjHz+w9DCCwZz4k5xMuFtlHEDocV5H8WQIxEmgFoOjRiF2xM2kQXDla8PZPi25ARNJhednynIdfT+LiSpRR6eCgTvzFfM6xMqzsJww6YBemaFvgCb3W4SVJcBfbowhO9Eoxa79GCO3c0dvuWP3hoQPvTuyMavME2oq7VkrDi4BUCgC+9mEv6BI/a8Tncr37rxSFymtcMVsd7ZMY+FBctnkytmqeKp7kqZQWNuyRqkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MgtifrD4w9oS2d2r0fIf4hXPmgRl5YZmzMw471vDCzY=; b=xVUFcsQGsjm8i/hRByfbRx1dlbufSzB7fa4WLJT7YjGC3kcoTFPyOcJpwqMEhzuG94WxqkefKjP0wBAaYAODJFhiU0025/vlpwm9FOXlw4q7O3dI/Zb+KkYpQSdgpnRhKFr9Hs2m6L4JKXxo0Y7pTGUUB3yzoJIArWLAKeyMy+o= Original-Received: from DS7PR10MB5232.namprd10.prod.outlook.com (2603:10b6:5:3aa::24) by SJ0PR10MB4526.namprd10.prod.outlook.com (2603:10b6:a03:2d6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.17; Fri, 20 Dec 2024 15:43:16 +0000 Original-Received: from DS7PR10MB5232.namprd10.prod.outlook.com ([fe80::8303:658f:14f8:2324]) by DS7PR10MB5232.namprd10.prod.outlook.com ([fe80::8303:658f:14f8:2324%5]) with mapi id 15.20.8251.015; Fri, 20 Dec 2024 15:43:15 +0000 Thread-Topic: [External] : bug#74983: [PATCH] Use `keymap-set' instead of `define-key' in emacs lisp intro Thread-Index: AQHbUq0wqKHW0ubYQ0KgxO4alosl3LLvRj+A In-Reply-To: <86pllmkfcm.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS7PR10MB5232:EE_|SJ0PR10MB4526:EE_ x-ms-office365-filtering-correlation-id: 55722b79-6432-42ea-456a-08dd210d0506 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: iE5ZMSBU4ewl/ohzP6ZkcPtMqFCsAqnTQY/kJSgzVFuI1/FgKWw+bBJPbn3XdrvkqI9gWoKFgOH0QVjESkLc0sHQEYkiYAQzG7wIxpXs2icieaZLg/vcywyhO4JiNTglC+Lo2gAPupLQpRxMy7V+kcEc3R6q7izGYeao2jBs7nBgbY4hAnP0NpZ3qrVoMAkSWH6TnNawPcrDsThh4pform+F+noWmmB9Qj6Hi1eYWRta63LWhP2Kj00NKB8Ai6m0OX8+V/14o6OpntRumtvai1UGmLTdaPZMmOBqC2xrc/RajTcnW3NFsb7IUQJIEgH4YL+RryivHJ/6K8jdWOpnVNlSdKkd0q0oeMjIpBMgqY4GZ1d7wBSMbIPWhoJtGSLdlaRir/vpNCthEaZXpa9zfnEy71vVOP+GthrjMxJiIJykGi8AVrlKzq5U3qN24U6uT0ZtxofgnASnXbd3a3uES0KyQRoLea7KGi/5sIECgii9AfodPUdXQS3juTvfDIF+HiTmJCfvjhku4BQf2fRfv9tU5PKN/RFc4R/72fTK+4XRNbUK67YaeTj4qJa1NSxRV/bt6oO2Zq4Hq6OnOjNHDnHaf+dSTB6nYlfDtqrF7h69yWWCLv3Mx7vG3l1CX1WeCWhWnVvvkbs4y311el/C0LDJVP3YO4iYtiZs9g4VJFqkUPw4v/6z/XERuKgmFQww7Ls9R56gJC3mq2ZQB4XPICStu3M8xuIWpJFQyplRc1AKVzo9xi5sioKf+IDOY 4Qn0gh496oQcPHsuj/x2NVqbCca34FVVJLi8fvyTnNwaYvHGBtrbMnLU0mTaV+ceK+SE/8F7w7AFFwc6xRxppaPAtthhKNwRJu x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS7PR10MB5232.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: olAoxWfzCznQ4Dv56/CRJbmrZlbvJbl8YKQKYWPo0dcsFqEwxqQEVGEbD44DRWKXQVC6gkCz3/9pAENI87igzaEicsd/D462wgpk2S8zuO6q7U0WDN9JinK0F7OOasMxr59/XHxt+7TlGdx501wTeoEbz75S8wKdtqAMlrgQPY+qOjXXnL2b3lJA5S259TeuG/O8+/BlZdUZ9HPzLjTVmMzgQGGjmFnF+vBU2cUEr0+FbKMA/8/0gHJ49XNxlKwOiWwLiWF2r5k3GFa/p6a/3RjDHrVsJ01Jw6dqSpQgN1zJ2GMs01flpZYQXfK3px3MwjrbW2BW+Vwk1NOtbbLbxvED2Mi0fil1LAFYN9YUUjprvHgjn5eL5D5SobeKOjw0iRYMCJjBnPM6jWLNmbJCxqQgXww40CsoZR0ebiS0EDIOjeVMwtaTas9yXufrRUv8tgBPNM2nxVHWu+zyIeRb7+5Hn6OWplTanJgMrMNz/rnDdGxrCzP9NL7XFfQo+P9KWeCbUaj2Ov4REWYhfYYhvLEejKuTrpnheTGo0LWbjMC573S5khO09/68hT7sq15C3BUIwEgpq1TsJ2GqirIHWmdDqb/92i7R3UdTwkuCe/Ky6q65SbyNN/KwHEgfEtPkx3XwuqFXOyI4CrtM/T3uAssAdIdV4uQlaWBjfg+5ByvuaI84jMdzF2FuM4x1kML/BJWDAt95AP6x5ZvzkGS8ZbW/1UqheT2vBldj9qLYcDXPYi32ZruwXEdhh6 CC0jsZXEUIWGxerpA8atrSIIKLinOuBA0yuwI0zZTLwJW6k1+7yLfYt0VI4gq+RoP0K8z7DlSJnzFTP31iY4G3avLSHcxS66kl X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: p83PnuzkzBQ1I0DhN58ezoIigwqbEn2PCTmHjxQJkZYrxM/b3RUgfIU1FVR9LDvX4BwEcrN055q23RRvjmRrSm6Q+09Nq6hJFeZ8P0rn+Xv9La1GqH8B01UxDOjUZQ+dgY22GJirlsnISBdwfv6DgDPNzY9oMuZB9QqMecEtniAnk7btJ0h+6WmYCE5m93PFwXs2dMSpX8XnFE95f+GUaCu6aaURLT8JrrS+NE89y5rd138UYlhnY41X8/CQEQ29+CA++/Sk1xzy5XagCJXhPBly8v2r5C9zZKqzw1zQyv0ZwqiXTR3zNJ0LDdIcZOIOsrftT18ub2fHgj4i9iH6rpjNerpW+CnQ0rL+6mbaXbdxyiU8a3awoNEtThhTpN61tk5Gm9ypUarDQDrK4Esyzo9Ik+kY3BTXNHuykA2nrbBKVTefxfMlrDtUOFIfRmHMDkpOinDNAoKByp7mLWyd412OPdlZOUVT79A+6f4Vlxuk1Jj9FkSmb6McArrsiBF+xyiMZiy/tHoWuzwefEFB4bprRC56X1qqa8TaPZ/3pFO38JC1Zn73JkYq2DKo3OCdYKkPKlq5b2UZxCyeOdrv4V76gUIAC+qfwFCq7wDtX78= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5232.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55722b79-6432-42ea-456a-08dd210d0506 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2024 15:43:15.9047 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mWyFPFjBWBb5rWFt+5NrCChC/rERcialTwJWpBSXgbjYi0l6bZKL+6R4XscymVhikX4rpHw5sSkM8opRSfD7cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4526 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2024-12-20_05,2024-12-19_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 suspectscore=0 adultscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2412200126 X-Proofpoint-GUID: UqFtRvJaaMJ4YDbEoK41bYhdFCenMMFK X-Proofpoint-ORIG-GUID: UqFtRvJaaMJ4YDbEoK41bYhdFCenMMFK X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297452 Archived-At: > So my suggestion is not to _replace_ define-key with keymap-set, but > instead describe _both_, explaining that as of Emacs 29 we are > migrating towards keymap-set, which is preferred. +1.