From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#61302: 29.0.60; rust-ts-mode does not show function-invocation on field-properties Date: Sun, 12 Feb 2023 02:48:59 +0000 Message-ID: References: <6209c097-0369-828a-7513-d8afb73fd7f0@secure.kjonigsen.net> <56a0b3d9-4a8f-0f81-83cb-6b78271dd782@yandex.ru> <3dc0ab0a-b0b1-91b8-f393-8db3899cf956@yandex.ru> <05ee38a5-f783-5b2c-add6-ee2ea27ba297@yandex.ru> <8a58c831-d8e6-c5b8-67b0-c606b2b3f189@yandex.ru> <33cec9a6-7e69-2eb3-a8a6-58ce23a5c185@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="607"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eliz@gnu.org, Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , 61302@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 12 03:50:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pR2Rb-000ATO-Ms for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Feb 2023 03:50:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pR2RJ-0007ov-SL; Sat, 11 Feb 2023 21:50:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pR2RH-0007oZ-2H for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2023 21:50:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pR2RG-00038x-Ic for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2023 21:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pR2RG-0004Li-9x for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2023 21:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Feb 2023 02:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61302 X-GNU-PR-Package: emacs Original-Received: via spool by 61302-submit@debbugs.gnu.org id=B61302.167617015716658 (code B ref 61302); Sun, 12 Feb 2023 02:50:02 +0000 Original-Received: (at 61302) by debbugs.gnu.org; 12 Feb 2023 02:49:17 +0000 Original-Received: from localhost ([127.0.0.1]:43666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pR2QX-0004Kb-7a for submit@debbugs.gnu.org; Sat, 11 Feb 2023 21:49:17 -0500 Original-Received: from mail-4018.proton.ch ([185.70.40.18]:52739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pR2QU-0004KM-9l for 61302@debbugs.gnu.org; Sat, 11 Feb 2023 21:49:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1676170147; x=1676429347; bh=TN/4skxNRhhjSOjYvwDoC7qhrTkDEDEfPHT3x4zgZWw=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=YLThrPgNf3uiSsDtXpq2LvyGUtLhDVuQlng7CUbxOgDzixGjzKh2Pc8k+7YAPHGiM q4nHmnz5Ubx7sKWsXbCVlospGstfF3ZnoPe/3i/0c1R1eAPJG2zqdb2VSnNuqXbr+y jEx0DCkwJHrYoVsm8xwQ1Eub+nxexDMArbaYpNzM22nfYWb7QXJxZ4EX3nCZfFN/Pu 5dBcpEqqw+ihQuFA/wQZjjT6PYKRmDrXpUjYJHLZ8L1Zuu7eHskEQLd2LCTLFmHsz3 MJrNUmyvfm+G1S0O8vLO74MPurccQSnfrfF7bb3rKHEjgnz8qSy9A2FdItwvjDS+yF F8gnf1/Ds9xXw== In-Reply-To: <33cec9a6-7e69-2eb3-a8a6-58ce23a5c185@yandex.ru> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255362 Archived-At: On Friday, February 10th, 2023 at 17:50, Dmitry Gutov wr= ote: >On 10/02/2023 05:44, Randy Taylor wrote: >> I believe so (with the exception of use declarations as you note). >> Not familiar enough with Rust to say for sure :). > >So this is a discussion between two people who don't write Rust. > >Hmmm. :-) You couldn't find anyone more qualified if you tried ;). > >>>>> So 'usize' in the above is definitely a "type", not a "module"? >>>> >>>> I think so. You can see on usize's documentation page (https://doc.rus= t-lang.org/std/primitive.usize.html) >>>> that it provides that function, amongst many others. >>> >>> I was thinking that it might also be referring to (apparently >>> deprecated) https://doc.rust-lang.org/std/usize/index.html. >> >> That module only provides the constants listed on that page. >> The usize type itself provides a bunch of constants and functions (same = for the rest of the primitives). >> >> I'm curious how other editors/IDEs highlight this stuff, but I don't hav= e any on hand ATM. > >Here's some overview. Thank you! It's quite comprehensive. > >I mentioned previously >https://github.com/tree-sitter/tree-sitter-rust/blob/master/queries/highli= ghts.scm, >which apparently corresponds to how Github highlights Rust syntax. E.g. >here: >https://github.com/tree-sitter/tree-sitter-rust/blob/master/examples/ast.r= s > >The capitalized identifiers are highlighted as "types", apparently, and >the lowercase segments are not highlighted at all. For some reason the >types are also not highlighted in variable and parameter declarations. >That seems like a problem, FWIW. Agreed. I guess they dumb it down for the web. > >If I press "edit in dev", navigating to >https://github.dev/tree-sitter/tree-sitter-rust/blob/master/examples/ast.r= s, >that seems to open some webby version of VS Code, except with a >different color theme. > >Some observations: > >- A lot more highlights. >- The "modules" and the "Types" have the same color. I like how neovim does it (which is basically how we're doing it, with sepa= rate highlights). >- The identifiers at the end of a scope chain are not highlighted if >they are a) lowercase and, b) not from a known set, apparently. Right. We can do better here IMO, and highlight them regardless because we = know what they should be (which is what my patch does). The exception being modules which require a little more care. >- So "use std::usize;" is highlighted and "use std::uuusizeee;" is not. >- "use std::foo::usize;" is highlighted. > >This also matches with VS Code's behavior installed locally. Neither the >"cloud" VS Code nor the local one use tree-sitter, IIUC. > >IntelliJ Rust doesn't highlight "modules" or types at all, AFAICT: >https://intellij-rust.github.io/assets/intro_screen_editor.png >And those guys usually write their own parsers, so the highlights are >most likely parse tree based, just not with tree-sitter. > >>> Sorry, I'm not really familiar with Rust. E.g. in Ruby every class can >>> also serve as a "module" in the scoping sense. As a result we highlight >>> both classes and modules with font-lock-type-face. This could also be a= n >>> option here, if everything else fails. >>> >>> But we could also highlight based on a "role" (constant if it's used as >>> a scope, and type if it's used as a type). >>> >>> Although one could say that 'Path' in >>> >>> Some(Path::new("./foo")) >>> >>> is being used as a type as well, and 'Some' too. So it might not be the >>> best fit. >>> >>> Speaking of 'usize' again, what if some lib or the app defines an >>> 'usize' module for its custom functions acting on it? E.g. >>> 'my::app::usize'. A simple regexp matcher will probably highlight it as >>> a type as well. >> >> I don't think we should worry about those cases IMO. > >Okay. > >>> Some problems from my testing: >>> >>> 1. If I keep treesit-font-lock-level at its default value (3), some >>> stuff gets misfontified: >> >> Sorry, I have only been testing with level 4. >> This is also why I want type and module combined into one so we don't ha= ve to deal with this headache. > >I'm not quite sure what's the best choice here (keeping in mind the >problem with overreaching variable highlights on level 4), but >logically, I think 'module' belongs with 'function' and 'property' >because all three denote some basic syntactic elements which are easy to >understand even without colors, and are harder to make a mistake in. I am proposing to get rid of the module feature entirely and bring those qu= eries into the type feature because: - Of how much overlap there is between them - It will make maintaining the queries much easier - It's already a headache dealing with them separately, and I'm not sure = the best way to deal with the issues of them being separate (and the differ= ent levels of highlighting to worry about). It will probably be quite the h= ack to deal with it, and no matter what I tried stuff was always sneaking t= hrough. - It also won't introduce that much more highlighting > >That is in contrast with highlighting of variable declarations, for >example, which in Rust can use some non-trivial syntax, more prone to >user error. > >>> use std::collections::hash_map::{self, HashMap}; >>> >>> 'hash_map' is highlighted as a type. 'HashMap' is not highlighted at al= l. >>> >>> use std::{fmt, fs, usize}; >>> >>> Only 'use' is highlighted here. >> >> This is because of how things are broken out into the module feature. >> That some highlighting for those occurs is by overlap of queries in the = type feature. >> Which again is why I think module should be part of type. >> >>> >>> test::test1(); >>> >>> 'test1' is highlighted as a type (we discussed this problem with >>> highlighting types by default -- it becomes necessary to filter out >>> function calls, either with more complex queries, or with custom >>> highlighter functions). >> >> Right, I added a query to filter that out now. > >Thanks, that works now. > >>> >>> 2. If I switch to treesit-font-lock-level 4: >>> >>> let boxed_i32 =3D Box::new(5_i32); >>> >>> 'Box' is highlighted with font-lock-constant-face. I think it's a type, >>> though. >> >> Oops, I accidentally removed the rule for that. Added it back. > >That too. > >>> Also here's a pre-existing problem mentioned above: >>> >>> use std::{fmt, fs, usize}; >>> >>> 'fmt' and 'fs' are not types. But they are highlighted with >>> font-lock-type-face. >> >> This is really weird, I can reproduce it with emacs -Q but not with my n= ormal config... >> Also with emacs -Q this: >> let date =3D DateTime::::from_utc(date, chrono:= :cool::this::Utc); >> >> highlights incorrectly, where "there" is font-lock-variable-name-face. B= ut with my normal config everything is fine. >> >> I'll look into it tomorrow. Not really sure what in my config could caus= e this... > >Thank you. I did a clean build and wasn't able to reproduce it anymore. Guess it was s= tale bytecode or something? At level 4 everything highlights correctly I believe, and with level 3 the = only issues are the module highlighting ones, and to deal with that I think= the module feature should be merged into the type one as I mentioned above= . Then we can call it a day :). I'll post a new patch with those changes if= you agree.