RE: View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t

["Drew Adams" <drew.adams@oracle.com>]

> So far I identified four groups of users:

FWIW and IIUC, I am not in any of those 4 user groups, with any of the
expectations you assign to those groups - and I believe that I filed one of
the bugs you have been working on.

I use non-nil `pop-up-frames', and both `pop-up-windows' and
`split-height-threshold' have the default values (t and 500). I have a
dedicated *Help* frame.

Because of `pop-up-frames', `display-buffer' uses another frame, but I do
sometimes switch to a different buffer in the same window. And I do
sometimes split a window, so my frames are not always `one-window-p'.

If a new window or frame was popped up to display a view-mode buffer, then I
expect quitting to delete the window and, if one-window-p, delete the frame
too.

FWIW, my own code takes care of the latter part, so it is enough for me if
the view-mode code simply does `quit-window'.

If a new window or frame was not popped up to display the view-mode buffer,
that is, if I manually switched to it in an existing window, then I want
quitting that buffer/mode to restore the previous buffer that was in that
window.

Summary:
    if pop-up, then quit => delete the window/frame
if not pop-up, then quit => restore previous buffer for window

> - Exiting view-mode should ideally (1) kill a window that
>   has been popped up for view-mode purposes and (2) show
>   the earlier contents of the window when it has been
>   usurpated by view-mode.

That would be good. In my case, #1 is what I expect for the *Help* buffer. I
have no problem with #2, assuming that it applies to buffers that were not
popped up in another window.

I haven't followed the current thread closely. If you have a Lisp-only patch
I can try, I will do that.