From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Smith Newsgroups: gmane.emacs.bugs Subject: bug#57651: [PATCH] image-dired tweaks Date: Wed, 07 Sep 2022 13:24:50 -0400 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36585"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: 57651@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 07 19:40:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVz2O-0009KG-RL for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Sep 2022 19:40:32 +0200 Original-Received: from localhost ([::1]:35990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVz2N-0000dV-F6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Sep 2022 13:40:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVytH-0005eR-1h for bug-gnu-emacs@gnu.org; Wed, 07 Sep 2022 13:31:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39163) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVytC-0003X6-8Z for bug-gnu-emacs@gnu.org; Wed, 07 Sep 2022 13:31:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVytC-0006L3-3e for bug-gnu-emacs@gnu.org; Wed, 07 Sep 2022 13:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Sep 2022 17:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57651 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166257180324201 (code B ref -1); Wed, 07 Sep 2022 17:31:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Sep 2022 17:30:03 +0000 Original-Received: from localhost ([127.0.0.1]:56094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVysE-0006I5-Rr for submit@debbugs.gnu.org; Wed, 07 Sep 2022 13:30:03 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:33854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVysC-0006H8-Fx for submit@debbugs.gnu.org; Wed, 07 Sep 2022 13:30:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVysB-0005G0-AY for bug-gnu-emacs@gnu.org; Wed, 07 Sep 2022 13:29:59 -0400 Original-Received: from mail-dm6nam11olkn20800.outbound.protection.outlook.com ([2a01:111:f400:7eaa::800]:63778 helo=NAM11-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVys9-000360-1S for bug-gnu-emacs@gnu.org; Wed, 07 Sep 2022 13:29:58 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GaFyqJomi+vvYtHdFrVQbYV2wprjvkBtiuimDof6F1uI2BEIskSoJhi7pg9xMYEe/u01M8BoTUppDYpKtY1/XSjWonhg9OO9smVuoJKUlM/ZEEn337qaEYQGFHtAFK3SJg6+uS0uzh5zCii9e3dlKdNxRKZ0hqxKW9G0uIuUFk3ehEiEVvdkGxmT2wsvOC6skXkFH3FYEVziXOuZDW3dAm3sDfgUf68Xkk9YDSu6CJhV9krPWVEejLGqh65KnWhISBh7zwkbFuXA7Z8Ds7SSV2wIIS4si7/FV73LCsRXCgTpjlOKQm8MvTr9I+q4/31N1hwbsqqJxojCAhiD6MUwiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SzCG5//Rkf4A0jmPN46vYWTsr3MdnqH2GuYVMDMmP4w=; b=S/qgEFmkh1N4l6xBfcajONtwYlF/nOqIZjYJ8qqxhx3H4qMuDtUNGaxaZpTwlh4q1O8R+NYSyxNQ2WYWZam8F+kECX3Px8tgkiOIte9Tsy4UIpRDwkxexENGZtBarguaFepfXuYaQZRC8DMXcc7DwhVr5CBmyt0Xj2A2Lon4y0HLfe0LnsXTZ0AOULTPC/gjoIlbgkbhJftalCoBAUTwBwBts1yW2diSYTEFZOVXjNS9byREP3wjkJkDjrAZLF2RQgrHM1N9ProFhbbUUBBNUaKpXvl9krsukpBazMKC+qpP5kLXcsCct+Kq2qvBd1HWdlDL8cGgj8NF1H0hoq08ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SzCG5//Rkf4A0jmPN46vYWTsr3MdnqH2GuYVMDMmP4w=; b=iZwu8CJgXQFJN/onur15vh9v9HFwg13UqAgDtarTv4YG9yeE1HTKs03tPTGqW5WJVSExwMgGe9OGgC0urCw1lmiUMfYHGQCnhNL8DBXzD+WeuPTdcRxflN44g1esoe+t2WjPExr6p/xVStzEFJxoctHR+JpG0RccOEsd6nVatvfVNl1U+ruBNWh0Krkfs7wUNZFK20Ag3dbHT6FZ3AC+BZeTvMalhsRGYIQcbBpCAPICRN5HJeiLudH8LJpHTZb8dgRbXt9TnD23DjWkJouPLy6ETHLiZqP3BkIgEkunz6H6bfX7ZEyQ57tIP1BsLZ/hJAxmbLoUDCOb4WcdonY7Yg== Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by DM4PR03MB6079.namprd03.prod.outlook.com (2603:10b6:5:392::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Wed, 7 Sep 2022 17:24:52 +0000 Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::1cf8:e25b:a93b:ffac]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::1cf8:e25b:a93b:ffac%6]) with mapi id 15.20.5588.018; Wed, 7 Sep 2022 17:24:52 +0000 X-TMN: [adsOU00PYMH6BXYOjR53NgGwtKRu4yMU] X-ClientProxiedBy: YT1PR01CA0152.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2f::31) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <877d2fw10d.fsf@outlook.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 83eb8e72-8e03-4fc4-eab4-08da90f5dfbb X-MS-TrafficTypeDiagnostic: DM4PR03MB6079:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +fhRrybAwXksmAOS10ZmmhAFxvR7DIQu5SPKgAsXZ0QySPZkJ19/iNysIOuFXP6zkbPhVLXgXYugxM7OzMz4N5Faatktl4VFRmRyiH1/uMS5P9JywUbomBo8uBd6VMjtrDvnDXf0aA5Ei8raHJnysYeYPN59C5aA1ZOWdQYPy1gtLk6Ov53jWvfHPkzHPC5rUXFkqakwFb9cHbQFRRhmz5u3HXLY1qXcp6rn42VkWjzlrzgXOGRtvkktUvq8MGikn/qmpYqgbti3E2ZZLil5Is0n6W3wnoqkcsAXfRndhiKVCiZfu1tPorlwVDImdcPuRKduEr4VAiw4kzTqInR+3Bo80mCUN+MLxgV8G+tCUm8iVdW7v6qvUHQsN0QjJNkZ997sGHzr5O+cEfV7IhOJS/6RF9oj6iiBuL17jXH9eXvgwgMlTXgN/0NMDw3NtaB30EveDRl2SXqIKVqByv+/8/SSO5frhKu4kY70czVpbtCMyx9YHTVg6kd+iD+U/2e1uEVNqPfes19w9izdO/ZU3aiW/2W13hQyecWOzHlVCnjmO/LK2Qrr9Y17k2wBe2Tbtr5TggoFmXTpOp4mlzAoCOR48hxSpCO43mhKofOenHGCPzez3BzlWZBdD0vIPbPnrCMYGlLAF6oHUWJv2XAgIA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: GJgvYF+b+3PrWu5rKUCk3Bimpi0IES8ZToTBqs4Q6v6CBAGTvep70qCP8az2urB8jHYUulNgKvTDFjyUYMc57/Y7KdajZwFK2ZrGrcUA0fbUlrtFUwqrqQUmieymKFe8h2B5sZIX+UsjrofA/gAuFtWDIGdAlZWzP73qVeKxIhShnDxdZQUIyGmDKFFippt7rVexmf9TMqnkDy0SxjKn28yTEPm2/jact8dPSuVowqFktggmisdGSSFGyRwsh1QgUj7XIsxoRtmYwBV/8cfJqvID3uY+CH9fEcZYHQl/K/zS8CSpQsFZ6cZYSMe1Wg1zWi6qtcSkN2EshdUq68Tf2M3E7lxTIS/CEVzpQ22Ttd6/f9QlxSpNJtZ/pB0k7v9TqZtuqRt8lOqZub9a6MYZhTTV/5f6dSx6ouJuRJB+OLvwYnuk0Syaulv12SsU+xkvs9EW7hms74lj6635VVDQ0JPg27p4fcx/B5ykoHGBlaUiSXBdE9lGDXOYS06WF5GPoDsWRLhI4KiW9v0uUgM6veXcI+vA3GOUl2H4/mzn6ZwlSa4yug3RD5wPDbwwi4diR5ZqX+1zC152GjrMCXaDaN/OytuTNS6Wy99fvm8/mjEF5kKGWps8N75CrSeSwY0/Bwcrwz9VA4DmEwKQyJmLyP8mnAeOiI3jK3cBNhSFkGjk4msejEllurx8yrJ4wQhzA4hMQygcJL2Ny/bqBm/X0CdvIhx/0hdjTGEv3tjkDVZzdOkZI3VhBk0K7O 8FEORqo+jBSaNojXFuEn87idTEqt6zXbo/TViEtBat8EQS00fS0PqwPNx4sEtNEHGc6rETwl9LdfdWp+l2WF5vrDKG9sznJvoU X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83eb8e72-8e03-4fc4-eab4-08da90f5dfbb X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 17:24:52.6211 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6079 Received-SPF: pass client-ip=2a01:111:f400:7eaa::800; envelope-from=Morgan.J.Smith@outlook.com; helo=NAM11-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241792 Archived-At: --=-=-= Content-Type: text/plain Hello! Explanation in the commit message. Rotation still works that same if nothing is marked. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-image-dired-tweaks.patch >From dd4b02bafd9590c4f5747aa2e3d16deceea07807 Mon Sep 17 00:00:00 2001 From: Morgan Smith Date: Wed, 7 Sep 2022 13:17:12 -0400 Subject: [PATCH] image-dired tweaks lisp/image/image-dired: (image-dired--do-mark-command): Make movement behavior consistent regardless of the value of `image-dired-marking-shows-next' (image-dired-rotate-original-left, image-dired-rotate-original-right): Rotate marked files if any --- lisp/image/image-dired.el | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 88f4ceaffb..e799f2e748 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -767,7 +767,7 @@ according to `image-dired-marking-shows-next'." ,(when maybe-next '(if image-dired-marking-shows-next (image-dired-display-next-thumbnail-original) - (image-dired-next-line))))) + (image-dired-forward-image))))) (defun image-dired-mark-thumb-original-file () "Mark original image file in associated Dired buffer." @@ -1126,7 +1126,8 @@ and a confirmation is needed before the original image files is overwritten. This confirmation can be turned off using `image-dired-rotate-original-ask-before-overwrite'." (interactive nil image-dired-thumbnail-mode) - (image-dired-rotate-original "270")) + (image-dired--with-marked + (image-dired-rotate-original "270"))) (defun image-dired-rotate-original-right () "Rotate original image right (clockwise) 90 degrees. @@ -1135,7 +1136,8 @@ and a confirmation is needed before the original image files is overwritten. This confirmation can be turned off using `image-dired-rotate-original-ask-before-overwrite'." (interactive nil image-dired-thumbnail-mode) - (image-dired-rotate-original "90")) + (image-dired--with-marked + (image-dired-rotate-original "90"))) (defun image-dired-display-next-thumbnail-original (&optional arg) "Move to the next image in the thumbnail buffer and display it. -- 2.37.2 --=-=-= Content-Type: text/plain Thanks, Morgan --=-=-=--