From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Smith Newsgroups: gmane.emacs.bugs Subject: bug#64055: [WIP Patch] Enable editing commit messages - vc-git-modify-change-comment Date: Wed, 14 Jun 2023 09:54:20 -0400 Message-ID: References: <87pm5yo4m7.fsf@gmail.com> <87legmnq4l.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2453"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64055@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 14 15:55:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9Qxx-0000Tq-Vm for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Jun 2023 15:55:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9Qxk-00014f-KZ; Wed, 14 Jun 2023 09:55:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9Qxj-00014I-7J for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 09:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9Qxi-0001YE-U1 for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 09:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q9Qxi-0004rh-GJ for bug-gnu-emacs@gnu.org; Wed, 14 Jun 2023 09:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Jun 2023 13:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64055 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64055-submit@debbugs.gnu.org id=B64055.168675087418651 (code B ref 64055); Wed, 14 Jun 2023 13:55:02 +0000 Original-Received: (at 64055) by debbugs.gnu.org; 14 Jun 2023 13:54:34 +0000 Original-Received: from localhost ([127.0.0.1]:44132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9QxG-0004qk-3e for submit@debbugs.gnu.org; Wed, 14 Jun 2023 09:54:34 -0400 Original-Received: from mail-mw2nam10olkn2107.outbound.protection.outlook.com ([40.92.42.107]:13677 helo=NAM10-MW2-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9QxD-0004qW-Ks for 64055@debbugs.gnu.org; Wed, 14 Jun 2023 09:54:32 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZbL8/bWY/aB1ucQkOcMo8tvFZJM0BTjc24Kdf6DFJl7r5XFSrlOPu4QACQj4aRpx32HW0/Drhk56JvdUj5/GGmPqml0hM3VvWIxFZudc6N0UZ34RKge8dGpj1hURhnFDXw/mzLDfD5J/qcbU7L62uUzSRqxkwL2yLyfgn71nxoU4WVR5q8y7AKYR9ifDJOxrrx6j+N7XWIGGa5Eex3TzJ/Aoqb9tSL5DOJULh3ZX1lbT4hcRSN+3J8hSxm0fiH7lKSyImz2J/REuy7v2hGRaAbrFBqGZe58vwQ1MEIfyl+SN4NhyR4hiRXnRVftT4YF8M4LFFnTNfqCWXqumSYCUTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xnMCGz4KelGTsxqrjRlzVw+dmiYeafkUWQ5I2yrq8SQ=; b=DJupWXrz6/BCWe3e4TS6I87QNRPpsDIdRyw/BzfyJ/Enm0ZMdkiafeEEsunwXfllUH328ZDhvXBvJB9shYNsZ57E9QbBD15xvsFklTCI01cJU+U4PWid2BLkagZq9MM/2ieF5cXvEOIhR6H3HKy9NK5+AiLC2qieNy6S6y0h93F2A1dXTuvSZBtbYtNt+C3mtwdTAoMCaDetGPFpnea869RedFskcynXz1NusBnKRf7/MVqk2YFIxtEPWF2FvBycCvGI3FSfcvq6jBQvMXBWqfAeaksgdiuW3AxvPn1gi8wZltylEu7MVFSVnCJjqwCvoGhRbT0o9ZbyE+BXc5QB5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xnMCGz4KelGTsxqrjRlzVw+dmiYeafkUWQ5I2yrq8SQ=; b=u4P2o4SLSFKNeZZVU0fLvtonhVbN2IQguOEIhf1X5DQtStT2pg9iVQpYA2rEDWgZjsd92p22cNne/yMTwNsCoILApOiUAjkJimCXPiIihkEhdvuwPy0XyAXl8zIH7mKLxAD1d88tSE1ZQTIY+BHGpleTEf2QEDBnAhP8dioOhSCRfIQak7T3ewbm99/LgUKcjCl6fAuTCk746FTmPwJlDQbWfo8tCTlIdX9USlNGum+xsD2SUjuxID3Xy0y3ljTvKoHbBeoHvJKzqofBy3ASSbe5k2wgcAVzs4oTWiRlbvKrSZ8+ngQDykknjgbE5qG48KzFOJrWlvIXU/t7WSCmJA== Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by SJ0PR03MB5567.namprd03.prod.outlook.com (2603:10b6:a03:28d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.37; Wed, 14 Jun 2023 13:54:23 +0000 Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e%4]) with mapi id 15.20.6477.037; Wed, 14 Jun 2023 13:54:23 +0000 In-Reply-To: <87legmnq4l.fsf@gmail.com> (Robert Pluim's message of "Wed, 14 Jun 2023 15:13:30 +0200") X-Hashcash: 1:20:230614:rpluim@gmail.com::Oc6vv7zyxIQujXur:0oQH X-Hashcash: 1:20:230614:64055@debbugs.gnu.org::G0WErIhkSX45fSeG:79Mt X-TMN: [PDdstHNnJnghkvmNKS68ukEFHI08pj+E] X-ClientProxiedBy: YQBPR01CA0157.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:7e::26) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <87r0qecfoz.fsf@outlook.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR03MB3163:EE_|SJ0PR03MB5567:EE_ X-MS-Office365-Filtering-Correlation-Id: 5088bed8-3c6a-489e-a8ee-08db6cdedbac X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1MEJ7no4/V09xvZm4Sj+P4IZCcLUqbD+c02DRZSHFAT97bVWJPlwaapl5E42ZR5T/tja3xTpVrwywIFtKOhgaJb0PhGyfvdCswcFEyLzzjaajD/SXquA/vvzRVe0FhhlUI8tP8puyZS0Qayiv6smwDog1WycJXELXzA8cs57qr4ycmJACVaOEMjxOewPivsnZ+xscS7PlaFT5DycOtHAawLHFInCcSbJaKBsRUxLTxxQtY28NqEGMa+TGhm9c5N83xIFYut8wSfbqGLuUR+SgCK4HwhVflKUw5vEW7NemLLOgSeoN8ewQTzjc90YVnwD3n4v4c74LGl7MNxQ6vgPhpm3dTWrW6by8GlOOnkzELsqvz2HOBRVaVuG9XhP+Tl/jbJyY/YYDjXusaLxH0LhXYUVbu2yAumPifTmIlIGhn3KnH9PBf80sU6O47e9yjzrMie8N6vMEE4uKUYifeKBzmRiqcKO9Pd20n1HgBsONpCaSNGHONz5RkWocxGAJV2dUW50mjmxXcw8qiSaXMtdB+qmKu8mjjf1glYPKwlUbT7YHvyCgNarmrQqExOREQctGkhXtD1PfQHaCULb84Si0EyRNOTAC4mnPZ1PgsJBjR4/1605Hr2CBXE1faQZ/Rbs X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DH7bMFGo97+d15e2TICeiVBDd11N6VT0RsUf+Itq5edkeS8VHxMRn2djD4fE7wCZkJ1acb59P9gPDr+kmCTdXmwcvgycm1IcaXhTiD5je0bMUW574SLJuDhnTYIdHgdaxMESksQ4y9V+tv1dEdbbvqM+J2ppcX7CaGAcNuj2V6Uah+WedkdyC2sZb+Lfq0U7s6p5BZtEw2Gz26IaKRraFwTpMIErJKz9T+JP9OzKojjz9YjMI/sd4IC8uNZ9Je4qQeVQZ0WhAQMqOcfINHVj5xBAD1pJFaSC9qzmyc4YVAzjyEtWoXXsJnkd5n0VBvhOnP1An2R8t/iKGs5iN4ej0sEoWeOLXrZPJ34V481qm0S4xz8M4cZm8iJxB6nTIH9suPYBxsGuwq41PQwvG4tx2WQI2e9TBmuN7MTj+GTkE8PJenv+ScOj915Cs9EV6YMPu09nrniUmyawu5Uwannczuq763uI5iERG20wWVXK12ZUZ9H5Fo5pHC5U6Z4/vpob21n2bOyDOVBAXa2yXi2n7vmDzHvKtfmMi+THvgJAAMvhOsF99LLHyTkDmzePdZUC7KcxHsvCVCYO2DVxYLtwAE13HmaZIYb2EhGh+RChwA7RuVdq4GHJNPRKUiYMPmH7O7K3Hoiwu9m++hJB4q9fLo8DbpY/NZtK0VQlwRHJHds0Marj/B/+H58JKXnBwnMouEMgYJjQPcoMZRpZAMRtbMGA1HvFl3RbJR2J6nn/VaUWYNDXhBWLXkun9M pSzBUOFIwWxV4X1YFDVxpQ3CunbgG+EmS97rjTK+eEVyJdmp9E/hNASMR7FZhUCees81Vme8bdMQdyZ8Eb81VetlckoPjCDYgm X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5088bed8-3c6a-489e-a8ee-08db6cdedbac X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2023 13:54:23.0423 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5567 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263373 Archived-At: Robert Pluim writes: > Yes, eg magit=CA=BCs interactive rebase is great for that kind of stuff. = I don=CA=BCt > know offhand if it uses autosquash. I look briefly at their code and they use a perl wrapper around the interactive rebase. I suppose that's another way of doing it. I don't think it's any better or worse then my approach though. > > Morgan> 'git commit --amend' is actually already built into the Emacs= vc system > Morgan> and works great. I don't think you can use it without a diff= though. > > Fixing that would fit 99.99% of the cases where I want to reword a > commit message, and I suspect I=CA=BCm not alone. Strange. I'm usually working on at least a couple commits at a time. For example, if I'm working on a change and I notice a typo in a docstring unrelated to my change then I'll stick that into a commit. Then I'll fix up all my commit messages at the end of my session. Regardless, the current amend logic is great if you need to amend code changes. For the case without a diff, you could simply use the feature I'm adding here. Morgan