From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Smith Newsgroups: gmane.emacs.bugs Subject: bug#63778: [PATCH] Use comint-pager in eshell Date: Sun, 28 May 2023 22:26:14 -0400 Message-ID: References: <36a8613a-7601-14d5-c659-3bd86708b63b@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7139"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: Jim Porter , 63778@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 29 04:26:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3SaV-0001gz-SR for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 May 2023 04:26:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3SaD-0008Cw-Op; Sun, 28 May 2023 22:26:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3SaB-0008Aw-7A for bug-gnu-emacs@gnu.org; Sun, 28 May 2023 22:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q3SaA-00048f-I8 for bug-gnu-emacs@gnu.org; Sun, 28 May 2023 22:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q3SaA-0002kO-3m for bug-gnu-emacs@gnu.org; Sun, 28 May 2023 22:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2023 02:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63778 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63778-submit@debbugs.gnu.org id=B63778.168532714410529 (code B ref 63778); Mon, 29 May 2023 02:26:02 +0000 Original-Received: (at 63778) by debbugs.gnu.org; 29 May 2023 02:25:44 +0000 Original-Received: from localhost ([127.0.0.1]:56717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3SZr-0002jj-Oq for submit@debbugs.gnu.org; Sun, 28 May 2023 22:25:44 -0400 Original-Received: from mail-bn8nam04olkn2085.outbound.protection.outlook.com ([40.92.47.85]:3645 helo=NAM04-BN8-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3SZq-0002jV-EE for 63778@debbugs.gnu.org; Sun, 28 May 2023 22:25:43 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OnyMK8g+y+lwvPFThUA+QGtrjSMMlz0bFJcptTRbREwe03uz5ghVEAhJNcd8wADnVbmq61VN4t4sKgOEf5jzyckjx1DHYEuUbzTX8tuLDPGT0EQSsf/Mu4WYFnEapTe5HotBarUOdaZOn8Q5tua5dQJ/NeKGu9m03KXkySOFj4achgm2/UfiCXHl2pbPeDumF4a7ziWAGTuSF0wexgmqgD3XBChHd18HU3NHuBAKiZyvIe8aR6fvxFM41n09zg9/wPXgOQisp6itkkXijAvVsyAqOrGF7d9R4MEQVJnhaiLTrjAbDUiz6Ukc+l1piHXdlw9YiQflyMxFNZwYHzjlNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qRPQ7spgchv8NyYkFlF+RN+Juh7gdpriVn0K9U6YJVY=; b=DaZdTX8X3WVQs/AkzN6hJBMPZJ9wyqVXAvse7GorGOaFhr0JVux+SH7W0vmPOO5g8zSCODLpfj7+0ECOiVDT+zjfnvKtRDdyrUpEtll90goaN7kFPFnkQK3tYa9r43XTjnvefJ2D6GZj6EHiTX0/9WsIdeFZU5IMjSzmDwkFXWTMH93w8kYsNfAmgfYEYOn+qIiZm+vhmyM4eZrw+X4MGIq5tWDUs5a5YJommpONEX5ahEq7e3SqQ6Mujs556b2lGbpSVRhZSZkZwRdrZqgWTYFtnHwNU/aSPOzFthizUytkXSZkJkDJefKw4x3yQnFRnUV871EHGEF/o7pMMuAYng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qRPQ7spgchv8NyYkFlF+RN+Juh7gdpriVn0K9U6YJVY=; b=pohgPCyD9h+oqSh2DsqPuD0WpmIsJlTN4bUmNcbOomoOb//UowKqILqwHENc5FQisVCnJwW40g6UJ4mhRlQuYV6gIoTOJGvt/DPxuPA24mXN94qSHSUFx6tPs3Si6uz/N8+vJt2c4gtYEVBJNbQ+VE5Utkcp9V3LsFOS0jvTBdeio80rwsg164Bey8JgiS/W3ERYJNWPdwWTtS5pV0f1BarXL/IRuGPMMYHgBhksofvmuTXJ98s4Zehtv0B5cRtVJdlBJ2HXwoLb/C6CDzjM4DG+p9u2exQcTmoGXaPdpVv5rvpa4lMuOsm6UWU9SyDG/tDCHzCt05o/gEpkUGTVHQ== Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by DM6PR03MB5180.namprd03.prod.outlook.com (2603:10b6:5:1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.22; Mon, 29 May 2023 02:25:36 +0000 Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e%4]) with mapi id 15.20.6433.022; Mon, 29 May 2023 02:25:35 +0000 In-Reply-To: (Morgan Smith's message of "Sun, 28 May 2023 22:09:52 -0400") X-Hashcash: 1:20:230529:jporterbugs@gmail.com::MPzg4XOif4g7MdjD:QN4 X-Hashcash: 1:20:230529:63778@debbugs.gnu.org::Iy45CTWLtmGERUxZ:1agq X-TMN: [6FNXUidKxocCqpGFRU5zsB2CkGylHBus] X-ClientProxiedBy: YQBPR01CA0125.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:1::25) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <87353fna9l.fsf@outlook.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR03MB3163:EE_|DM6PR03MB5180:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a34319f-5861-416b-e710-08db5febfc10 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X9BkU5ClXHhvOUlDNuiRwAGCRWY0eJAf4wiKOv5DZ3ENCSMBQi4M+ynOSinWosHrl75ZC8MDiNphSVqDpgDF71cyR/5WFcC+1dCUkVrwhaXi4ZzI8QsVT/7t5ECHwHCoPadz+XJwnxEEVp+w9WU2ds2nixqA14I62QYxvy3Gyqm/CIuPIZolYAZ6eGQUor/BK+eIA8M3SZwzhYV+l5BmfEuCqYQFPX84Bc6LFJqHperO6jvv28cjzDoJCLCXDGkSEJ4aG4jq5hA/K3SWYLH7aSpfusdJHDJGeHww/9nyP7Bgw7PtLBKZM/dHUxLhNVf4ZOxC9zg6C7/LL+QAySRCzRlq8PhQnwFwjzfXIsJ1PNJD/ZiYUVpl5qg7IN6T/9gTuuVrlM2RhoF5qYD/UGn4ty+1mhLZoCnw6nVb/LmX+/hKQqZkcK2+tnIk2N41GQej2bTSex/lqwVzdULN7ikqCaEy3ufZf7XmUn63FFOSMzFHQ6ub3GapCLPR4M9GRVOQUY5O6kp09r9tZ0AujsJHbp/YlqRR7T8DLoYB8HiwBPhMyeERb3i9cjz8psTYO0i37rYP+fP7hmeWIApE5R+Pn06wyDUp7YH5sVMDynpcV93juRzTxYGSs9mnBT/eW4SC X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: dC7jlNuX/idcLyqVJoj5KdDNemTEPCyzrYw7W1qX8LRLm85UoT+JhKPh0zIsPZCePwNGWyEyUJSOcPz/lAeiBxFXdVGoTygHI6Qi0BDeWg1pv0M7ka6539SjjBEwHZVIFnb7oCl2V7sBFvw2hXoHNE4Gf0i+M62YxyOfw+/NfZSBlSK3cLPRBFjLzlmdQHxTT2DtQNssWRNVCXb4mFb8SKy/lpAG+cMpiolQVfwvxHghpQWClfe2vd0yUs4WNLtR5Q6KvY9yHL+VD4ksqbpBzB91i7XRkWKNigE4xsHvSayBlQlsKDC2L80w30U6xTnjsFXfI1W0b8wfxtuM5EbP72HojAbTsDq2QSD0Eqes07EpVqgT2wFXrWZryos2pAt7WvKUMBr/HNl/pa8oaC72H9E6mrN8F6+XbryUhz3AwvjhPQNurtikn8txiT6MyOfJyuVppCjdF2X9dcTOAvu7MiSw7FZKuYoI4dI5YW4bSL/KbaMiajCJgCTxjfBQgCBv0YzuCTDmFN60jUV97cCvLzF73LHokJHsYKGGPoMx2Dx7lXxw39FDCOpVgF5UnQQSo6wPmsLJ6TRAl88FW4PzRkJwvEVfx/0x7EGOQe/8CMMe6h9/5QGY0k9nNvy8+ouVTxk/oRjaD0ujVCp4JE4waLn6zKlsaTyae0eIOGEvDPEgPsFN9hrqIULDQ5bgycbZXRLeRlRSynD0v66SMbWCHGYlRkAQ1oLUH7EUdxdrp41KjA339OHndN+1Q5 sd0vLyU95iC11pO8kqUjVfmZ/v4rzdivKxbyWxhQ01eQh1llNyOZqlTrrvry7WGEb6NSTXET1QCFNA8Dlh64i0ZtvtILbP/S5B X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a34319f-5861-416b-e710-08db5febfc10 X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2023 02:25:35.7531 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5180 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262556 Archived-At: This is my very official petition to change gnus defaults. I have added this to my config to avoid future mess-ups. (keymap-set gnus-summary-mode-map "R" #'gnus-summary-very-wide-reply-with-original) Morgan Smith writes: > Jim Porter writes: > >> On 5/28/2023 3:45 PM, Morgan Smith wrote: >>> I know many people set PAGER=cat for eshell so I wanted to add support >>> to eshell for this recent feature that was added (comint-pager). >> >> Thanks for the patch. While I'd use this myself, I'm not sure it should be the >> default though. Eshell lets you define visual commands >> ('eshell-visual-commands', 'eshell-visual-subcommands') that will open up in >> M-x term. That way, you can use "less" (or whatever your default pager is) as >> usual. If you set PAGER to "cat" or something similar, then you likely wouldn't >> get the benefit of this visual command support. >> >> Maybe we could do something where we set PAGER like in your patch, but only if >> Eshell doesn't think the command is visual? Perhaps you could keep the >> definition of PAGER in esh-var.el as you've done here, but then in em-term.el, >> add an appropriate override for it? That way, a user who disables the >> eshell-term module will always get PAGER=cat. Users who do use eshell-term >> would get a behavior compatible with visual commands. >> > > I haven't the time left in the day to investigate the conflict between > visual commands and this patch (which I will do) but I would like to > comment that I believe most users will use one or the other, not both. > Unless pagers offer features I'm unaware of, I believe it is a better > user experience to simply dump everything into the current buffer and > use Emacs as a pager. For very visual command like pulsemixer that use > ncurses stuff I don't believe having $PAGER set would really affect > anything. So I would like to ask, does anyone actually want to use the > visual command stuff just for paging stuff? > > I would also like to point out that the default value for comint-pager > is nil so people would have to turn this on manually. If the usecase > for comint-pager is significantly different between eshell and other > comint stuff we could consider a new variable specifically for eshell. > Personally I don't see a big difference between say ielm and eshell so I > would like to avoid this but I'll bring it up regardless.