From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Smith Newsgroups: gmane.emacs.bugs Subject: bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate. Date: Mon, 05 Jun 2023 13:50:02 -0400 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3925"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 63913@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 05 19:56:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6ERI-0000qY-1n for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Jun 2023 19:56:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6ER2-0005qo-Co; Mon, 05 Jun 2023 13:56:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6ER0-0005qU-B3 for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 13:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6ER0-0001Nt-3C for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 13:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q6EQz-0006mj-TZ for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 13:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Jun 2023 17:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63913 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.168598772026022 (code B ref -1); Mon, 05 Jun 2023 17:56:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Jun 2023 17:55:20 +0000 Original-Received: from localhost ([127.0.0.1]:50321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6EQJ-0006le-Kh for submit@debbugs.gnu.org; Mon, 05 Jun 2023 13:55:20 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:48530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6EQI-0006lW-4J for submit@debbugs.gnu.org; Mon, 05 Jun 2023 13:55:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6EQD-0005m4-M6 for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 13:55:17 -0400 Original-Received: from mail-mw2nam10olkn20817.outbound.protection.outlook.com ([2a01:111:f400:7e89::817] helo=NAM10-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6EQA-0001A4-Ao for bug-gnu-emacs@gnu.org; Mon, 05 Jun 2023 13:55:12 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FvcEICG/x6zJ6pTmlZ+kO0mz0PntWxXe4FREvlDxofMHusCi3IGLEY41POpeaEAntIs2tke+aZC9zpbOgEBTCW+qi647N5VKOAPgXRsH5LmxNSdKylWC3At6Ms+/UOgpaaaXqXEYKU4i1I8laG2FLIJLE9rT8AEGOaiE2tlr48w5E2n8lWSoBhFyJpXa6mreUSKCli6B6zBG79eVefcb6Qwip+78pK3eeikTCb5m9l3RRj5KC2+/1a/Ye67LQe8K5z2S2udkse8rywTyJBsStD7JFfyaaFekEnXTlNFM+mlCkmhKoKLzFpy0evxL7HJry8kiudBAAjMZtJIZDQ4zoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wPuTC7kYkyPGluZAsN8ZiWVLHySkXSElRDeBVNYaZwc=; b=iylYfWhV2UjeDffMRptABIX2TN8/thN0uhVDAraG1XVG+vJLX8Pwno61J6o2qpfbsqqE94kga5zdKCnPpYUdA2yRy2bWdk9x1st1CYgn8E7AgvKwVjfKEsTActtIkMfjMH5wG9a4ATBCeAQyiD5SyX1oYfvQ8c01vz9oX5yaxLNBy1AHzsPfJMmHJ2rhvsmnOCSvV1J6cuOvVhZggtFNOj6pbpJ1EMMglly+f7p2wIOYTqd4kPr6QNBYwSvr2ZDJ+fq+RrtpdmvpCqT2yHcf64RDlsRl+YQi/JZTIyYEzoXSS/Gu5X0M1Ln8ohWJUggAsNF/YExqZbQDQoha6nPNDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wPuTC7kYkyPGluZAsN8ZiWVLHySkXSElRDeBVNYaZwc=; b=RvfhxNcmb/9/R9ra6H4VaMPLEw7ypoP2Hkc8iFLsuisZvgAHnbcLSlCe1lnD4lXPTdfDoORnHMnNg+vFuXAfx+f+Y22qoU1rGiZufpdmTwTQCqNtKCeKYnOOtTc+xeCwj45epMXwzGr6gQ6CbxTI0Mp3/cTAKrC7s5QJUiKrtExS1C/cB2XfWlO9wugG2Venc/856Lp6HfPHr5HfzO3lr4W9dEAq4/MiCVGCexmQybriVPGgJXWXtp7TtHsVpMZxOfopUigqSfq9ANv2JGEK7cJS7YjISijDuZvz9hovfLQlxnkWxcJPyv0vaFhGQAwSzo2CI21N+i/kB4zD3H5TKw== Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by LV8PR03MB7400.namprd03.prod.outlook.com (2603:10b6:408:193::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Mon, 5 Jun 2023 17:50:05 +0000 Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e%4]) with mapi id 15.20.6455.030; Mon, 5 Jun 2023 17:50:05 +0000 X-Hashcash: 1:20:230605:bug-gnu-emacs@gnu.org::Do980ucYL3Ep3+Bt:1FpD X-TMN: [UINnydE21OeNVe1ObL92I5LwIteGEeG9] X-ClientProxiedBy: YQXPR0101CA0064.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:14::41) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <878rcxhk8l.fsf@outlook.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR03MB3163:EE_|LV8PR03MB7400:EE_ X-MS-Office365-Filtering-Correlation-Id: 324f4947-755c-4de7-a47b-08db65ed4b29 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7I98IUZtLZqLSxO/FyDaUatuDmOSKZZomDU6MPldzWXA9gLUKsqXQ7sRGu8z0nHAEFt0J4LFxsHe9MXRH0yglvJJWZMmObM8eHixXC6bNFR013pcGSEmuOCOdS7Xe1Qd3NX8BeSrhGiqYRlS7z0HfXj9awrme9QYVjfrHIL1XE/8lQ0+/UhtsSJYS/XctfCdFP4/Lw1QDnPOG/s99QXM3wlxytanl/Sqdf5VS0DeK2U1VSIh4NHGegpBx5GTaBxIW2yw7RRIsneoK2Mq4amznVAmRrSK0eYT5YDNBG2u5v5hbFZCDKxN+Z9olCK6kh3tFURWjPWEuZBreMyVGnExEmRxY9kNYaOLnviAXtqOGOiyxbLu0qTa4gH/1amUZvk94knTzJkgmBVwqSL1lhNWCmPFRCKor7NDUTRd5QvPwtAZVw4eZPly+TVzRMz7JhFGfWTQWr2bdp4QihgiicVU8VoquTW0JFbvXtmAuqDaER6bzvkpXMHCnFKTFsnTsC3mWTZAKU/9ZRHUN6Nz7P1Mi1OhYpYjuCKHgr4mupHbzQjToRWrIp45a3I17UI9K17r X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: EzQVpGYumcs71+iV2cFCf7rosDckCMB95pZgaLIbQXdmyMbWvGc6B0Z9zUuokIHgaG+A34DdEHeXrcFZrGcsGAlgnOEVuGeDUVWc1LxAI7JUNU/4n52WFwR6YEDWStdZvXXiyFMmph7mbMB9CEGjA7Qi0ixrKnCUng/0/oNH/4AUxRyBmGRaXCvqmkU21WhzksHKuFda35uK0nnaHn6NovvmNQ34MCe4nB500rJOdQq2ycFnWhRRABzFuv/wY4eDEG5Y5ccH96E+LT3OzD4bgOK13Ngg6BtUHzYxjWKwDk3Me3AUyjZ8dWXsVnaq8O/rMmnDwfWW+rd9TXRZPX0e6NvquOIU4KqN3LEQ10DvRqbBEp0QUmXRamJHNyaPwIvicD1bFrrm9rKaNrNnO8TWvR1QpxrmOQo76rGDWhvLoHb4oiL+U2T8qC3JZ6/caL136PewF0q5lUkkwYK/cPVMI2pUu8zJ5vP30JEsjRqTY5Ws9MTJOMc48tre5CZHIAy76vxLRq9B1XhMCE5WLxH4odAzfs/2nmCNtI1MLy9FjNhA874A0YpZTkg48OrVtAYE+bUPa6bGatOSCkcgZkGeiEuWZlDh1NjS3U9JPDs2wthG/8OZVJluf3HPCijL1TYnkpPPkmVyp/t+B3DbOiS4slTJF3McP1UGRpL6cwcsYpbAp9spL3qrRH2fK2IOZm7E1djcrpH2PooLpI9/BpjsoawRxryDitBHvoyosWokW9+NODwQd8fM5jODWe hWp4ZeZi53enRT/OI3CxReQe34NetMAn1dHO5Vkebvjyaw/hClVGZugsIdZFPDilxdS5JnSDt9etWjYReHCPImSF7MyukDbfLP X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 324f4947-755c-4de7-a47b-08db65ed4b29 X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2023 17:50:05.1374 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR03MB7400 Received-SPF: pass client-ip=2a01:111:f400:7e89::817; envelope-from=Morgan.J.Smith@outlook.com; helo=NAM10-MW2-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263027 Archived-At: --=-=-= Content-Type: text/plain Hello, I think this patch is self-explanatory. In order to get the ding you have to "(setopt completion-auto-help 'visible)" and try to complete something successfully. I was doing 'M-x eshell-command-mo ' to complete the symbol eshell-command-mode. I'm not sure if that's actually the complete minimal setup, but I don't think you guys have to bother reproducing it since it's pretty obvious my patch is an improvement. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-lisp-minibuffer.el-minibuffer-completion-help-Only-d.patch >From 991ecaa8501a4eee8ab5073587462a0f7e36c488 Mon Sep 17 00:00:00 2001 From: Morgan Smith Date: Mon, 5 Jun 2023 13:34:59 -0400 Subject: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate. (minibuffer-completion-help): Ensure ding is not called on a successful completion. Ensure ding is not called on a failure if completion-fail-discreetly is set. Also change "No completions" to "No match" as that is what is used elsewhere. --- lisp/minibuffer.el | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index a1379913886..d26866370f1 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -2384,9 +2384,11 @@ These include: ;; If there are no completions, or if the current input is already ;; the sole completion, then hide (previous&stale) completions. (minibuffer-hide-completions) - (ding) - (completion--message - (if completions "Sole completion" "No completions"))) + (if completions + (completion--message "Sole completion") + (unless completion-fail-discreetly + (ding) + (completion--message "No match")))) (let* ((last (last completions)) (base-size (or (cdr last) 0)) -- 2.40.1 --=-=-= Content-Type: text/plain Thanks, Morgan --=-=-=--